Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export cmake file for catch2 #253

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Export cmake file for catch2 #253

merged 2 commits into from
Nov 4, 2019

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Oct 30, 2019 •
edited
Loading

Specify library name and version: catch2/2.x.x
fixes #252

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@uilianries
conan-io#252 Export cmake file for catch2
8ef5c3a 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green! 😊

danimtb
danimtb previously approved these changes Oct 30, 2019
View reviewed changes
@danimtb danimtb self-assigned this Oct 30, 2019
SSE4
SSE4 previously approved these changes Oct 30, 2019
View reviewed changes
@conan-center-bot
Copy link
Collaborator

All green! 😊

@Morwenn
Copy link
Contributor

Morwenn commented Oct 31, 2019

ParseAndAddCatchTests.cmake is nice to have, but the more modern and safer alternative - catch_discover_tests - is in Catch.cmake from the same directory.

@uilianries
Copy link
Member Author

How did I miss it!? I gonna put it in, thanks @Morwenn !

@uilianries
conan-io#252 Copy Catch.cmake
91d9ed9 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries dismissed stale reviews from SSE4 and danimtb via 91d9ed9 October 31, 2019 12:48
@conan-center-bot
Copy link
Collaborator

All green! 😊

@danimtb danimtb merged commit 8c7d82f into conan-io:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] catch2/2.9.2: Expected CMake scripts to be included in the package
5 participants
@uilianries @conan-center-bot @Morwenn @SSE4 @danimtb