Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expat: fix CMAKE_POLICY_DEFAULT_CMP0042 injection + add test_v1_package #12059

Merged
merged 11 commits into from
Aug 6, 2022
Merged

expat: fix CMAKE_POLICY_DEFAULT_CMP0042 injection + add test_v1_package #12059

merged 11 commits into from
Aug 6, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 5, 2022

  • CMAKE_POLICY_DEFAULT_CMP* must be injected through CMakeToolchain with cache_variables, not variables, otherwise it has no effect.
  • add a test_v1_package
  • add cmake_layout (the default one is an in source build, and everything is mixed-up in source & build: patches, source code, build artifacts)
  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Aug 5, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Hooks produced the following warnings for commit 21bf380
expat/2.4.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.6 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.

SSE4
SSE4 previously approved these changes Aug 5, 2022
View reviewed changes
jgsogo
jgsogo previously approved these changes Aug 5, 2022
View reviewed changes
SpaceIm
SpaceIm commented Aug 5, 2022
View reviewed changes
recipes/expat/all/conanfile.py
# Generate a relocatable shared lib on Macos
tc.variables["CMAKE_POLICY_DEFAULT_CMP0042"] = "NEW"
tc.cache_variables["CMAKE_POLICY_DEFAULT_CMP0042"] = "NEW"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires conan 1.50.0: conan-io/conan@a5eab30

@SpaceIm SpaceIm dismissed stale reviews from jgsogo and SSE4 via 586d1cf August 5, 2022 08:32
jwillikers
jwillikers previously approved these changes Aug 5, 2022
View reviewed changes
jwillikers
jwillikers previously approved these changes Aug 5, 2022
View reviewed changes
uilianries
uilianries previously approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of work!

SpaceIm
SpaceIm commented Aug 5, 2022
View reviewed changes
recipes/expat/all/conanfile.py Outdated
if not is_msvc(self):
del self.settings.compiler.libcxx
del self.settings.compiler.libcxx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, it must be protected with try/except for CONAN_V2 mode: https://docs.conan.io/en/1.51/migrating_to_2.0/recipes.html#settings

@SpaceIm SpaceIm dismissed stale reviews from uilianries and jwillikers via 637e87a August 5, 2022 17:18
@conan-center-bot
Copy link
Collaborator

All green in build 6 (637e87af780baad52f7b3e5f2bda9ee8d5819911):

  • expat/2.4.8@:
    All packages built successfully! (All logs)

  • expat/2.4.3@:
    All packages built successfully! (All logs)

  • expat/2.4.4@:
    All packages built successfully! (All logs)

  • expat/2.4.7@:
    All packages built successfully! (All logs)

  • expat/2.4.2@:
    All packages built successfully! (All logs)

  • expat/2.2.9@:
    All packages built successfully! (All logs)

  • expat/2.4.5@:
    All packages built successfully! (All logs)

  • expat/2.4.6@:
    All packages built successfully! (All logs)

  • expat/2.2.10@:
    All packages built successfully! (All logs)

  • expat/2.2.7@:
    All packages built successfully! (All logs)

  • expat/2.3.0@:
    All packages built successfully! (All logs)

  • expat/2.2.8@:
    All packages built successfully! (All logs)

  • expat/2.4.1@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Hooks produced the following warnings for commit 637e87a
expat/2.4.8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.
expat/2.4.6 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libexpat.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 9c63bf7 into conan-io:master Aug 6, 2022
@SpaceIm SpaceIm deleted the fix/expat-2.2.7-cmp0042 branch August 6, 2022 11:05
@SiarheiFedartsou
Copy link

Could this PR cause the problem that EXPAT_VERSION is always None now? Project-OSRM/osrm-backend#6299

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 8, 2022 •
edited
Loading

Maybe due to layout usage. There is a fix in conan client : conan-io/conan#11790.
/cc @franramirez688

@prince-chrismc prince-chrismc mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@SSE4 SSE4 SSE4 approved these changes

@jwillikers jwillikers jwillikers left review comments

@uilianries uilianries uilianries left review comments

@jgsogo jgsogo jgsogo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SpaceIm @conan-center-bot @SiarheiFedartsou @SSE4 @jgsogo @uilianries @prince-chrismc @jwillikers