Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Bad legacy cpp_info if layout is used #11790

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Aug 5, 2022

@franramirez688 franramirez688 added this to the 1.51.1 milestone Aug 5, 2022
@franramirez688 franramirez688 requested a review from lasote August 5, 2022 12:38
@@ -30,7 +30,7 @@ def package_info(self):
conan_json = client.load("conanbuildinfo.json")
data = json.loads(conan_json)
self.assertEqual(data["dependencies"][0]["version"], "0.1")
self.assertIsNone(data["dependencies"][0]["description"])
self.assertEqual(data["dependencies"][0]["description"], "my desc")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I'm missing something but we weren't saving the description before those changes.

# Let's avoid losing this information.
conanfile.cpp_info.version = conanfile.version
conanfile.cpp_info.description = conanfile.description
conanfile.cpp_info.public_deps = public_deps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was easier/cleaner than changing the CppInfo class.

@franramirez688 franramirez688 marked this pull request as ready for review August 8, 2022 06:13
@jgsogo
Copy link
Contributor

jgsogo commented Aug 11, 2022

Is it possible to include this fix into 1.50.x like #11830 was?

SpaceIm added a commit to SpaceIm/conan-center-index that referenced this pull request Aug 13, 2022
SpaceIm added a commit to SpaceIm/conan-center-index that referenced this pull request Aug 14, 2022
SpaceIm added a commit to SpaceIm/conan-center-index that referenced this pull request Aug 14, 2022
SpaceIm added a commit to SpaceIm/conan-center-index that referenced this pull request Aug 14, 2022
conan-center-bot pushed a commit to conan-io/conan-center-index that referenced this pull request Aug 23, 2022
* add test_v1_package

* some improvements:

- conan >=1.46.0 is required
- use GNUInstallDirs in custom CMakeLists
- isolate source code under src folder
- move custom cmake files under cmake folder instead of src folder
- install imports directly under bin folder instead of moving it after installation
- add VirtualBuildEnv since there are tool_requires
- reorder methos by order of execution

* add shared & fPIC options

* no need for CMAKE_SOURCE_DIR

* explicit cpp_info.requires

due to conan-io/conan#11789
fixed by conan-io/conan#11790

* remove shared option

* winflexbison for msvc only

* check compiler from build profile
conan-center-bot pushed a commit to conan-io/conan-center-index that referenced this pull request Aug 24, 2022
* conan v2 support

* explicit cpp_info.requires

due to conan-io/conan#11789
fixed by conan-io/conan#11790

* use self.info.clear() instead of self.info.header_only()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants