-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Bad legacy cpp_info if layout is used #11790
[bugfix] Bad legacy cpp_info if layout is used #11790
Conversation
@@ -30,7 +30,7 @@ def package_info(self): | |||
conan_json = client.load("conanbuildinfo.json") | |||
data = json.loads(conan_json) | |||
self.assertEqual(data["dependencies"][0]["version"], "0.1") | |||
self.assertIsNone(data["dependencies"][0]["description"]) | |||
self.assertEqual(data["dependencies"][0]["description"], "my desc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I'm missing something but we weren't saving the description before those changes.
# Let's avoid losing this information. | ||
conanfile.cpp_info.version = conanfile.version | ||
conanfile.cpp_info.description = conanfile.description | ||
conanfile.cpp_info.public_deps = public_deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was easier/cleaner than changing the CppInfo
class.
Is it possible to include this fix into |
due to conan-io/conan#11789 fixed in conan-io/conan#11790
due to conan-io/conan#11789 fixed by conan-io/conan#11790
due to conan-io/conan#11789 fixed by conan-io/conan#11790
due to conan-io/conan#11789 fixed by conan-io/conan#11790
* add test_v1_package * some improvements: - conan >=1.46.0 is required - use GNUInstallDirs in custom CMakeLists - isolate source code under src folder - move custom cmake files under cmake folder instead of src folder - install imports directly under bin folder instead of moving it after installation - add VirtualBuildEnv since there are tool_requires - reorder methos by order of execution * add shared & fPIC options * no need for CMAKE_SOURCE_DIR * explicit cpp_info.requires due to conan-io/conan#11789 fixed by conan-io/conan#11790 * remove shared option * winflexbison for msvc only * check compiler from build profile
* conan v2 support * explicit cpp_info.requires due to conan-io/conan#11789 fixed by conan-io/conan#11790 * use self.info.clear() instead of self.info.header_only()
due to conan-io/conan#11789 fixed by conan-io/conan#11790
Changelog: Bugfix: Legacy
cpp_info
for consumers was losing information in case of depending on a package with a layout.Docs: omit
Closes:
self.deps_cpp_info[dependency].version
is None inbuild()
of conan v1 test package in a conan v2 recipe #11784cmake_find_package_multi
if direct dependency recipe based on conan v2 and no components #11789