-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entt: improve support of conan v2 & add test_v1_package #12175
Conversation
This comment has been minimized.
This comment has been minimized.
what's wrong now? test_package works, but not test_v1_package EDIT: ok, I see. Waiting a conan version including conan-io/conan#11790, since CMakeLists of test_v1_package contains some logic based on entt version. |
This comment has been minimized.
This comment has been minimized.
All green in build 3 (
|
destination=self._source_subfolder, strip_root=True) | ||
destination=self.source_folder, strip_root=True) | ||
|
||
def build(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this method required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid displaying a warning, but not mandatory
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!