Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entt: improve support of conan v2 & add test_v1_package #12175

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 12, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 12, 2022

what's wrong now? test_package works, but not test_v1_package

EDIT: ok, I see. Waiting a conan version including conan-io/conan#11790, since CMakeLists of test_v1_package contains some logic based on entt version.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (f8bfb4206f4dda388f262bf95187bb91f76a9d76):

  • entt/3.10.3@:
    All packages built successfully! (All logs)

  • entt/3.8.1@:
    All packages built successfully! (All logs)

  • entt/3.10.1@:
    All packages built successfully! (All logs)

  • entt/3.9.0@:
    All packages built successfully! (All logs)

  • entt/3.6.0@:
    All packages built successfully! (All logs)

  • entt/3.10.0@:
    All packages built successfully! (All logs)

  • entt/3.8.0@:
    All packages built successfully! (All logs)

  • entt/3.5.1@:
    All packages built successfully! (All logs)

  • entt/3.5.2@:
    All packages built successfully! (All logs)

  • entt/3.7.0@:
    All packages built successfully! (All logs)

  • entt/3.3.0@:
    All packages built successfully! (All logs)

  • entt/3.7.1@:
    All packages built successfully! (All logs)

  • entt/3.3.2@:
    All packages built successfully! (All logs)

  • entt/3.4.0@:
    All packages built successfully! (All logs)

  • entt/3.3.1@:
    All packages built successfully! (All logs)

  • entt/3.2.2@:
    All packages built successfully! (All logs)

  • entt/3.5.0@:
    All packages built successfully! (All logs)

destination=self._source_subfolder, strip_root=True)
destination=self.source_folder, strip_root=True)

def build(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this method required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid displaying a warning, but not mandatory

@conan-center-bot conan-center-bot merged commit 0f76703 into conan-io:master Aug 26, 2022
@SpaceIm SpaceIm deleted the entt-conan-v2 branch August 26, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants