#12455 - ruby/3.1.0: expose more configuration options for native extension gems #12456

jmarrec · 2022-08-22T22:18:52Z

Specify library name and version: ruby/3.1.0

Fix [package] ruby/3.1.0: expose more configuration options for native extension gems #12455

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

due to conan-io/conan#11789 fixed by conan-io/conan#11790

jmarrec · 2022-08-22T22:19:30Z

recipes/ruby/all/test_package/test_package.cpp

+#ifdef RUBY_STATIC_RUBY
+  rb_provide("bigdecimal");
+  rb_provide("bigdecimal.so");
+#else
+  ruby_init_loadpath();
+#endif
+
+  rb_eval_string(R"(
+       begin
+         (require 'bigdecimal')
+         puts "I can correctly load one of the extension gems - bigdecimal"
+       rescue Exception => e
+         puts
+         puts "Error: #{e.message}"
+         puts "Backtrace:\n\t" + e.backtrace.join("\n\t")
+         raise
+       end
+     )");
+
+  ruby_finalize();


Extend testing to require one of the extension gems.

jmarrec · 2022-08-22T22:19:51Z

recipes/ruby/all/conanfile.py

+        "with_static_linked_ext": True,
+        "with_enable_load_relative": True,
+        "with_libyaml": True,
+        "with_libffi": True,
+        "with_readline": True,
+        'with_gmp': True,


New options

jmarrec · 2022-08-22T22:20:14Z

recipes/ruby/all/conanfile.py

+        if self.options.with_libyaml:
+            self.requires("libyaml/0.2.5")
+
+        if self.options.with_libffi:
+            self.requires("libffi/3.4.2")
+
+        if self.options.with_readline:
+            self.requires("readline/8.1.2")
+
+        if self.options.with_gmp:
+            self.requires("gmp/6.2.1")


Control dependencies

jmarrec · 2022-08-22T22:20:38Z

recipes/ruby/all/conanfile.py

@@ -77,8 +103,12 @@ def validate(self):
    def configure(self):
        if self.options.shared:
            del self.options.fPIC
+            del self.options.with_static_linked_ext


This only makes sense in the case of a static build to begin with

jmarrec · 2022-08-22T22:20:53Z

recipes/ruby/all/conanfile.py

+        if self.settings.os == 'Windows':
+            # readline isn't supported on Windows
+            self.options.with_readline = False


readline caveat on windows.

jmarrec · 2022-08-22T22:21:13Z

recipes/ruby/all/conanfile.py

+        if not self.options.shared and self.options.with_static_linked_ext:
+            tc.configure_args.append('--with-static-linked-ext')
+
+        if self.options.with_enable_load_relative:
+            tc.configure_args.append('--enable-load-relative')


Pass these two to ruby configure.

jmarrec · 2022-08-22T22:21:41Z

recipes/ruby/all/conanfile.py

+        for name, dep_cpp_info in self.deps_cpp_info.dependencies:
+            if name in ['zlib', 'openssl', 'libffi', 'libyaml', 'readline', 'gmp']:
+                root_path = tools.unix_path(dep_cpp_info.rootpath)
+                tc.configure_args.append(f'--with-{name}-dir={root_path}')


For dependencies, pass the --with-ext-dir flag to ensure ruby find the one from conan and not the system installed one.

jmarrec · 2022-08-22T22:21:56Z

recipes/ruby/all/conanfile.py

+        # install the enc/*.a / ext/*.a libraries
+        if not self.options.shared and self.options.with_static_linked_ext:
+            for dirname in ['ext', 'enc']:
+                dst = os.path.join('lib', dirname)
+                self.copy('*.a', dst=dst, src=dirname, keep_path=True)
+                self.copy('*.lib', dst=dst, src=dirname, keep_path=True)


Ship the potential static linked exts too.

jmarrec · 2022-08-22T22:22:26Z

recipes/ruby/all/conanfile.py

+        rubylib.requires.extend(["zlib::zlib"])
+        # TODO: if --with-static-linked-ext is passed, is this necessary?
+        if self.options.with_gmp:
+            rubylib.requires.append("gmp::gmp")
        if self.options.with_openssl:
            rubylib.requires.append("openssl::openssl")
+        if self.options.with_libyaml:
+            rubylib.requires.append("libyaml::libyaml")
+        if self.options.with_libffi:
+            rubylib.requires.append("libffi::libffi")
+        if self.options.with_readline:
+            rubylib.requires.append("readline::readline")


adjust the requires. I'm not sure about that TODO...

ghost · 2022-08-22T22:35:06Z

I detected other pull requests that are modifying ruby/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

github-actions · 2022-08-22T22:44:00Z

Hooks produced the following warnings for commit 5ba0022

ruby/3.1.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs.

github-actions · 2022-08-22T23:22:28Z

Hooks produced the following warnings for commit fd3fcd8

ruby/3.1.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs.

``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ```

jmarrec · 2022-08-22T23:32:45Z

Fun, two builds are throwing a segfault on linux...

compiling parser.c
compiling parserstate.c
during GIMPLE pass: unswitch
parserstate.c: In function â€˜parser_typevar_memberâ€™:
parserstate.c:73:6: internal compiler error: Segmentation fault
   73 | bool parser_typevar_member(parserstate *state, ID id) {
      |      ^~~~~~~~~~~~~~~~~~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions.

uilianries · 2022-08-23T08:32:06Z

@jmarrec Thank you for your contribution, really good to see all these new options. Please, take a look on v2 Linter result. Some conans.tools are now deprecated and should move toward to Conan v2 approach: https://github.com/conan-io/conan-center-index/blob/master/docs/v2_linter.md#import-tools-from-conan

Tell us if you need some help.

jmarrec · 2022-08-23T10:33:27Z

@uilianries I had ported locally to v2 but then I saw Eric's bot point to #12208 which already does it so I didn't push it, assuming I should wait for that one to merge first?

uilianries · 2022-08-23T10:38:19Z

@jmarrec If it works, please, go ahead, we can merge your PR first. I can adapt my PR later.

…more_options Resolve conflicts, merge manually

stale · 2023-01-02T09:12:47Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

@SpaceIm

…ve extension gems. Reboots conan-io#12456 and conan-io#12208 * conan v2 support (work done by myself + a merge of @SpaceIm 's branch from PR conan-io#12208 to reconcile both) * Extend testing to require one of the native extensions * ``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ``` * Use `--with-opt-dir` instead of `--with-xx-dir` that ruby isn't respecting. conanio/gccXX (eg 10) removed the libxxx-dev (eg libgmp-dev) from the image. This made me realize that the conan deps weren't being picked up by the build. The openssl was, because --with-openssl-dir is explicitly used in ruby config. So here, we rely on --with-opt-dir. cf: https://bugs.ruby-lang.org/issues/19014#change-99241 (--with-gmp-dir was added on September 14, 2022, wrote this in Sep 22, 2022) * Pass both --with-opt-dir and --with-xxx-dir https://gist.github.com/mrkn/6647630

SpaceIm and others added 4 commits August 14, 2022 15:53

conan v2 support

1cdfce4

explicit cpp_info.requires

b5308f0

due to conan-io/conan#11789 fixed by conan-io/conan#11790

fix indentation

1f18ea2

Extend testing to require one of the native extensions

da9e957

jmarrec commented Aug 22, 2022

View reviewed changes

ghost mentioned this pull request Aug 22, 2022

[service] Potentially conflicting recipes #3571

Closed

This was referenced Aug 22, 2022

[ruby] Use legacy tools to import is_apple_os #12341

Closed

ruby: conan v2 support #12208

Closed

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 22, 2022

conan-io#12455 - Add more options to ruby

fd3fcd8

jmarrec force-pushed the 12455_ruby_more_options branch from 5ba0022 to fd3fcd8 Compare August 22, 2022 23:10

conan-center-bot removed the Failed label Aug 22, 2022

github-actions bot mentioned this pull request Aug 22, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 22, 2022

Add util as a system lib to shush conan hook warning

ec2b1cf

``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/ruby/3.1.0/x86_64-linux/pty.so' links to system library 'util' but it is not in cpp_info.system_libs. ```

conan-center-bot removed the Failed label Aug 22, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 22, 2022

jmarrec added 3 commits August 23, 2022 14:11

Migrate to v2

3583256

Merge remote-tracking branch 'SpaceIm/ruby-conan-v2' into 12455_ruby_…

1ce2cd4

…more_options Resolve conflicts, merge manually

Fix test_package error after merge

56573c9

stale bot added the stale label Dec 3, 2022

stale bot closed this Jan 2, 2023

jmarrec added a commit to jmarrec/conan-center-index that referenced this pull request Jul 5, 2023

Reboot conan-io#12456

de43928

jmarrec mentioned this pull request Jul 5, 2023

Ruby: support conan v2 and expose more configuration options for native extension gems #18336

Closed

jmarrec mentioned this pull request Jul 5, 2023

Ruby: support conan v2 and expose more configuration options for native extension gems #18338

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#12455 - ruby/3.1.0: expose more configuration options for native extension gems #12456

#12455 - ruby/3.1.0: expose more configuration options for native extension gems #12456

jmarrec commented Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

jmarrec Aug 22, 2022

ghost commented Aug 22, 2022 •

edited by ghost

Loading

This comment has been minimized.

github-actions bot commented Aug 22, 2022

This comment has been minimized.

github-actions bot commented Aug 22, 2022

jmarrec commented Aug 22, 2022 •

edited

Loading

This comment has been minimized.

uilianries commented Aug 23, 2022 •

edited

Loading

jmarrec commented Aug 23, 2022

uilianries commented Aug 23, 2022

stale bot commented Jan 2, 2023

#12455 - ruby/3.1.0: expose more configuration options for native extension gems #12456

#12455 - ruby/3.1.0: expose more configuration options for native extension gems #12456

Conversation

jmarrec commented Aug 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Aug 22, 2022 • edited by ghost Loading

This comment has been minimized.

github-actions bot commented Aug 22, 2022

This comment has been minimized.

github-actions bot commented Aug 22, 2022

jmarrec commented Aug 22, 2022 • edited Loading

This comment has been minimized.

uilianries commented Aug 23, 2022 • edited Loading

jmarrec commented Aug 23, 2022

uilianries commented Aug 23, 2022

stale bot commented Jan 2, 2023

ghost commented Aug 22, 2022 •

edited by ghost

Loading

jmarrec commented Aug 22, 2022 •

edited

Loading

uilianries commented Aug 23, 2022 •

edited

Loading