Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv(4.x): disable quirc if dnn is disabled #13215

Closed
wants to merge 3 commits into from

Conversation

vvarma
Copy link
Contributor

@vvarma vvarma commented Sep 29, 2022

Specify library name and version: opencv/4.5.5
Currently, when opencv is used with the option dnn=False i get the following error.

 ConanException: opencv/4.5.5 package_info(): Package require 'quirc' not used in components requires

This goes away when i set with_quirc=False .

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Sep 29, 2022

I detected other pull requests that are modifying opencv/4.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@vvarma thank you for your contribution, could your please update libtiff dependency version from 4.3.0 to 4.4.0

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (9b5cbc811c4cc37a557d062656930fe9569bb0ac):

  • opencv/4.5.1@:
    Didn't run or was cancelled before finishing

  • opencv/4.5.0@:
    Didn't run or was cancelled before finishing

  • opencv/4.5.2@:
    CI failed to create some packages (All logs)

    Logs for packageID 0dbe095f19341cbc1e5e547a64510fa92cfe6f1d:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++
    compiler.version=5
    os=Linux
    [options]
    opencv:shared=False
    
    [...]
        libmp3lame/3.100:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        libpng/1.6.37:b4e19c2a9f411079edce0e39c7f8fa0db025a2ad - Download
        libsndfile/1.0.31:56a9bdc5dddc3e9b48d76a020f5ce181190a75be - Download
        libtiff/4.4.0:25d4ba369bc34caba66eddc142845b776b7018e0 - Missing
        libtool/2.4.7:337779b65706ec0830c80c875e0edf79c0b1c792 - Download
        libvpx/1.11.0:770077aaeef7295797b9833133ba2a7be8e32865 - Download
        libwebp/1.2.2:9914f4fbedcef15a1908dc721c310d135acd4987 - Download
        libx264/20191217:6ad5477442f8b835700b5367bb2b153ff457b6ff - Download
        libx265/3.4:070e9810504960be5a756c65f8f08b5456dc665e - Download
        libxml2/2.9.14:13c49745b25725ed9cfa2d6c055b02c0efebe225 - Download
        m4/1.4.19:24647d9fe8ec489125dfbae4b3ebefaf7581674c - Download
        ogg/1.3.5:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        opencv/4.5.2:0dbe095f19341cbc1e5e547a64510fa92cfe6f1d - Build
        openexr/2.5.7:72c9a711fd39124ddedc02d36c66e2782b50f02a - Download
        openh264/2.1.1:b759e10106fc0b4923414b05bb78eba0bbc8b30b - Download
        openjpeg/2.5.0:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        openssl/1.1.1q:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        opus/1.3.1:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        protobuf/3.17.1:0efaae3060b15d8e9634d68dffca6eb9720b21ce - Download
        pulseaudio/14.2:6eef99b0a69234ea1a871a04f3a75e3e4f915dde - Download
        quirc/1.1:bdad93b129fab5dad3e12123918e108387ae010f - Download
        vaapi/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        vdpau/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        vorbis/1.3.7:064ea010e699a135f9361dad5512e737f28a64f6 - Download
        vulkan-headers/1.3.221:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        vulkan-loader/1.3.221:5029db28d7aa5dc709460f0c7f3fa553067b4cf3 - Download
        wayland/1.20.0:6f50b88f73c8f1a539385cd0520909f2d0600bef - Download
        xorg/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        xz_utils/5.2.5:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        zlib/1.2.12:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
        zstd/1.5.2:ff7e1eda45846fc95249ac3e0c50da0e296272b3 - Download
    
    Installing (downloading, building) binaries...
    
    WARN: libtiff/4.4.0: requirement libjpeg/9e overridden by opencv/4.5.2 to libjpeg/9d 
    WARN: libtiff/4.4.0: requirement libwebp/1.2.4 overridden by opencv/4.5.2 to libwebp/1.2.2 
    WARN: ffmpeg/4.4: requirement libwebp/1.2.3 overridden by opencv/4.5.2 to libwebp/1.2.2 
    ERROR: Missing binary: libtiff/4.4.0:25d4ba369bc34caba66eddc142845b776b7018e0
    libtiff/4.4.0: WARN: Can't find a 'libtiff/4.4.0' package for the specified settings, options and dependencies:
    - Settings: arch=x86_64, build_type=Release, compiler=gcc, compiler.libcxx=libstdc++, compiler.version=5, os=Linux
    - Options: cxx=True, fPIC=True, jbig=True, jpeg=libjpeg, libdeflate=True, lzma=True, shared=False, webp=True, zlib=True, zstd=True, jbig:build_executables=True, jbig:fPIC=True, jbig:shared=False, libdeflate:fPIC=True, libdeflate:shared=False, libjpeg:fPIC=True, libjpeg:shared=False, libwebp:fPIC=True, libwebp:near_lossless=True, libwebp:shared=False, libwebp:swap_16bit_csp=False, libwebp:with_simd=True, xz_utils:fPIC=True, xz_utils:shared=False, zlib:fPIC=True, zlib:shared=False, zstd:fPIC=True, zstd:shared=False, zstd:threading=True
    - Dependencies: zlib/1.2.12, libdeflate/1.12, xz_utils/5.2.5, libjpeg/9d, jbig/20160605, zstd/1.5.2, libwebp/1.2.2
    - Requirements: jbig/20160605.Y.Z, libdeflate/1.Y.Z, libjpeg/9d, libwebp/1.Y.Z, xz_utils/5.Y.Z, zlib/1.Y.Z, zstd/1.Y.Z
    - Package ID: 25d4ba369bc34caba66eddc142845b776b7018e0
    
    ERROR: Missing prebuilt package for 'libtiff/4.4.0'
    Use 'conan search libtiff/4.4.0 --table=table.html -r=remote' and open the table.html file to see available packages
    Or try to build locally from sources with '--build=libtiff'
    
    More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'
    
  • opencv/4.5.3@:
    Didn't run or was cancelled before finishing

  • opencv/4.5.5@:
    Didn't run or was cancelled before finishing

  • opencv/4.1.2@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The follow requirements should be updated in the recipe to pass on CI:

  • libjpeg/9e
  • libjpeg-turbo/2.1.4
  • openjpeg/2.5.0
  • libpng/1.6.38
  • openexr/3.1.5
  • eigen/3.4.0
  • ffmpeg/5.0
  • onetbb/2021.3.0
  • libwebp/1.2.4
  • freetype/2.12.1
  • harfbuzz/5.2.0
  • glog/0.6.0
  • ade/0.1.2a

In case of failure, you can revert that specific version, but we need to try to keep the latest version available. Otherwise, we can have version conflicts, like we are having now.

@ghost ghost mentioned this pull request Oct 10, 2022
4 tasks
@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 10, 2022

I think this PR introduces an error to solve an error coming from #11009.
objdetect can be built without dnn. Since quirc is the dependency of only one component, objdetect, #11009 has led to this issue.
So instead of enforcing this bad state, a PR should bring back objdetect component regardless of options, and addresses the root cause of #10997

@stale
Copy link

stale bot commented Nov 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 25, 2022
@stale
Copy link

stale bot commented Dec 26, 2022

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants