-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencv: Fix dependency structure #15255
Conversation
The `opencv_objdetect` library is build even with `dnn` disabled.
I detected other pull requests that are modifying opencv/4.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
It's not true in OpenCV 4.5.4 & 4.5.5 without a patch. I already fix this issue in #15193 |
Conan v1 pipelineAll green in build 1 (
|
Hooks produced the following warnings for commit 40ab4c9opencv/4.5.1
opencv/4.5.0
opencv/4.5.2
opencv/4.5.5
opencv/4.1.2
opencv/4.5.3
|
@SpaceIm could you be so kind as to provide a reference ? Or some more details please? It's much nicer to open with a question rather then "your wrong" and worst not providing a helpful educational explanation. Please try to help other contributors rather then correcting them. |
There are already all the detailed explanation in #15193 where I've spent lot of time to fix this issue and others:
|
Hi, I didn't know about the other PR (just saw it now after the post of the bot) After a quick look @SpaceIm seems to be totally right and his PR is a lot more important than this small fix that only works for almost all versions 😃 . As the CI system seems not to test all possible combinations of options, the green build here might be a false positive. I'll close this pull request here and keep fingers crossed that @SpaceIm will finish his one soon! |
Either way, thanks a lot for taking the time to contribute to conan center index, even if the PR ended up closing, we really appreciate your effort :) |
The
opencv_objdetect
library is build even withdnn
disabled.Specify library name and version: opencv/4.5.1