Folly/2022.10.03 #13290

Kidsunbo · 2022-10-04T03:22:18Z

Specify library name and version: Folly/2022.10.03

Update folly to 2022.10.03 and add one patch

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

closes #12988

CLAassistant · 2022-10-04T03:22:23Z

All committers have signed the CLA.

…-index

uilianries · 2022-10-04T16:24:49Z

@Kidsunbo Thank you for your contribution, please, don't forget to sign our CLA on #13290 (comment). The CI bot does not allow to merge PRs which are not signed.

prince-chrismc · 2022-10-05T18:44:22Z

Can you please link #12988? https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword 🙏

prince-chrismc

Since the patch is to provide conan deps you should also change the mode, the upstream projects all provide CONFIG files, modules are a different and I dont think any of these are on

https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules

recipes/folly/all/patches/0023-find-packages.patch

Kidsunbo · 2022-10-06T04:57:35Z

Can you please link #12988? https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword 🙏

Already done, thanks.

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Kidsunbo · 2022-10-06T06:01:42Z

Since the patch is to provide conan deps you should also change the mode, the upstream projects all provide CONFIG files, modules are a different and I dont think any of these are on

https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html#find-modules

I don't know why but when I accept the change from MODULE to CONFIG, it fails to finish the CMake configuration on my machine. So I remove the keyword and make it use whatever it can use.

uilianries · 2022-10-06T09:10:19Z

@Kidsunbo Need to check which generator is being used. The cmake_find_package generates only Findxxx.cmake files, and cmake_find_package_multi generates xxx-config.cmake.

prince-chrismc · 2022-10-06T18:26:36Z

Thats a really interesting point, it might have a cascade problem with the other version 🤔
I would play it safe and not change the generators lets just try adding the version before we play with it too much... with the new generators the behavior will change too 😱

dubvulture · 2022-10-06T22:18:12Z

Why the upgrade to glog/0.6.0 and fmt/9.1.0?
The folly manifest files report 0.5.0 and 8.0.1, if I interpreted them correctly.

uilianries · 2022-10-07T07:46:31Z

@dubvulture We try to avoid dependencies conflicts. If folly only work with those versions, it's fine keep them, otherwise, update them.

Kidsunbo · 2022-10-07T10:30:57Z

@Kidsunbo Need to check which generator is being used. The cmake_find_package generates only Findxxx.cmake files, and cmake_find_package_multi generates xxx-config.cmake.

The generators seems to be cmake and cmake_find_package. So I think the Module mode should be used.

prince-chrismc

Can you please fix this, linter is flagging some bad code should be is_msvc(self) https://github.com/conan-io/conan-center-index/pull/13290/files#diff-c76b59bc54e55f5a4d20622555a9653f5345015c0c85716862cdab5139eb4dc6R162

it's line 162

otherwise it's a green check!

prince-chrismc · 2022-10-12T16:58:39Z

I think its more important to get the version in then worry about changing the recipes. this is a piecemeal one

prince-chrismc · 2022-10-12T16:59:24Z

The PR to add you is in the queue, I am not sure why it's stuck again but I asked the infra team for help 🤞 it shouldn't be long

uilianries

Linter fix.

recipes/folly/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2022-10-17T14:55:33Z

Failure in build 11 (7eab4c09cebeed7aa8abd6af6462ee4aca9df15c):

folly/2019.10.21.00@:
Error running command conan export recipes/folly/all/conanfile.py folly/2019.10.21.00@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 45.0849609375 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NOT ALLOWED ATTRIBUTES (KB-H039)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS RENAME (KB-H057)] OK
[HOOK - conan-center.py] pre_export(): [ILLEGAL CHARACTERS (KB-H058)] OK
[HOOK - conan-center.py] pre_export(): [CLASS NAME (KB-H059)] OK
[HOOK - conan-center.py] pre_export(): [NO CRLF (KB-H060)] OK
[HOOK - conan-center.py] pre_export(): [NO BUILD SYSTEM FUNCTIONS (KB-H061)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS CROSS BUILDING (KB-H062)] OK
[HOOK - conan-center.py] pre_export(): [INVALID TOPICS (KB-H064)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRED_CONAN_VERSION (KB-H065)] OK
[HOOK - conan-center.py] pre_export(): [TEST_TYPE MANAGEMENT (KB-H068)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO DEFAULT OPTIONS (KB-H069)] OK
[HOOK - conan-center.py] pre_export(): [MANDATORY SETTINGS (KB-H070)] OK
[HOOK - conan-center.py] pre_export(): [TEST V1 PACKAGE FOLDER (KB-H073)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [PYLINT EXECUTION (KB-H072)] Pylint can not be skipped, remove '#pylint' line from '/home/conan/w/prod_cci_PR-13290/recipes/folly/all/./test_v1_package/conanfile.py' (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H072) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

folly/2020.08.10.00@:
Error running command conan export recipes/folly/all/conanfile.py folly/2020.08.10.00@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 45.0849609375 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NOT ALLOWED ATTRIBUTES (KB-H039)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS RENAME (KB-H057)] OK
[HOOK - conan-center.py] pre_export(): [ILLEGAL CHARACTERS (KB-H058)] OK
[HOOK - conan-center.py] pre_export(): [CLASS NAME (KB-H059)] OK
[HOOK - conan-center.py] pre_export(): [NO CRLF (KB-H060)] OK
[HOOK - conan-center.py] pre_export(): [NO BUILD SYSTEM FUNCTIONS (KB-H061)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS CROSS BUILDING (KB-H062)] OK
[HOOK - conan-center.py] pre_export(): [INVALID TOPICS (KB-H064)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRED_CONAN_VERSION (KB-H065)] OK
[HOOK - conan-center.py] pre_export(): [TEST_TYPE MANAGEMENT (KB-H068)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO DEFAULT OPTIONS (KB-H069)] OK
[HOOK - conan-center.py] pre_export(): [MANDATORY SETTINGS (KB-H070)] OK
[HOOK - conan-center.py] pre_export(): [TEST V1 PACKAGE FOLDER (KB-H073)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [PYLINT EXECUTION (KB-H072)] Pylint can not be skipped, remove '#pylint' line from '/home/conan/w/prod_cci_PR-13290/recipes/folly/all/./test_v1_package/conanfile.py' (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H072) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

folly/2022.01.31.00@:
Error running command conan export recipes/folly/all/conanfile.py folly/2022.01.31.00@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 45.0849609375 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NOT ALLOWED ATTRIBUTES (KB-H039)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS RENAME (KB-H057)] OK
[HOOK - conan-center.py] pre_export(): [ILLEGAL CHARACTERS (KB-H058)] OK
[HOOK - conan-center.py] pre_export(): [CLASS NAME (KB-H059)] OK
[HOOK - conan-center.py] pre_export(): [NO CRLF (KB-H060)] OK
[HOOK - conan-center.py] pre_export(): [NO BUILD SYSTEM FUNCTIONS (KB-H061)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS CROSS BUILDING (KB-H062)] OK
[HOOK - conan-center.py] pre_export(): [INVALID TOPICS (KB-H064)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRED_CONAN_VERSION (KB-H065)] OK
[HOOK - conan-center.py] pre_export(): [TEST_TYPE MANAGEMENT (KB-H068)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO DEFAULT OPTIONS (KB-H069)] OK
[HOOK - conan-center.py] pre_export(): [MANDATORY SETTINGS (KB-H070)] OK
[HOOK - conan-center.py] pre_export(): [TEST V1 PACKAGE FOLDER (KB-H073)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [PYLINT EXECUTION (KB-H072)] Pylint can not be skipped, remove '#pylint' line from '/home/conan/w/prod_cci_PR-13290/recipes/folly/all/./test_v1_package/conanfile.py' (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H072) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

folly/2022.10.03.00@:
Error running command conan export recipes/folly/all/conanfile.py folly/2022.10.03.00@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 45.0849609375 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NOT ALLOWED ATTRIBUTES (KB-H039)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS RENAME (KB-H057)] OK
[HOOK - conan-center.py] pre_export(): [ILLEGAL CHARACTERS (KB-H058)] OK
[HOOK - conan-center.py] pre_export(): [CLASS NAME (KB-H059)] OK
[HOOK - conan-center.py] pre_export(): [NO CRLF (KB-H060)] OK
[HOOK - conan-center.py] pre_export(): [NO BUILD SYSTEM FUNCTIONS (KB-H061)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS CROSS BUILDING (KB-H062)] OK
[HOOK - conan-center.py] pre_export(): [INVALID TOPICS (KB-H064)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRED_CONAN_VERSION (KB-H065)] OK
[HOOK - conan-center.py] pre_export(): [TEST_TYPE MANAGEMENT (KB-H068)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO DEFAULT OPTIONS (KB-H069)] OK
[HOOK - conan-center.py] pre_export(): [MANDATORY SETTINGS (KB-H070)] OK
[HOOK - conan-center.py] pre_export(): [TEST V1 PACKAGE FOLDER (KB-H073)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [PYLINT EXECUTION (KB-H072)] Pylint can not be skipped, remove '#pylint' line from '/home/conan/w/prod_cci_PR-13290/recipes/folly/all/./test_v1_package/conanfile.py' (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H072) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

ghost · 2022-10-20T09:52:53Z

I detected other pull requests that are modifying folly/all recipe:

folly: bumpup version & conan v2 support #13757

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

kexianda · 2022-10-20T13:12:14Z

@uilianries @prince-chrismc

It is a bit annoying to create patch files.
In this case, 0023-find-packages.patch very similar with 0016-find-packages.patch.
Most of them are just string replacement.
I am wondering whether it is OK to provide an other regex expression api like this?

def build(self):
      # ...
       if Version(self.version) >= "2022.01010.03"
            re = ['s/DoubleConversion/double-conversion/g', 's/Gflags/gflags/g', ....]
            tools.patch_regex(fp='CMake/folly-deps.cmake'  re)
        cmake = self._configure_cmake()
        cmake.build()

prince-chrismc · 2022-10-20T14:54:00Z

https://github.com/conan-io/conan-center-index/blob/master/docs/policy_patching.md#patches-format-and-conventions

Yes it's allowed - but they can have unintended side effects which are difficult to review.

It's very easy to make patches with the codespaces from github, you just right click export diff, if you are interested in other solutions.

kexianda · 2022-10-21T02:26:57Z

https://github.com/conan-io/conan-center-index/blob/master/docs/policy_patching.md#patches-format-and-conventions

Thank you for your reply.

stale · 2022-11-25T03:51:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

michaelaeriksen · 2022-12-22T15:49:23Z

Any plans to wrap this up? Seems like a waste of good work not to finish this port.

Kidsunbo · 2022-12-22T17:06:12Z

Any plans to wrap this up? Seems like a waste of good work not to finish this port.

There is a PR to bump up folly to a newer version than this one. So I think we should wait that PR to be merged.

stale · 2023-01-21T20:37:50Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-02-21T04:51:29Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Kidsunbo and others added 2 commits October 4, 2022 03:20

[ADD] add patch

2cf741a

Merge branch 'conan-io:master' into master

c3c623d

This comment has been minimized.

Sign in to view

conan-center-bot added the User-approval pending label Oct 4, 2022

Kidsunbo added 2 commits October 4, 2022 03:26

[ADD] add new line at the end of conandata.yml

9099e7c

Merge branch 'master' of https://github.com/KidContainer/conan-center…

beba30d

…-index

This comment has been minimized.

Sign in to view

Kidsunbo mentioned this pull request Oct 4, 2022

[!!] Access request #4

Closed

github-actions bot mentioned this pull request Oct 4, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc reviewed Oct 5, 2022

View reviewed changes

recipes/folly/all/patches/0023-find-packages.patch Outdated Show resolved Hide resolved

recipes/folly/all/patches/0023-find-packages.patch Outdated Show resolved Hide resolved

Kidsunbo mentioned this pull request Oct 6, 2022

[request] Folly/v2022.09.12.00 #12988

Open

Kidsunbo requested a review from prince-chrismc October 6, 2022 04:51

This comment has been minimized.

Sign in to view

Kidsunbo and others added 2 commits October 6, 2022 13:01

Apply suggestions from code review

381f03c

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Apply suggestions from code review

e90d908

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

This comment has been minimized.

Sign in to view

[REMOVE] remove Mode in find_package

63096a6

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Oct 11, 2022

View reviewed changes

uilianries reviewed Oct 14, 2022

View reviewed changes

recipes/folly/all/conanfile.py Outdated Show resolved Hide resolved

Kidsunbo dismissed prince-chrismc’s stale review via 377030f October 14, 2022 08:06

Apply suggestions from code review

377030f

Co-authored-by: Uilian Ries <uilianries@gmail.com>

This comment has been minimized.

Sign in to view

prince-chrismc previously approved these changes Oct 14, 2022

View reviewed changes

conan-center-bot added Failed and removed User-approval pending labels Oct 17, 2022

This comment has been minimized.

Sign in to view

Update config.yml

7eab4c0

Kidsunbo dismissed prince-chrismc’s stale review via 7eab4c0 October 17, 2022 14:52

This was referenced Oct 20, 2022

[service] Potentially conflicting recipes #3571

Closed

refine Folly recipe #13621

Merged

ghost mentioned this pull request Oct 26, 2022

folly: bumpup version & conan v2 support #13757

Closed

4 tasks

stale bot added the stale label Nov 25, 2022

stale bot removed the stale label Dec 22, 2022

stale bot added the stale label Jan 21, 2023

ghost mentioned this pull request Feb 4, 2023

folly: modernization followup #15726

Closed

3 tasks

stale bot closed this Feb 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Folly/2022.10.03 #13290

Folly/2022.10.03 #13290

Kidsunbo commented Oct 4, 2022 •

edited

Loading

CLAassistant commented Oct 4, 2022 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

uilianries commented Oct 4, 2022

prince-chrismc commented Oct 5, 2022

prince-chrismc left a comment

This comment has been minimized.

Kidsunbo commented Oct 6, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Kidsunbo commented Oct 6, 2022

uilianries commented Oct 6, 2022

prince-chrismc commented Oct 6, 2022

dubvulture commented Oct 6, 2022

uilianries commented Oct 7, 2022

Kidsunbo commented Oct 7, 2022

prince-chrismc left a comment

prince-chrismc commented Oct 12, 2022

prince-chrismc commented Oct 12, 2022

uilianries left a comment

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Oct 17, 2022

ghost commented Oct 20, 2022 •

edited by ghost

Loading

kexianda commented Oct 20, 2022

prince-chrismc commented Oct 20, 2022

kexianda commented Oct 21, 2022

stale bot commented Nov 25, 2022

michaelaeriksen commented Dec 22, 2022

Kidsunbo commented Dec 22, 2022

stale bot commented Jan 21, 2023

stale bot commented Feb 21, 2023

Folly/2022.10.03 #13290

Folly/2022.10.03 #13290

Conversation

Kidsunbo commented Oct 4, 2022 • edited Loading

CLAassistant commented Oct 4, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

uilianries commented Oct 4, 2022

prince-chrismc commented Oct 5, 2022

prince-chrismc left a comment

Choose a reason for hiding this comment

This comment has been minimized.

Kidsunbo commented Oct 6, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Kidsunbo commented Oct 6, 2022

uilianries commented Oct 6, 2022

prince-chrismc commented Oct 6, 2022

dubvulture commented Oct 6, 2022

uilianries commented Oct 7, 2022

Kidsunbo commented Oct 7, 2022

prince-chrismc left a comment

Choose a reason for hiding this comment

prince-chrismc commented Oct 12, 2022

prince-chrismc commented Oct 12, 2022

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Oct 17, 2022

ghost commented Oct 20, 2022 • edited by ghost Loading

kexianda commented Oct 20, 2022

prince-chrismc commented Oct 20, 2022

kexianda commented Oct 21, 2022

stale bot commented Nov 25, 2022

michaelaeriksen commented Dec 22, 2022

Kidsunbo commented Dec 22, 2022

stale bot commented Jan 21, 2023

stale bot commented Feb 21, 2023

Kidsunbo commented Oct 4, 2022 •

edited

Loading

CLAassistant commented Oct 4, 2022 •

edited

Loading

ghost commented Oct 20, 2022 •

edited by ghost

Loading