refine Folly recipe #13621

kexianda · 2022-10-20T03:58:15Z

folly

refine folly recipe

1. add sse42 option
some libraries depends on folly, but with simd enabled. It will causes
compiling error if folly has no such option.

2. folly project exports cmake file with components, such as folly::follybenchmark.
To keep consistent with folly's project, add components info

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2022-10-20T03:58:21Z

All committers have signed the CLA.

1. add sse42 option projects with simd enabled can not not be linked with folly since sse is not enabled currently. 2. Keep consistent with folly's cmake files. folly itself export components such as follybenchmark the cmake script uses target_link_libraries(xxlib Folly::follybenchmark) works if using manually install folly. but will fail if uses conan's recipe.

ghost · 2022-10-20T09:52:51Z

I detected other pull requests that are modifying folly/all recipe:

Folly/2022.10.03 #13290

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

uilianries · 2022-10-20T11:10:46Z

recipes/folly/all/conanfile.py

@@ -144,6 +150,9 @@ def source(self):
    def _configure_cmake(self):
        cmake = CMake(self)
        if can_run(self):
+            if self.options.with_sse4_2:


Since when is it available? Is it backward compatible?

sse4.2 support was in folly long long ago (>7 years)
I will set option default to False to be backward compatible.

uilianries · 2022-10-20T11:12:27Z

recipes/folly/all/conanfile.py

    }
    default_options = {
        "shared": False,
        "fPIC": True,
+        "with_sse4_2" : True


Suggested change

"with_sse4_2" : True

"use_sse4_2" : True

with is not a good prefix, as it's not a dependency. Prefer use instead: https://github.com/conan-io/conan-center-index/blob/master/docs/packaging_policy.md#recommended-feature-options-names

thanks. fixed.

uilianries · 2022-10-20T11:13:50Z

recipes/folly/all/conanfile.py

+            self.cpp_info.components["folly_test_util"].libs = ["folly_test_util"]
+            self.cpp_info.components["folly_test_util"].requires = ["libfolly"]
+
+            if Version(self.version) >= "2020.08.10.00" and self.settings.os == "Linux":


Bad indentation?

not bad indentation.

it is OK to adjust the indentation..

uilianries · 2022-10-20T12:56:41Z

recipes/folly/all/conanfile.py

@@ -144,6 +151,9 @@ def source(self):
    def _configure_cmake(self):
        cmake = CMake(self)
        if can_run(self):
+            if self.options.use_sse4_2 and str(self.settings.arch) in ['x86', 'x86_64']:


Suggested change

if self.options.use_sse4_2 and str(self.settings.arch) in ['x86', 'x86_64']:

if self.options.get_safe("use_sse4_2"):

Let's say we are using ARM arch here. The option use_sse4_2 will not be available and will break conan create command. Checking the arch should be done in validate() method, like:

def validate(self): if self.options.get_safe("use_sse4_2") and str(self.settings.arch) not in ['x86', 'x86_64']: raise ConanInvalidConfiguration(f"{self.ref} can use the option use_sse4_2 only on x86 and x86_64 archs.")

Thanks. fixed.

kexianda · 2022-10-21T02:34:21Z

@uilianries
"continuous-integration/jenkins/pr-merge — This commit cannot be built" [Details]
I've built it sucessfully on my linux desktop. I want to know how it failed, I clicked the 'Details', but got "403 Forbidden"
How to get detailed error information? Thanks in advance.

uilianries · 2022-10-21T13:51:47Z

@kexianda The CI result says: #13621 (comment)

Please, remove the line /test_v1_package/conanfile.py:# pylint: skip-file

prince-chrismc · 2022-10-24T02:10:09Z

recipes/folly/all/conanfile.py

@@ -103,7 +110,7 @@ def validate(self):
                raise ConanInvalidConfiguration("{} requires C++{} support. The current compiler {} {} does not support it.".format(
                    self.name, self._minimum_cpp_standard, self.settings.compiler, self.settings.compiler.version))

-        if self.version < "2022.01.31.00" and self.settings.os != "Linux":
+        if Version(self.version) < "2022.01.31.00" and self.settings.os != "Linux":
            raise ConanInvalidConfiguration("Conan support for non-Linux platforms starts with Folly version 2022.01.31.00")

        if self.settings.os == "Macos" and self.settings.arch != "x86_64":


Can this finally be updated?

Can this finally be updated?
thanks. fixed now

prince-chrismc

The new targets are not exported by the project (usually when it changes over versions we just do latest) but some more work is needed if you want this available in older versions

prince-chrismc · 2022-10-24T02:13:41Z

recipes/folly/all/conanfile.py

@@ -254,3 +268,30 @@ def package_info(self):
        self.cpp_info.components["libfolly"].names["cmake_find_package_multi"] = "folly"
        self.cpp_info.components["libfolly"].set_property("cmake_target_name", "Folly::folly")
        self.cpp_info.components["libfolly"].set_property("pkg_config_name", "libfolly")
+
+        if Version(self.version) >= "2019.10.21.00":
+            self.cpp_info.components["follybenchmark"].set_property("cmake_target_name", "Folly::follybenchmark")


Where does this come from 🤔 looking at the latest it's not there https://github.com/facebook/folly/search?q=follybenchmark

🤢

https://github.com/facebook/folly/blob/8874256376d2f8a32867f17c9472a446d6707604/folly/CMakeLists.txt#L22

at some point this needs to be removed

Where does this come from 🤔 looking at the latest it's not there https://github.com/facebook/folly/search?q=follybenchmark

🤢

https://github.com/facebook/folly/blob/8874256376d2f8a32867f17c9472a446d6707604/folly/CMakeLists.txt#L22

at some point this needs to be removed

hi @prince-chrismc
follybenchmark target is still there : https://github.com/facebook/folly/blob/main/folly/CMakeLists.txt#L23

I clearly did not drink enough coffee.

Perfect thank you for pointign that out!

conan-center-bot · 2022-10-24T13:34:36Z

All green in build 10 (4fa53b8f7e18e780c761f31ca13f0eeac86a71ca):

folly/2022.01.31.00@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py", line 6, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

folly/2020.08.10.00@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py", line 6, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

folly/2019.10.21.00@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-13621/recipes/folly/all/conanfile.py", line 6, in <module>
    from conans import CMake, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

conan-center-bot added the Failed label Oct 20, 2022