Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine Folly recipe #13621

Merged
merged 6 commits into from
Oct 24, 2022
Merged

refine Folly recipe #13621

merged 6 commits into from
Oct 24, 2022

Commits on Oct 20, 2022

  1. refine folly recipe 

    1. add sse42 option
projects with simd enabled can not not be linked with folly since sse is not
enabled currently.

2. Keep consistent with folly's cmake files.
folly itself export components such as follybenchmark
the cmake script uses target_link_libraries(xxlib Folly::follybenchmark)
works if using manually install folly. but will fail if uses conan's
recipe.
    @kexianda
    kexianda committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    701b479 View commit details
    Browse the repository at this point in the history

  2. address code review comments

    @kexianda
    kexianda committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3c3d317 View commit details
    Browse the repository at this point in the history

  3. address codereview comments

    @kexianda
    kexianda committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9726759 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. minor fix

    @kexianda
    kexianda committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    bb368d0 View commit details
    Browse the repository at this point in the history

  2. fix lylint error

    @kexianda
    kexianda committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    4f0b470 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. fix. folly also needs -mfma flag when simd >= sse4.2

    @kexianda
    kexianda committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4fa53b8 View commit details
    Browse the repository at this point in the history