Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog: provide at least one RREV with conan v2 support for "unmaintained versions" #14458

Closed

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 28, 2022

This recipe has been migrated to conan v2 in #11981, but this PR has also removed many spdlog versions so their latest RREV is stuck to conan v1 style. I think each version in conan-center should have at least one conan v2 RREV, it was too brutal to remove so many versions.
Another PR can remove these versions afterwards, but at least each of them will have a future proof RREV.
Some rational: #14459


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Failure in build 2 (a9ef3498bffcfdf4fbf4f74b7bd63838bf94fe18):

  • spdlog/1.9.1@:
    Didn't run or was cancelled before finishing

  • spdlog/1.9.0@:
    Didn't run or was cancelled before finishing

  • spdlog/1.8.1@:
    Didn't run or was cancelled before finishing

  • spdlog/1.8.2@:
    CI failed to create some packages (All logs)

    Logs for packageID c7e1b1004c948250b7562beecd9031d66e8b92a7:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=8
    os=Linux
    [options]
    spdlog:header_only=False
    spdlog:shared=False
    
    [...]
    spdlog/1.8.2: Aggregating env generators
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    spdlog/1.8.2: Calling build()
    spdlog/1.8.2: CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/package/c7e1b1004c948250b7562beecd9031d66e8b92a7" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/src"
    
    ----Running------
    > cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/package/c7e1b1004c948250b7562beecd9031d66e8b92a7" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/src"
    -----------------
    -- Using Conan toolchain: /home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/generators/conan_toolchain.cmake
    -- Conan toolchain: Setting CMAKE_POSITION_INDEPENDENT_CODE=ON (options.fPIC)
    -- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
    -- The CXX compiler identification is GNU 8.4.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/g++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Build spdlog: 1.8.2
    -- Looking for C++ include pthread.h
    -- Looking for C++ include pthread.h - found
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE  
    -- Build type: Release
    -- Configuring incomplete, errors occurred!
    See also "/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/Release/CMakeFiles/CMakeOutput.log".
    See also "/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/Release/CMakeFiles/CMakeError.log".
    spdlog/1.8.2: 
    CMake Error at CMakeLists.txt:174 (find_package):
      Could not find a configuration file for package "fmt" that is compatible
      with requested version "5.3.0".
    
      The following configuration files were considered but not accepted:
    
        /home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/generators/fmt-config.cmake, version: 7.1.3
    
    
    
    spdlog/1.8.2: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    spdlog/1.8.2: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    spdlog/1.8.2: ERROR: Package 'c7e1b1004c948250b7562beecd9031d66e8b92a7' build failed
    spdlog/1.8.2: WARN: Build folder /home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/Release
    ERROR: spdlog/1.8.2: Error in build() method, line 115
    	cmake.configure()
    	ConanException: Error 1 while executing cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/build/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/package/c7e1b1004c948250b7562beecd9031d66e8b92a7" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod/BuildSingleReference/.conan/data/spdlog/1.8.2/_/_/build/c7e1b1004c948250b7562beecd9031d66e8b92a7/src"
    
  • spdlog/1.6.0@:
    Didn't run or was cancelled before finishing

  • spdlog/1.8.0@:
    Didn't run or was cancelled before finishing

  • spdlog/1.7.0@:
    Didn't run or was cancelled before finishing

  • spdlog/1.6.1@:
    Didn't run or was cancelled before finishing

  • spdlog/1.5.0@:
    Didn't run or was cancelled before finishing

  • spdlog/1.4.2@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@prince-chrismc
Copy link
Contributor

Not worth the effort unless someone needs a specific version.

@ghost
Copy link

ghost commented Dec 7, 2022

I detected other pull requests that are modifying spdlog/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm closed this Dec 30, 2022
@SpaceIm SpaceIm deleted the spdlog-conan-v2-unmaintained-versions branch December 30, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump version PR bumping version without recipe modifications Failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants