spdlog: update usage of self.info in package id
#14634
Conversation
This comment has been minimized.
This comment has been minimized.
|
I detected other pull requests that are modifying spdlog/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This is ready for review :) |
| @@ -152,8 +147,7 @@ def package_info(self): | |||
| if self.options.header_only and self.settings.os in ("iOS", "tvOS", "watchOS"): | |||
| self.cpp_info.components["libspdlog"].defines.append("SPDLOG_NO_TLS") | |||
|
|
|||
| if Version(conan_version).major < 2: | |||
There was a problem hiding this comment.
OOC: why was this remove? I'd really love to not see warnings in Conan 2.0 and was actually going to suggest adding something like this into recipes.
There was a problem hiding this comment.
It's a fair point, There's a handful of factors...
- We are trying to test the migration so we want the same code to work in both (trying to avoid version checks to make sure we got all the migration points covered)
- We'd need to add this into ~1500 recipes 🙃 It's just not practical.
- Our expectations is once 2.0 is out and stabilized we can start to remove these from recipes. It hard to say when but we'd like to do it within 4-6 months at the most.
I agree the warning is noise, some recipes are getting like 40 of them 🤢 best case 2.0 is bug free and we start deleting them right away 🚀 😆
There was a problem hiding this comment.
Now that 2.0 runs are submitted as part of the report from CCI, I think that noise is good in this case, as you say, we want to catch as many bugs as possible before GA!
Conan v1 pipelineAll green in build 4 ( |
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!