-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISL Conan 2.0 compatibility #14916
ISL Conan 2.0 compatibility #14916
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 29 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 27 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
if is_msvc(self): | ||
compiler_version = self.settings.get_safe("compiler.version") | ||
if compiler_version >= "191": | ||
tc.extra_cflags = ["-Zf"] | ||
if compiler_version >= "180": | ||
tc.extra_cflags = ["-FS"] | ||
# Visual Studio support for Conan 1.x; Can be remvoed when 2.0 is default | ||
if self.settings.get_safe("compiler") == "Visual Studio": | ||
compiler_version = self.settings.get_safe("compiler.version") | ||
if compiler_version >= "15": | ||
tc.extra_cflags = ["-Zf"] | ||
if compiler_version >= "12": | ||
tc.extra_cflags = ["-FS"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if is_msvc(self): | |
compiler_version = self.settings.get_safe("compiler.version") | |
if compiler_version >= "191": | |
tc.extra_cflags = ["-Zf"] | |
if compiler_version >= "180": | |
tc.extra_cflags = ["-FS"] | |
# Visual Studio support for Conan 1.x; Can be remvoed when 2.0 is default | |
if self.settings.get_safe("compiler") == "Visual Studio": | |
compiler_version = self.settings.get_safe("compiler.version") | |
if compiler_version >= "15": | |
tc.extra_cflags = ["-Zf"] | |
if compiler_version >= "12": | |
tc.extra_cflags = ["-FS"] | |
if is_msvc(self): | |
compiler_version = self.settings.get_safe("compiler.version") | |
if compiler_version >= "191": | |
tc.extra_cflags += ["-Zf"] | |
if compiler_version >= "180": | |
tc.extra_cflags += ["-FS"] | |
# Visual Studio support for Conan 1.x; Can be remvoed when 2.0 is default | |
if self.settings.get_safe("compiler") == "Visual Studio": | |
compiler_version = self.settings.get_safe("compiler.version") | |
if compiler_version >= "15": | |
tc.extra_cflags += ["-Zf"] | |
if compiler_version >= "12": | |
tc.extra_cflags += ["-FS"] |
Please bot do not close it |
@System-Arch, could you merge @valgur contribution to your branch? |
Based on changes by @System-Arch in conan-io#14916.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
* isl: migrate to Conan v2 Based on changes by @System-Arch in #14916. * isl: remove unnecessary comments * isl: add v0.26, use .xz * isl: cross-building on macOS is broken * isl: fix_apple_shared_install_name()
Specify library name and version: isl/0.24
Migrate to Conan 2.0. Resolves #14915