Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISL Conan 2.0 compatibility #14916

Closed
wants to merge 27 commits into from

Conversation

System-Arch
Copy link
Contributor

Specify library name and version: isl/0.24

Migrate to Conan 2.0. Resolves #14915


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/isl/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/isl/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/isl/all/test_package/conanfile.py Show resolved Hide resolved
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 25, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stale stale bot removed the stale label May 18, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 29 (114ac1206b19530d8bd3b9640d6bbdef23c57ff3):

  • isl/0.24@:
    All packages built successfully! (All logs)

  • isl/0.25@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 27 (114ac1206b19530d8bd3b9640d6bbdef23c57ff3):

  • isl/0.25@:
    CI failed to create some packages (All logs)

    Logs for packageID df70c144f40a5db5c202f2d137a4525758b7e7ca:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=gnu17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    Requirements
        gmp/6.2.1#9cd6e4a851f6ffd6ea5b5d563f23abcc - Downloaded (conan-center)
        isl/0.25#306aa73056c247e33aaed8c6d5d17cd0 - Cache
    Build requirements
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c - Downloaded (conan-center)
    
    ======== Computing necessary packages ========
    gmp/6.2.1: Checking 11 compatible configurations:
    gmp/6.2.1: '7b7c5ba682b3f4f124170d1525451cfc470a5649': compiler.cppstd=98
    gmp/6.2.1: '726c3fc53f4c3f533c200af98be6fc8c8b793636': compiler.cppstd=gnu98
    gmp/6.2.1: '002f834e4bdb67459cd43f178b053f7fd42a36f4': compiler.cppstd=11
    gmp/6.2.1: '0c8e21f448e3a76f9c23d3945ed8b61899d85e2d': compiler.cppstd=gnu11
    gmp/6.2.1: '780d464fa30c7e01a415fb3a025348fcad9d77fd': compiler.cppstd=14
    gmp/6.2.1: '5f02ce377eb50f2f4521943581902c6148f9df38': compiler.cppstd=gnu14
    gmp/6.2.1: '06e1b75530ed9090d02d3c3b2a74135e4340ebff': compiler.cppstd=17
    gmp/6.2.1: 'b673569f3167f0623703b306a30ceedea2ea3989': compiler.cppstd=20
    gmp/6.2.1: '156904fcd7d8029abd8e0b2a01f48cd1b637a871': compiler.cppstd=gnu20
    gmp/6.2.1: '7e8e9b0739cd237e3e12b6a2500d2ab6badcbc4c': compiler.cppstd=23
    gmp/6.2.1: '0293bfc3f42f07f063f7f4d8eb78de19ca8634ca': compiler.cppstd=gnu23
    isl/0.25: Forced build from source
    Requirements
        gmp/6.2.1#9cd6e4a851f6ffd6ea5b5d563f23abcc:cd77353322a4800eb83f51c51fbf6bc1145bd0e2 - Missing
        isl/0.25#306aa73056c247e33aaed8c6d5d17cd0:df70c144f40a5db5c202f2d137a4525758b7e7ca - Build
    Build requirements
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c:3593751651824fb813502c69c971267624ced41a#c69dc2230d016a77b5514d9916b14714 - Skip
    
    ======== Installing packages ========
    ERROR: Missing binary: gmp/6.2.1:cd77353322a4800eb83f51c51fbf6bc1145bd0e2
    
    gmp/6.2.1: WARN: Can't find a 'gmp/6.2.1' package binary 'cd77353322a4800eb83f51c51fbf6bc1145bd0e2' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=gnu17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    disable_assembly=True
    enable_cxx=True
    enable_fat=False
    fPIC=True
    shared=False
    
    ERROR: Missing prebuilt package for 'gmp/6.2.1'
    Check the available packages using 'conan list gmp/6.2.1:* -r=remote'
    or try to build locally from sources using the '--build=gmp/6.2.1' argument
    
    More Info at 'https://docs.conan.io/en/2/knowledge/faq.html#error-missing-prebuilt-package'
    
  • isl/0.24@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Comment on lines +92 to +104
if is_msvc(self):
compiler_version = self.settings.get_safe("compiler.version")
if compiler_version >= "191":
tc.extra_cflags = ["-Zf"]
if compiler_version >= "180":
tc.extra_cflags = ["-FS"]
# Visual Studio support for Conan 1.x; Can be remvoed when 2.0 is default
if self.settings.get_safe("compiler") == "Visual Studio":
compiler_version = self.settings.get_safe("compiler.version")
if compiler_version >= "15":
tc.extra_cflags = ["-Zf"]
if compiler_version >= "12":
tc.extra_cflags = ["-FS"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if is_msvc(self):
compiler_version = self.settings.get_safe("compiler.version")
if compiler_version >= "191":
tc.extra_cflags = ["-Zf"]
if compiler_version >= "180":
tc.extra_cflags = ["-FS"]
# Visual Studio support for Conan 1.x; Can be remvoed when 2.0 is default
if self.settings.get_safe("compiler") == "Visual Studio":
compiler_version = self.settings.get_safe("compiler.version")
if compiler_version >= "15":
tc.extra_cflags = ["-Zf"]
if compiler_version >= "12":
tc.extra_cflags = ["-FS"]
if is_msvc(self):
compiler_version = self.settings.get_safe("compiler.version")
if compiler_version >= "191":
tc.extra_cflags += ["-Zf"]
if compiler_version >= "180":
tc.extra_cflags += ["-FS"]
# Visual Studio support for Conan 1.x; Can be remvoed when 2.0 is default
if self.settings.get_safe("compiler") == "Visual Studio":
compiler_version = self.settings.get_safe("compiler.version")
if compiler_version >= "15":
tc.extra_cflags += ["-Zf"]
if compiler_version >= "12":
tc.extra_cflags += ["-FS"]

@AbrilRBS AbrilRBS self-assigned this Sep 13, 2023
@AbrilRBS
Copy link
Member

Please bot do not close it

@AndreyMlashkin
Copy link
Contributor

@System-Arch, could you merge @valgur contribution to your branch?
Those changes are importatnt

valgur added a commit to valgur/conan-center-index that referenced this pull request Dec 7, 2023
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 13, 2024
conan-center-bot pushed a commit that referenced this pull request Feb 19, 2024
* isl: migrate to Conan v2

Based on changes by @System-Arch in #14916.

* isl: remove unnecessary comments

* isl: add v0.26, use .xz

* isl: cross-building on macOS is broken

* isl: fix_apple_shared_install_name()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] ISL/0.24 lacks support for Conan 2.0
7 participants