Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isl: migrate to Conan v2 #21153

Merged
merged 5 commits into from
Feb 19, 2024
Merged

isl: migrate to Conan v2 #21153

merged 5 commits into from
Feb 19, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 15, 2023 •
edited
Loading

Minor additions to #14916. Notably, enabled imath support.

@valgur valgur mentioned this pull request Nov 15, 2023
Open
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost ghost mentioned this pull request Nov 15, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Nov 15, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 8406f8e
isl/0.25@#edbea0c4e4aa9f8f71ad6ef4a3a317f0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib
isl/0.24@#017584689c902bbc6c26d91ae550cb53 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib

@uilianries
Copy link
Member

@System-Arch hello! I see you are the co-author of this PR, could you please sign the CLA listed on the comment above: #21153 (comment)

@uilianries uilianries self-assigned this Nov 16, 2023
@valgur valgur mentioned this pull request Nov 17, 2023
Closed
jwillikers
jwillikers approved these changes Nov 20, 2023
View reviewed changes
recipes/isl/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Copy link
Member

@System-Arch is the co-author of this PR and needs to accept the CLA too. @System-Arch Could you please sign the CLA pointed in the comment #21153 (comment)

@valgur
Copy link
Contributor Author

valgur commented Dec 5, 2023

@uilianries Looks like @System-Arch has been inactive on GitHub since May. Since he/she has clearly signed an older version of the CLA for previous PRs, could a one-time exception be made, maybe?

@uilianries
Copy link
Member

@valgur Unfortunately it's not possible. The CLA is not only mandatory, but part of the CI, and we don't have how to add exceptions.

What you could do is a push force and keep only you as the author.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit d683554
isl/0.25@#0bac0fd59247aa5a9e7e43db7308bcbd 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib
isl/0.24@#2b9f53aabbead70a7e24fe271acc8264 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 4fcb980
isl/0.26@#8b62790a60c6ad6fc32d06dccf6b5cd6 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib
isl/0.24@#c9bbc93436f1c07abb75c7dca3cb6192 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib
isl/0.25@#c0728cddb1bc8f2e1ca7c1d7cb327041 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libisl.23.dylib, libisl.dylib

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (710dca567ec79f70082974ea37194871cf975632):

  • isl/0.26:
    All packages built successfully! (All logs)

  • isl/0.24:
    All packages built successfully! (All logs)

  • isl/0.25:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (710dca567ec79f70082974ea37194871cf975632):

  • isl/0.26:
    All packages built successfully! (All logs)

  • isl/0.25:
    All packages built successfully! (All logs)

  • isl/0.24:
    All packages built successfully! (All logs)

@valgur valgur mentioned this pull request Jan 10, 2024
Open
@conan-center-bot conan-center-bot merged commit 25e0860 into conan-io:master Feb 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@danimtb danimtb danimtb approved these changes

@AndreyMlashkin AndreyMlashkin AndreyMlashkin approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

@uilianries uilianries Awaiting requested review from uilianries

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] ISL/0.24 lacks support for Conan 2.0
7 participants
@valgur @CLAassistant @conan-center-bot @uilianries @AndreyMlashkin @danimtb @jwillikers