Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal < 3.5 : conan v2 support #15386

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 20, 2023

Specify library name and version: lib/1.0


@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 21, 2023

I guess these Visual Studio link errors come from NMakeDeps generator which doesn't inject cpp_info.defines of dependencies, leading to these errors afterwards in test package.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 21, 2023

I guess these Visual Studio link errors come from NMakeDeps generator which doesn't inject cpp_info.defines of dependencies, leading to these errors afterwards in test package.

conan-io/conan#12943

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 21, 2023

I can manually inject system libs & definitions of dependencies with something like conan-io/conan#12943 (comment), or wait the fix in conan client conan-io/conan#12944 & its deployment in c3i...

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 25, 2023

conan-io/conan#12944 has been merged. Waiting 1.58.0 release & its deployment in c3i.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (f67cb7bdc6bfcda1171589ff9b7ca9733627616e):

  • gdal/3.1.4@:
    All packages built successfully! (All logs)

  • gdal/3.2.3@:
    All packages built successfully! (All logs)

  • gdal/3.4.3@:
    All packages built successfully! (All logs)

  • gdal/3.4.1@:
    All packages built successfully! (All logs)

  • gdal/3.3.3@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 2 (f67cb7bdc6bfcda1171589ff9b7ca9733627616e):

An unexpected error happened and has been reported. Help is on its way! 🏇

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 45e349e into conan-io:master Feb 13, 2023
@SpaceIm SpaceIm deleted the gdal-lt-3.5-conan-v2 branch February 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants