qt6: fixes for cross compiling #15678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier you might be interested. 😉 |
ghost
mentioned this pull request
|
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Feb 2, 2023
This comment has been minimized.
This comment has been minimized.
sabelka
force-pushed
the
qt6-mingw-cross
branch
from
c12876d
to
53e21a8
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 53e21a8qt/6.3.2qt/6.2.4qt/6.4.2qt/6.4.1 |
This comment has been minimized.
This comment has been minimized.
sabelka
force-pushed
the
qt6-mingw-cross
branch
from
29fca93
to
5892363
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 8e41741qt/6.4.2qt/6.4.1qt/6.2.4qt/6.3.2 |
ghost
mentioned this pull request
sabelka
force-pushed
the
qt6-mingw-cross
branch
from
7ca272e
to
381dcab
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 381dcabqt/6.3.2qt/6.4.2qt/6.4.1qt/6.2.4 |
This comment has been minimized.
This comment has been minimized.
Comment on lines
+250
to
+220
| # If we are cross-compiling we need to enable these options primarily | ||
| #for the _native_ Qt build, because the builing Qt with the cross | ||
| # compiler requires the native Qt tools | ||
| if cross_building(self): | ||
| self.options["qt"].qttools = True | ||
| self.options["qt"].gui = True | ||
| self.options["qt"].widgets = True | ||
|
|
There was a problem hiding this comment.
Suggested change
| # If we are cross-compiling we need to enable these options primarily | |
| #for the _native_ Qt build, because the builing Qt with the cross | |
| # compiler requires the native Qt tools | |
| if cross_building(self): | |
| self.options["qt"].qttools = True | |
| self.options["qt"].gui = True | |
| self.options["qt"].widgets = True |
There was a problem hiding this comment.
Unfortunately, this doesn't work. When I remove these options from from configure(), then the native tool are not built and the cross building fails because 'lconvert' is not found.
This happens even when I explicitly request the options from the command line, e.g. with
conan create 6.x.x/conanfile.py 6.4.2@ -pr:b=default -pr:h=mingw-win64 -o=qt:gui=True -o=qt:qttools=True -o=qt:widgets=True --build=missing
There was a problem hiding this comment.
Then I don't understand your commit message in 30a0fb3
There was a problem hiding this comment.
Well, in the cross-compiling case, two instances of qt are built, because qt has itself as tool_requires.
The "tool_requires"-qt instance is built with the native tool-chain and requires the qttools submodule enabled.
When I set -o qt:qttools=True or -o:b qt:qttools=True on the command line of my conan create command it seems not to get through to the native qt build. Only the qtbase module is built in the native qt instance. But when I add self.options["qt"].qttools = True in configure(self) it works and the native qttools module gets compiled.
There was a problem hiding this comment.
please report this issue on conan : https://github.com/conan-io/conan/issues/new?assignees=&labels=&template=bug.yml&title=%5Bbug%5D+SHORT+DESCRIPTION
Regarding this PR, you have to know that setting option values in configure(self) is not enough to be sure that the option values are correct. The problem is that some other package in the dependency graph could change the option afterwards (self.options["qt"].qttools = False for example). This is why you need to check the option values in validate(self), because at this point you are sure that the option values won't change any more.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 6, 2023
Closed
Closed
This was referenced Sep 28, 2023
Merged
This was referenced Oct 11, 2023
Merged
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ghost
mentioned this pull request
3 tasks
This was referenced Nov 4, 2023
Closed
This was referenced Nov 18, 2023
ghost
mentioned this pull request
ghost
mentioned this pull request
3 tasks
This was referenced Feb 5, 2024
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: qt/6.4.2