-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt6: fix QuickTest declaration #21263
Conversation
It requires `Quick`, as the name suggests see also https://github.com/qt/qtdeclarative/blob/v6.6.0/src/qmltest/CMakeLists.txt#L44
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 6 (
|
Hooks produced the following warnings for commit cb1bf01qt/6.5.1@#4426442e9b63fbc9a3217b85c1873280
qt/6.5.0@#e519df2a773bf89e07c130c4a4e54ff7
qt/6.5.2@#74590add74d15c49e1a37341270f8495
qt/6.3.2@#c326a45eaa7e8f979efed4f839a00120
qt/6.4.2@#37a1ada15c46fcdbfbf2d02ce12bbfd3
|
Thanks a lot for your fixes @ericLemanissier :) Just a minor heads up: When fixing configurations not covered by default by the CI, we'de appreciate if compilation logs were posted alongside the PR, so that it's easier to doublecheck our own local testing, and , more importantly, future maintenance reference in case something fails - I've attached my own (without the extremely verbose steps)
|
ok, I will do next time |
It requires
Quick
, as the name suggestssee also https://github.com/qt/qtdeclarative/blob/v6.6.0/src/qmltest/CMakeLists.txt#L44
Specify library name and version: qt/6.*
CC @petermbauer
fixes #17743
fixes #17977
fixes #21231
fixes #20921