qt/6.5.x: Only output a warning when using GCC 9 #19339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
|
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Aug 22, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 60d6371qt/6.5.2@#ad8aa5c148e592d206cce076c6a3d4fcqt/6.5.0@#f1e37f8d24ac151cf737727d5c3a0211qt/6.5.1@#1dd88838057b0529620e1beb119430e4qt/6.4.2@#766d5a0657c3890b518c22f10f96927bqt/6.3.2@#3033ca0424cbfaa0c0636c32352b4266 |
ericLemanissier
approved these changes
Aug 24, 2023
MartinDelille
approved these changes
Aug 24, 2023
This was referenced Sep 6, 2023
Closed
Closed
This was referenced Sep 28, 2023
Merged
This was referenced Oct 11, 2023
Merged
This was referenced Nov 4, 2023
Closed
AbrilRBS
previously approved these changes
Nov 16, 2023
This comment has been minimized.
This comment has been minimized.
ericLemanissier
suggested changes
Nov 16, 2023
There was a problem hiding this comment.
we should be able to build with any version of gcc 9 by applying this patch on qt 6.5.0 to 6.6.0 : https://bugreports.qt.io/secure/attachment/148895/148895_0001-Fix-FTBFS-qt-6.5.0-on-gcc-9.patch
The patch has been reviewed upstream : https://bugreports.qt.io/browse/QTBUG-112920?focusedId=757912&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-757912
|
Thanks for the insight @ericLemanissier! Let's do that :) |
ericLemanissier
suggested changes
Nov 16, 2023
Duh! Thanks! |
ericLemanissier
approved these changes
Nov 16, 2023
Conan v1 pipeline ❌Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
ericLemanissier
suggested changes
Nov 17, 2023
Fail explicitly for GCC 9.1 or 9.2 which won't work. Users using any version of GCC 9 may be using newer versions of GCC 9. A warning should suffice in this case, without requiring users to change their settings model. For details, see https://bugreports.qt.io/browse/QTBUG-112920
This reverts commit 7e50ff3.
jwillikers
force-pushed
the
qt-6-gcc-9
branch
from
7a05e3d
to
b207b6a
Compare
This was referenced Nov 18, 2023
ghost
mentioned this pull request
ghost
mentioned this pull request
3 tasks
|
Closing as it looks as though this check was removed entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail explicitly for GCC 9.1 or 9.2 which won't work. Users using any version of GCC 9 may be using newer versions of GCC 9. A warning should suffice in this case, without requiring users to change their settings model to incorporate minor version numbers of the compiler. For details, see https://bugreports.qt.io/browse/QTBUG-112920
Specify library name and version: qt/6.5.x