Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: add ninja to build requirements #16817

Closed
wants to merge 1 commit into from

Conversation

jhabermas
Copy link
Contributor

Specify library name and version: wayland/1.21.0

This fixes build error on Ubuntu:

ERROR: Could not detect Ninja v1.8.2 or newer

@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/wayland//'.

👋 @jwillikers you might be interested. 😉

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (7aecffd53dbd077d6a0d5931d1ff335d05cf3d83):

  • wayland/1.20.0@:
    All packages built successfully! (All logs)

  • wayland/1.21.0@:
    All packages built successfully! (All logs)

  • wayland/1.18.0@:
    All packages built successfully! (All logs)

  • wayland/1.19.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 1 (7aecffd53dbd077d6a0d5931d1ff335d05cf3d83):

  • wayland/1.20.0@:
    All packages built successfully! (All logs)

  • wayland/1.21.0@:
    All packages built successfully! (All logs)

  • wayland/1.18.0@:
    All packages built successfully! (All logs)

  • wayland/1.19.0@:
    All packages built successfully! (All logs)

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 31, 2023

That's not the proper fix (assuming there is really an issue in conancenter, and it's not a conan client issue). This recipe should not decide whether ninja is required since it's a internal detail of meson backend.

@jwillikers
Copy link
Contributor

@SpaceIm Is correct, the Meson package should be pulling in ninja automatically.

@jhabermas
Copy link
Contributor Author

Yes, you're right and this doesn't actually fix the problem. Here's the full error I'm getting right now:
I'll get back if I find something more.

2023-03-31T15:05:36.3007442Z -------- Installing package wayland/1.21.0 (93 of 101) --------
2023-03-31T15:05:36.3007658Z wayland/1.21.0: Building from source
2023-03-31T15:05:36.3007902Z wayland/1.21.0: Package wayland/1.21.0:619290eb30b686d528f3479ce8eaab50a8050dbd
2023-03-31T15:05:36.3008156Z wayland/1.21.0: Copying sources to build folder
2023-03-31T15:05:36.3008391Z wayland/1.21.0: Building your package in /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b
2023-03-31T15:05:36.3008617Z wayland/1.21.0: Calling generate()
2023-03-31T15:05:36.3008971Z wayland/1.21.0: Generators folder: /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release/conan
2023-03-31T15:05:36.3009219Z wayland/1.21.0: Generating aggregated env files
2023-03-31T15:05:36.3009499Z wayland/1.21.0: Generated aggregated env files: ['conanbuild.sh']
2023-03-31T15:05:36.3009706Z wayland/1.21.0: Calling build()
2023-03-31T15:05:36.3010413Z wayland/1.21.0: Meson configure cmd: meson setup --native-file "/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release/conan/conan_meson_native.ini" "/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release" "/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/src" -Dprefix="/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/p"
2023-03-31T15:05:36.3011505Z wayland/1.21.0: RUN: meson setup --native-file "/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release/conan/conan_meson_native.ini" "/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release" "/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/src" -Dprefix="/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/p"
2023-03-31T15:05:39.2068145Z The Meson build system
2023-03-31T15:05:39.2068436Z Version: 1.0.0
2023-03-31T15:05:39.2068633Z Source dir: /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/src
2023-03-31T15:05:39.2069178Z Build dir: /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release
2023-03-31T15:05:39.2069388Z Build type: native build
2023-03-31T15:05:39.2069547Z Project name: wayland
2023-03-31T15:05:39.2069706Z Project version: 1.21.0
2023-03-31T15:05:39.2070107Z C compiler for the host machine: clang (clang 14.0.6 "Ubuntu clang version 14.0.6-++20220622053131+f28c006a5895-1~exp1~20220622173215.157")
2023-03-31T15:05:39.2070403Z C linker for the host machine: clang ld.lld 14.0.6
2023-03-31T15:05:39.2070587Z Host machine cpu family: x86_64
2023-03-31T15:05:39.2070751Z Host machine cpu: x86_64
2023-03-31T15:05:39.2071139Z Compiler for C supports arguments -Wno-unused-parameter: YES 
2023-03-31T15:05:39.2071647Z Compiler for C supports arguments -Wstrict-prototypes: YES 
2023-03-31T15:05:39.2071932Z Compiler for C supports arguments -Wmissing-prototypes: YES 
2023-03-31T15:05:39.2072213Z Compiler for C supports arguments -fvisibility=hidden: YES 
2023-03-31T15:05:39.2072400Z Has header "sys/prctl.h" : YES 
2023-03-31T15:05:39.2072562Z Has header "sys/procctl.h" : NO 
2023-03-31T15:05:39.2072728Z Has header "sys/ucred.h" : NO 
2023-03-31T15:05:39.2072897Z Checking for function "accept4" : YES 
2023-03-31T15:05:39.2073084Z Checking for function "mkostemp" : YES 
2023-03-31T15:05:39.2073270Z Checking for function "posix_fallocate" : YES 
2023-03-31T15:05:39.2073450Z Checking for function "prctl" : YES 
2023-03-31T15:05:39.2073635Z Checking for function "memfd_create" : YES 
2023-03-31T15:05:39.2073815Z Checking for function "mremap" : YES 
2023-03-31T15:05:39.2073988Z Checking for function "strndup" : YES 
2023-03-31T15:05:39.2074181Z Checking whether type "struct xucred" has member "cr_pid" : NO 
2023-03-31T15:05:39.2074520Z Found pkg-config: /home/vsts_azpcontainer/.conan2/p/pkgcod729a37c3fef7/p/bin/pkgconf (1.9.3)
2023-03-31T15:05:39.2074818Z Run-time dependency libffi found: YES 3.4.3
2023-03-31T15:05:39.2075016Z Header "sys/signalfd.h" has symbol "SFD_CLOEXEC" : YES 
2023-03-31T15:05:39.2075218Z Header "sys/timerfd.h" has symbol "TFD_CLOEXEC" : YES 
2023-03-31T15:05:39.2075425Z Header "time.h" has symbol "CLOCK_MONOTONIC" : YES 
2023-03-31T15:05:39.2075615Z Checking for function "clock_gettime" : NO 
2023-03-31T15:05:39.2075783Z Library rt found: YES
2023-03-31T15:05:39.2076055Z Checking for function "clock_gettime" with dependency -lrt: YES 
2023-03-31T15:05:39.2076258Z Configuring config.h using configuration
2023-03-31T15:05:39.2076528Z Configuring wayland-version.h using configuration
2023-03-31T15:05:39.2076778Z Run-time dependency expat found: YES 2.5.0
2023-03-31T15:05:39.2077031Z Run-time dependency libxml-2.0 found: YES 2.10.3
2023-03-31T15:05:39.2077300Z Program embed.py found: YES (/opt/pyenv/versions/3.8.12/bin/python3 /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/src/src/embed.py)
2023-03-31T15:05:39.2077545Z Library m found: YES
2023-03-31T15:05:39.2077768Z Run-time dependency threads found: YES
2023-03-31T15:05:39.2077945Z Program nm found: YES (/usr/bin/nm)
2023-03-31T15:05:39.2078314Z Program wayland-egl-symbols-check found: YES (/home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/src/egl/wayland-egl-symbols-check)
2023-03-31T15:05:39.2078563Z Build targets in project: 14
2023-03-31T15:05:39.2078793Z NOTICE: Future-deprecated features used:
2023-03-31T15:05:39.2079071Z  * 0.62.0: {'pkgconfig.generate variable for builtin directories'}
2023-03-31T15:05:39.2079258Z 
2023-03-31T15:05:39.2079394Z wayland 1.21.0
2023-03-31T15:05:39.2079459Z 
2023-03-31T15:05:39.2079597Z   User defined options
2023-03-31T15:05:39.2079938Z     Native files: /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release/conan/conan_meson_native.ini
2023-03-31T15:05:39.2080202Z     prefix      : /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/p
2023-03-31T15:05:39.2080312Z 
2023-03-31T15:05:39.2080361Z 
2023-03-31T15:05:39.2080517Z ERROR: Could not detect Ninja v1.8.2 or newer
2023-03-31T15:05:39.2080599Z 
2023-03-31T15:05:39.2080933Z A full log can be found at /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release/meson-logs/meson-log.txt
2023-03-31T15:05:39.2519246Z 
2023-03-31T15:05:39.2569285Z wayland/1.21.0: ERROR: 
2023-03-31T15:05:39.2569767Z Package '619290eb30b686d528f3479ce8eaab50a8050dbd' build failed
2023-03-31T15:05:39.2570143Z wayland/1.21.0: WARN: Build folder /home/vsts_azpcontainer/.conan2/p/t/waylae0aae6bb0a73f/b/build-release
2023-03-31T15:05:39.2570421Z *********************************************************
2023-03-31T15:05:39.2570687Z Recipe 'wayland/1.21.0' cannot build its binary
2023-03-31T15:05:39.2570887Z It is possible that this recipe is not Conan 2.0 ready
2023-03-31T15:05:39.2571199Z If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
2023-03-31T15:05:39.2571603Z If it is your recipe, check if it is updated to 2.0
2023-03-31T15:05:39.2571816Z *********************************************************
2023-03-31T15:05:39.2571909Z 
2023-03-31T15:05:39.2587714Z ERROR: wayland/1.21.0: Error in build() method, line 104
2023-03-31T15:05:39.2587930Z 	meson.configure()
2023-03-31T15:05:39.2588095Z 	ConanException: Error 1 while executing

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 31, 2023

Did you open an issue? What is you conan version. I know something has been fixed in conan 2.0.2 regarding MesonToolchain: conan-io/conan#13346

@jhabermas
Copy link
Contributor Author

I eventually fixed it by setting NINJA environment variable to ninja location to help Meson find it. It ends up using system ninja though and not conan provided one.

Also this issue doesn't happen on default Ubuntuinstall, but happens on my particular dev environment with some non-default tools (clang, pyenv). I haven't got to the bottom of it though.

@jhabermas jhabermas closed this Apr 3, 2023
@jhabermas jhabermas deleted the wayland_add_ninja branch April 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants