Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MesonToolchain usages of VirtualBuildEnv #13346

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix MesonToolchain usages of VirtualBuildEnv #13346

merged 1 commit into from
Mar 7, 2023

Conversation

memsharded
Copy link
Member

Changelog: Bugfix: Fix VirtualBuildEnv environment not being created when MesonToolchain is instantiated.
Docs: Omit

Close #13344

@memsharded memsharded added this to the 2.0.2 milestone Mar 6, 2023
@memsharded memsharded mentioned this pull request Mar 6, 2023
Closed
AbrilRBS
AbrilRBS approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit to understand the issue and the fix, and now even though what is wrong makes sense, I can't find what the proper way to do this would be

@memsharded
Copy link
Member Author

Took me a bit to understand the issue and the fix, and now even though what is wrong makes sense, I can't find what the proper way to do this would be

The fix is a ugly hack workaround. The good solution is to avoid using VirtualBuildEnv in such a way, that usage is a big smell, and we have been wanting to clean that for some time.

@AbrilRBS AbrilRBS merged commit 62bb3b4 into conan-io:release/2.0 Mar 7, 2023
@memsharded memsharded deleted the fix/mesontoolchain_env branch March 7, 2023 09:25
@memsharded memsharded mentioned this pull request Mar 7, 2023
Closed
1 task
@SpaceIm SpaceIm mentioned this pull request Mar 31, 2023
Closed
3 tasks
@duncanspumpkin duncanspumpkin mentioned this pull request Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

[bug][Conan 2.0] Meson generator can't find Ninja
2 participants
@memsharded @AbrilRBS