-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshooting 'sdl_mixer: conan v2 support' PR #18473
Conversation
This comment has been minimized.
This comment has been minimized.
I found the problem causing the v2 test failure. The
But the
In newer versions of SDL_mixer, an official CMakeLists.txt was added and you can see that's exactly what it's doing: Removing the
I think that's because the explicit load isn't necessary since the SDL_mixer shared library is built with the dependencies and has all the rpath settings to find the .so files so everything loads automatically at startup. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a05c0e8sdl_mixer/2.0.4
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 5be2514sdl_mixer/2.0.4
|
As for the windows build error:
It works fine with flac 1.3.3, but fails with flac 1.4.2. We can't just downgrade, because that causes version conflicts on Linux dependencies. Using MSVC's |
5be2514
to
3d71609
Compare
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying sdl_mixer/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
8299b99
to
a30b643
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
1 similar comment
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
This is not intended to merge, I'm just trying to help with #18836 by attempting to solve the CI failures it has.