-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdl_mixer/all: migrate to Conan v2 #18836
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 60c8ca2sdl_mixer/2.0.4
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
3c75d1d
to
81bf9f7
Compare
This comment has been minimized.
This comment has been minimized.
For sdl_mixer conan-io#18836.
For sdl_mixer #18836. Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
81bf9f7
to
0d1c225
Compare
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
f2abd4a
to
9098e39
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9098e39sdl_mixer/2.0.4@#d6252b6bc7e2dd44c6b078254f7f20c3
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Don't close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing this migration. Some considerations:
- Remove fluidsynth as requirement, and its option too. It's not available in CCI and trying to use will break the package.
Regards.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 11 (
|
Hooks produced the following warnings for commit 505a6b4sdl_mixer/2.0.4@#8dbc6fb56b9c3650f5bd04ad3e23a356
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linking in test_package currently fails for GCC due to #12826.