Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdma-core: add new recipe #18978

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 31, 2023

Adds https://github.com/linux-rdma/rdma-core

Required by openmpi (which uses libibverbs), libfabric (uses libefa and librdmacm) and possibly libpcap packages.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 18 (e088f8b18d91c61c58dcbb5373359b9dee076abb):

  • rdma-core/49.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 18 (e088f8b18d91c61c58dcbb5373359b9dee076abb):

  • rdma-core/49.0:
    All packages built successfully! (All logs)

@wadimklincov
Copy link
Contributor

Building with build_librdmacm enabled fails, at least on my system (Debian 12, gcc 11):

build_assert.h:23:33: error: size of unnamed array is negative
23 | do { (void) sizeof(char [1 - 2*!(cond)]); } while(0)
| ^
src/librdmacm/acm.c:105:17: note: in expansion of macro ‘BUILD_ASSERT’
105 | BUILD_ASSERT(sizeof(IBACM_SERVER_PATH) <=
| ^~~~~~~~~~~~
[90/138] Building C object libibverbs/CMakeFiles/ibverbs.dir/marshall.c.o

Looks like the generated string for IBACM_SERVER_PATH exceeds the (108 byte?) limit of addr.unx.sun_path: /home/developer/.conan/data/rdma-core/49.0/_/_/package/c965b2ab63caf8e11f0c51cc66e6a9f195743f00/var/run/ibacm.port. Patching config.h.in seems to help.

Since this doesn't depend on systemd, perhaps could be patched by default?

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁 Only a minor suggestion

Comment on lines +52 to +53
if self.settings.os in ["Linux", "FreeBSD"]:
self.requires("libudev/system")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation is already in the validate() function.

Suggested change
if self.settings.os in ["Linux", "FreeBSD"]:
self.requires("libudev/system")
self.requires("libudev/system")

@franramirez688
Copy link
Contributor

Looks like the generated string for IBACM_SERVER_PATH exceeds the (108 byte?) limit of addr.unx.sun_path: /home/developer/.conan/data/rdma-core/49.0/_/_/package/c965b2ab63caf8e11f0c51cc66e6a9f195743f00/var/run/ibacm.port. Patching config.h.in seems to help.

Since this doesn't depend on systemd, perhaps could be patched by default?

Oops, I did not see that. @valgur do you have any idea on how to solve this?

name = "rdma-core"
description = ("RDMA core userspace libraries and daemons. "
"Provides userspace components for the Linux Kernel's drivers/infiniband subsystem.")
license = ("GPL-2.0", "Linux-OpenIB", "BSD-2-Clause")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is GPL-2.0-only.

Suggested change
license = ("GPL-2.0", "Linux-OpenIB", "BSD-2-Clause")
license = ("GPL-2.0-only", "Linux-OpenIB", "BSD-2-Clause")

@conan-center-bot conan-center-bot merged commit 6965eaa into conan-io:master Mar 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants