-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdma-core: add new recipe #18978
rdma-core: add new recipe #18978
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
236b4ca
to
7c1b7a0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
83dc5f8
to
7ad7faa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 18 (
Conan v2 pipeline ✔️
All green in build 18 (
|
Building with
Looks like the generated string for Since this doesn't depend on systemd, perhaps could be patched by default? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😁 Only a minor suggestion
if self.settings.os in ["Linux", "FreeBSD"]: | ||
self.requires("libudev/system") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation is already in the validate()
function.
if self.settings.os in ["Linux", "FreeBSD"]: | |
self.requires("libudev/system") | |
self.requires("libudev/system") |
Oops, I did not see that. @valgur do you have any idea on how to solve this? |
name = "rdma-core" | ||
description = ("RDMA core userspace libraries and daemons. " | ||
"Provides userspace components for the Linux Kernel's drivers/infiniband subsystem.") | ||
license = ("GPL-2.0", "Linux-OpenIB", "BSD-2-Clause") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is GPL-2.0-only.
license = ("GPL-2.0", "Linux-OpenIB", "BSD-2-Clause") | |
license = ("GPL-2.0-only", "Linux-OpenIB", "BSD-2-Clause") |
Adds https://github.com/linux-rdma/rdma-core
Required by
openmpi
(which useslibibverbs
),libfabric
(useslibefa
andlibrdmacm
) and possiblylibpcap
packages.