-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libfabric: migrate to Conan v2, add missing dependencies #18979
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
85eb3d4
to
ed06eaa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7482e9d
to
5ca9136
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
38ae28b
to
7391f65
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b31db6a
to
12b882a
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: PerseoGI <perseog@jfrog.com>
This comment has been minimized.
This comment has been minimized.
recipes/libfabric/all/conanfile.py
Outdated
if self.options.get_safe('with_libnl') and not os.path.isdir(str(self.options.with_libnl)): | ||
raise ConanInvalidConfiguration("Value of with_libnl must be an existing directory") | ||
if self.settings.os == "Windows": | ||
raise ConanInvalidConfiguration("libfabric is not available on Windows") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ConanInvalidConfiguration("libfabric is not available on Windows") | |
# FIXME: libfabric provides msbuild project files. | |
raise ConanInvalidConfiguration(f"{self.ref} Conan recipes is not supported on Windows. Contributions are welcome.") |
The project provides msbuild files, but is not something to be done in this PR. Otherwise it will be too much.
recipes/libfabric/all/conanfile.py
Outdated
} | ||
"shared": [True, False], | ||
"fPIC": [True, False], | ||
**{ p: ["yes", "no", "dl"] for p in _providers }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**{ p: ["yes", "no", "dl"] for p in _providers }, | |
**{ p: [None, "ANY"] for p in _providers }, |
I would suggest using any in this case, as users may pass the path of the provider, not related to a loadable library (dl:path), it could be static as well.
--enable-bgq[=yes|no|auto|dl|PATH|dl:PATH]
Enable bgq provider [default=auto] (yes: enable bgq
provider; no: disable bgq provider; auto: enable bgq
provider if possible; dl: enable bgq provider and
build as a loadable library; PATH: enable bgq
provider and use bgq installed under PATH; dl:PATH:
enable bgq provider and build as a loadable library
and use bgq installed under PATH)
"fPIC": True, | ||
"cxi": "no", # library not available on CCI | ||
"dmabuf_peer_mem": "yes", | ||
"efa": "yes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also dislike "auto" as it may result in not reproducible scenarios (we had bugs in CCI), but where in the upstream did you find those default values?
I searched in other package managers too and most of them don't manage those options. Only Gentoo and Ubunut I found doing some configuration:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enabled all features that are not blocked by external dependencies. I agree that it should instead match the project defaults. It was nice to see that they passed in CI at least, though.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
I did some changes over this PR, including:
|
Conan v1 pipeline ✔️All green in build 14 (
Conan v2 pipeline ✔️
All green in build 13 (
|
Requires, optionally
closes #19361