libfabric: migrate to Conan v2, add missing dependencies #18979

valgur · 2023-07-31T13:05:55Z

Requires, optionally

rdma-core: add new recipe #18978

closes #19361

stale · 2023-10-15T11:08:08Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

recipes/libfabric/all/conanfile.py

Co-authored-by: PerseoGI <perseog@jfrog.com>

uilianries · 2024-08-28T07:48:14Z

recipes/libfabric/all/conanfile.py

-        if self.options.get_safe('with_libnl') and not os.path.isdir(str(self.options.with_libnl)):
-            raise ConanInvalidConfiguration("Value of with_libnl must be an existing directory")
+        if self.settings.os == "Windows":
+            raise ConanInvalidConfiguration("libfabric is not available on Windows")


Suggested change

raise ConanInvalidConfiguration("libfabric is not available on Windows")

# FIXME: libfabric provides msbuild project files.

raise ConanInvalidConfiguration(f"{self.ref} Conan recipes is not supported on Windows. Contributions are welcome.")

The project provides msbuild files, but is not something to be done in this PR. Otherwise it will be too much.

uilianries · 2024-08-28T08:25:24Z

recipes/libfabric/all/conanfile.py

-        }
+        "shared": [True, False],
+        "fPIC": [True, False],
+        **{ p: ["yes", "no", "dl"] for p in _providers },


Suggested change

**{ p: ["yes", "no", "dl"] for p in _providers },

**{ p: [None, "ANY"] for p in _providers },

I would suggest using any in this case, as users may pass the path of the provider, not related to a loadable library (dl:path), it could be static as well.

--enable-bgq[=yes|no|auto|dl|PATH|dl:PATH]
Enable bgq provider [default=auto] (yes: enable bgq
provider; no: disable bgq provider; auto: enable bgq
provider if possible; dl: enable bgq provider and
build as a loadable library; PATH: enable bgq
provider and use bgq installed under PATH; dl:PATH:
enable bgq provider and build as a loadable library
and use bgq installed under PATH)

uilianries · 2024-08-28T08:36:59Z

recipes/libfabric/all/conanfile.py

+        "fPIC": True,
+        "cxi": "no",  # library not available on CCI
+        "dmabuf_peer_mem": "yes",
+        "efa": "yes",


I also dislike "auto" as it may result in not reproducible scenarios (we had bugs in CCI), but where in the upstream did you find those default values?

I searched in other package managers too and most of them don't manage those options. Only Gentoo and Ubunut I found doing some configuration:

https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-block/libfabric/libfabric-1.11.2-r2.ebuild#n43

https://git.launchpad.net/ubuntu/+source/libfabric/tree/debian/rules?h=ubuntu/jammy#n17

I enabled all features that are not blocked by external dependencies. I agree that it should instead match the project defaults. It was nice to see that they passed in CI at least, though.

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries · 2024-09-02T12:20:24Z

I did some changes over this PR, including:

Removed options that not supported in CCI: cxi, opx, psm2, psm3 and xpmem
Change option values to None, "ANY", as users can pass "path" and "dl:<path" for providers
Improved msvc configuration error message as the upstream make msbuild files available
Enabled verbs by default, it did not fail for me locally, using CCI containers

conan-center-bot · 2024-09-02T12:56:03Z

Conan v1 pipeline ✔️

All green in build 14 (3a9c8e60389a35ac18710e0754bf97515940af79):

libfabric/1.21.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (3a9c8e60389a35ac18710e0754bf97515940af79):

libfabric/1.21.0:
All packages built successfully! (All logs)

…cies * libfabric: migrate to Conan v2 * libfabric: explicitly disable providers that cannot be built by default * libfabric: add v1.18.1 * libfabric: opx also requires rdma-core * libfabric: add libatomic system dependency * libfabric: macOS does not support `shm` * libfabric: macOS does not support `sm2` * libfabric: fix libatomic system dep * libfabric: do not ignore libcxx for libatomic * libfabric: workaround for linter error * libfabric: fix typo * libfabric: add libatomic for both gcc and clang * libfabric: fix_apple_shared_install_name() * libfabric: bump to v1.21.0, drop v1.12.1, remove 'auto' options * libfabric: disable 'verbs' * libfabric: fix invalid default configurations on macOS * libfabric: fix a linter error * libfabric: fix a missing option error * libfabric: fix a linter error * libfabric: fix a minor recipe bug * libfabric: add VirtualRunEnv for Conan v1 * libfabric: use get_safe() Co-authored-by: PerseoGI <perseog@jfrog.com> * Improve Windows invalid config message Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use None ANY for providers Signed-off-by: Uilian Ries <uilianries@gmail.com> * Remove psm option Signed-off-by: Uilian Ries <uilianries@gmail.com> * Remove xpmem and cxi Signed-off-by: Uilian Ries <uilianries@gmail.com> * Improve verbs invalid configuration message Signed-off-by: Uilian Ries <uilianries@gmail.com> * Remove opx Signed-off-by: Uilian Ries <uilianries@gmail.com> * Disable bgq Signed-off-by: Uilian Ries <uilianries@gmail.com> * Enable verbs and disable others Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: PerseoGI <perseog@jfrog.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot added the Service Under Maintenance label Jul 31, 2023

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Jul 31, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 5, 2023

This comment has been minimized.

Sign in to view

stale bot added the stale label Oct 15, 2023

valgur mentioned this pull request Nov 8, 2023

Conan 2.0 migration: the final 100 #20992

Open

valgur added 3 commits December 14, 2023 13:27

libfabric: migrate to Conan v2

7e9e35a

libfabric: explicitly disable providers that cannot be built by default

140fb8f

libfabric: add v1.18.1

ed06eaa

valgur force-pushed the migrate/libfabric branch from 85eb3d4 to ed06eaa Compare December 14, 2023 12:48

conan-center-bot removed the stale label Dec 14, 2023

This comment has been minimized.

Sign in to view

libfabric: opx also requires rdma-core

e43822f

This comment has been minimized.

Sign in to view

libfabric: add libatomic system dependency

5ca9136

valgur force-pushed the migrate/libfabric branch from 7482e9d to 5ca9136 Compare December 14, 2023 18:09

conan-center-bot added the Unexpected Error label Dec 15, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label Dec 21, 2023

This comment has been minimized.

Sign in to view

libfabric: macOS does not support shm

7391f65

valgur force-pushed the migrate/libfabric branch from 38ae28b to 7391f65 Compare December 23, 2023 14:32

This comment has been minimized.

Sign in to view

libfabric: macOS does not support sm2

12b882a

valgur force-pushed the migrate/libfabric branch from b31db6a to 12b882a Compare December 25, 2023 15:31

jwillikers approved these changes Aug 23, 2024

View reviewed changes

perseoGI reviewed Aug 26, 2024

View reviewed changes

recipes/libfabric/all/conanfile.py Show resolved Hide resolved

perseoGI reviewed Aug 26, 2024

View reviewed changes

recipes/libfabric/all/conanfile.py Outdated Show resolved Hide resolved

libfabric: use get_safe()

f03c24c

Co-authored-by: PerseoGI <perseog@jfrog.com>

This comment has been minimized.

Sign in to view

perseoGI previously approved these changes Aug 27, 2024

View reviewed changes

jwillikers approved these changes Aug 27, 2024

View reviewed changes

uilianries self-assigned this Aug 28, 2024

uilianries reviewed Aug 28, 2024

View reviewed changes

conan-center-bot added the Service Under Maintenance label Aug 28, 2024

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Aug 31, 2024

This comment has been minimized.

Sign in to view

uilianries added 8 commits September 2, 2024 10:53

Improve Windows invalid config message

968f188

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Use None ANY for providers

c94472d

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Remove psm option

a1a6f44

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Remove xpmem and cxi

b210b15

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Improve verbs invalid configuration message

ea506a2

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Remove opx

d39284c

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Disable bgq

51accd6

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Enable verbs and disable others

3a9c8e6

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries dismissed perseoGI’s stale review via 3a9c8e6 September 2, 2024 12:16

uilianries requested a review from perseoGI September 2, 2024 13:07

uilianries approved these changes Sep 2, 2024

View reviewed changes

jwillikers approved these changes Sep 2, 2024

View reviewed changes

perseoGI approved these changes Sep 2, 2024

View reviewed changes

conan-center-bot merged commit badc062 into conan-io:master Sep 2, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libfabric: migrate to Conan v2, add missing dependencies #18979

libfabric: migrate to Conan v2, add missing dependencies #18979

valgur commented Jul 31, 2023 •

edited by uilianries

Loading

This comment has been minimized.

This comment has been minimized.

stale bot commented Oct 15, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Aug 28, 2024

uilianries Aug 28, 2024

uilianries Aug 28, 2024

valgur Aug 28, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

uilianries commented Sep 2, 2024

conan-center-bot commented Sep 2, 2024

	raise ConanInvalidConfiguration("libfabric is not available on Windows")
	# FIXME: libfabric provides msbuild project files.
	raise ConanInvalidConfiguration(f"{self.ref} Conan recipes is not supported on Windows. Contributions are welcome.")

	**{ p: ["yes", "no", "dl"] for p in _providers },
	**{ p: [None, "ANY"] for p in _providers },

libfabric: migrate to Conan v2, add missing dependencies #18979

libfabric: migrate to Conan v2, add missing dependencies #18979

Conversation

valgur commented Jul 31, 2023 • edited by uilianries Loading

This comment has been minimized.

This comment has been minimized.

stale bot commented Oct 15, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Aug 28, 2024

Choose a reason for hiding this comment

uilianries Aug 28, 2024

Choose a reason for hiding this comment

uilianries Aug 28, 2024

Choose a reason for hiding this comment

valgur Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

uilianries commented Sep 2, 2024

conan-center-bot commented Sep 2, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

valgur commented Jul 31, 2023 •

edited by uilianries

Loading

valgur Aug 28, 2024 •

edited

Loading