Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mold 2.0.0 #19152

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Add mold 2.0.0 #19152

merged 2 commits into from
Nov 14, 2023

Conversation

fschoenm
Copy link
Contributor

Specify library name and version: mold/2.0.0

Essentially a version bump. mold 2.0.0 has been relicensed from AGPL to MIT (see Release Notes for mold 2.0.0), which is why I moved the old all folder to 1.x.x and created a new all folder that essentially only changed the license attribute. I hope that's the correct approach.


@ghost
Copy link

ghost commented Aug 11, 2023

I detected other pull requests that are modifying mold/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@fschoenm
Copy link
Contributor Author

Can anybody advise how to solve the CI issue? Seems like some package is missing. In the #conan Slack channel I was told that somebody from the team has to run a build for missing packages?

@mgehre-amd
Copy link

I'd love to have mold 2.0 in conan. The error you are getting seems to be in mold/1.7.1, so I wonder whether you PR changes anything about that is being build?

@fschoenm
Copy link
Contributor Author

fschoenm commented Aug 31, 2023

@mgehre-amd IMO I didn't change anything there. On the slack channel somebody told me I have to wait for the team to help with that but I don't know what to do with this issue or how to get in contact.

@franramirez688 franramirez688 self-assigned this Aug 31, 2023
@valgur
Copy link
Contributor

valgur commented Aug 31, 2023

The onetbb issue is a recurrent one (#19229 (comment)) and @uilianries is looking into it, it seems.

The #18848 PR should help with any Conan v1 issues in the mold v1 recipe, once it gets merged.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Sep 25, 2023
3 tasks
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fschoenm Thank you for your contribution, good catch with the license change! Please, let's keep it simpler:

@conan-center-bot

This comment has been minimized.

@fschoenm
Copy link
Contributor Author

@uilianries Thanks for the pointer, I didn't know that is possible. Maybe could be added to the contribution documentation (or maybe I just didn't see it) :)

@uilianries
Copy link
Member

@fschoenm changing a recipe is something rare, but indeed it deserves be documented. I'll open a PR soon.

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Oct 26, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@fschoenm
Copy link
Contributor Author

Is there a problem with the CI system? It says something about an unexpected error.

@fschoenm
Copy link
Contributor Author

@uilianries Unfortunately, it still didn't work.

I saw that there's a onetbb package depending on hwloc/2.9.Z on conancenter:

fbd41063c30b49345892a94c8747c6efed28b489
  info
    settings
      arch: x86_64
      build_type: Release
      compiler: gcc
      compiler.cppstd: 17
      compiler.libcxx: libstdc++11
      compiler.version: 11
      os: Linux
    options
      shared: True
      tbbbind: True
      tbbmalloc: True
      tbbproxy: True
    requires
      hwloc/2.9.Z

But the build requires onetbb depending on hwloc/2.9.3:

onetbb/2021.3.0: WARN: Can't find a 'onetbb/2021.3.0' package binary 'd7a9f73b4f7a501a35ebea3234d4801bf5740350' for the configuration:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
shared=True
tbbbind=True
tbbmalloc=True
tbbproxy=True
[requires]
hwloc/2.9.3#30511a65bbe6044dab2139ab73cbbe2c:f651771e3392d8c689d4fdd4b39be363dfe184d3

I'm not really sure what it means. I think it has something to do with full_mode vs minor_mode but I'm unclear how these are determined.

@uilianries
Copy link
Member

There was problem related to the OneTBB and its supported package IDs, but I created a PR fixing it: #20786

I just started the PR again. Let's if it works now.

@conan-center-bot

This comment has been minimized.

@fschoenm
Copy link
Contributor Author

fschoenm commented Nov 1, 2023

@uilianries Sorry but that's no fix at all. It doesn't change the fact, that the onetbb package required for mold needs hwloc/2.9.3 instead of hwloc/2.9.Z.

There was problem related to the OneTBB and its supported package IDs, but I created a PR fixing it: #20786

I just started the PR again. Let's if it works now.

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 2, 2023

Here is a possible explanation: conan-io/conan#15040 (comment)

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 2, 2023

#20897 should avoid missing package id for this case. It may lead to other issues related to missing packages in downstream recipes.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 10, 2023

You have to wait a little bit after merge of a PR (not just 3 min), before new packages can be available.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 11, 2023
@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (f7687355988869fa765f8ab5f1403b445bb7f1e9):

  • mold/1.4.2:
    All packages built successfully! (All logs)

  • mold/2.0.0:
    All packages built successfully! (All logs)

  • mold/1.5.1:
    All packages built successfully! (All logs)

  • mold/1.8.0:
    All packages built successfully! (All logs)

  • mold/1.11.0:
    All packages built successfully! (All logs)

  • mold/1.7.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (f7687355988869fa765f8ab5f1403b445bb7f1e9):

  • mold/2.0.0:
    All packages built successfully! (All logs)

  • mold/1.4.2:
    All packages built successfully! (All logs)

  • mold/1.5.1:
    All packages built successfully! (All logs)

  • mold/1.7.1:
    All packages built successfully! (All logs)

  • mold/1.8.0:
    All packages built successfully! (All logs)

  • mold/1.11.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, asking @franramirez688 for an extra review.

@fschoenm
Copy link
Contributor Author

@uilianries Anything missing here?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit cac9079 into conan-io:master Nov 14, 2023
38 checks passed
Cogitri pushed a commit to dampsoft/conan-center-index that referenced this pull request Nov 27, 2023
* mold: add version 2.0.0

* Requires at least CMake 3.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants