Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onetbb] Use validate method for package compatibility #20786

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

uilianries
Copy link
Member

Specify library name and version: onetbb/2021.3.0

The PR #19152 is blocked because OneTBB is missing. The explanation is simple: We raise an invalid configuration when building OneTBB, but not when consuming, so there is no package, and will not be available ever.

That condition should be moved to validate() instead.

/cc @fschoenm


Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested a review from AbrilRBS October 27, 2023 07:09
@uilianries uilianries self-assigned this Oct 27, 2023
@uilianries uilianries mentioned this pull request Oct 27, 2023
3 tasks
@ghost
Copy link

ghost commented Oct 27, 2023

I detected other pull requests that are modifying onetbb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (a71caf4f1aa6a82b7574120c88c12ccd9e4afc82):

  • onetbb/2021.8.0:
    All packages built successfully! (All logs)

  • onetbb/2021.7.0:
    All packages built successfully! (All logs)

  • onetbb/2021.10.0:
    All packages built successfully! (All logs)

  • onetbb/2021.9.0:
    All packages built successfully! (All logs)

  • onetbb/2021.6.0:
    All packages built successfully! (All logs)

  • onetbb/2021.3.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (a71caf4f1aa6a82b7574120c88c12ccd9e4afc82):

  • onetbb/2021.10.0:
    All packages built successfully! (All logs)

  • onetbb/2021.9.0:
    All packages built successfully! (All logs)

  • onetbb/2021.6.0:
    All packages built successfully! (All logs)

  • onetbb/2021.8.0:
    All packages built successfully! (All logs)

  • onetbb/2021.3.0:
    All packages built successfully! (All logs)

  • onetbb/2021.7.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit f689061 into conan-io:master Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants