[OneTBB] Deprecate support for shared option #20912

uilianries · 2023-11-03T13:25:24Z

Specify library name and version: onetbb/2021.x

The OneTBB package uses shared=True by default because the upstream does not encourage of using is as a static library. The recipe still offers the option, but add a big warning or an InvalidConfiguration.

This PR proposes deprecating it not only because to follow upstream recommendation and avoid unexpected errors with static library, but also to remedy current missing dependencies error when consuming OneTBB.

So only shared/dynamic libraries will be provided.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

Signed-off-by: Uilian Ries <uilianries@gmail.com>

ghost · 2023-11-03T13:30:02Z

I detected other pull requests that are modifying onetbb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

SpaceIm · 2023-11-03T13:31:32Z

Is it wise to deprecate shared option like this? Because c3i will force shared option anyway, and it will trick package_type. There is #20897 already.

conan-center-bot · 2023-11-03T13:39:40Z

Conan v1 pipeline ❌

Failure in build 1 (9b9cd939601031876dfef2523d2c449f4e0e8094):

onetbb/2021.10.0:
Didn't run or was cancelled before finishing
onetbb/2021.9.0:
Didn't run or was cancelled before finishing

onetbb/2021.8.0:
CI failed to create some packages (All logs)

Logs for packageID 31d1d65f633f536505b34b0be8348a60835da2a1:

[settings]
arch=x86_64
build_type=Debug
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=7
os=Linux
[options]
onetbb:shared=True

[...]
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/concurrent_priority_queue.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/task.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/parallel_invoke.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/concurrent_queue.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/task_group.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/version.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/concurrent_map.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/queuing_mutex.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/flow_graph_abstractions.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/tbb_allocator.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/blocked_range3d.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/parallel_sort.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/parallel_scan.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/concurrent_set.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/queuing_rw_mutex.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/partitioner.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/parallel_reduce.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/include/tbb/null_rw_mutex.h
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/cmake/TBB/TBBTargets.cmake
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/cmake/TBB/TBBTargets-debug.cmake
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/cmake/TBB/TBBConfig.cmake
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/cmake/TBB/TBBConfigVersion.cmake
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/share/doc/TBB/README.md
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/libtbb_debug.a
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/pkgconfig/tbb.pc
-- Installing: /home/conan/w/prod-v1/bsr/42304/bedcc/.conan/data/onetbb/2021.8.0/_/_/package/31d1d65f633f536505b34b0be8348a60835da2a1/lib/libtbbmalloc_debug.a
onetbb/2021.8.0: Copied 1 '.txt' file: LICENSE.txt
[HOOK - conan-center.py] post_package(): [PACKAGE LICENSE (KB-H012)] OK
[HOOK - conan-center.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] OK
[HOOK - conan-center.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
[HOOK - conan-center.py] post_package(): [STATIC ARTIFACTS (KB-H074)] OK
[HOOK - conan-center.py] post_package(): [EITHER STATIC OR SHARED OF EACH LIB (KB-H076)] OK
[HOOK - conan-center.py] post_package(): [PC-FILES (KB-H020)] OK
[HOOK - conan-center.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
[HOOK - conan-center.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
[HOOK - conan-center.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
[HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
[HOOK - conan-center.py] post_package(): [SHORT_PATHS USAGE (KB-H066)] OK
[HOOK - conan-center.py] post_package(): [MISSING SYSTEM LIBS (KB-H043)] OK
[HOOK - conan-center.py] post_package(): [APPLE RELOCATABLE SHARED LIBS (KB-H077)] OK
CMake Warning at CMakeLists.txt:116 (message):
  You are building oneTBB as a static library.  This is highly discouraged
  and such configuration is not supported.  Consider building a dynamic
  library to avoid unforeseen issues.


onetbb/2021.8.0: WARN: onetbb/2021.8.0:shared option is deprecated because is highly discouraged: https://github.com/oneapi-src/oneTBB/issues/920
onetbb/2021.8.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
[HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared=True' option did not contain any shared artifact (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H015-SHARED-ARTIFACTS) 
ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output

onetbb/2021.7.0:
Didn't run or was cancelled before finishing
onetbb/2021.6.0:
Didn't run or was cancelled before finishing
onetbb/2021.3.0:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (9b9cd939601031876dfef2523d2c449f4e0e8094):

onetbb/2021.9.0:
Didn't run or was cancelled before finishing
onetbb/2021.10.0:
Didn't run or was cancelled before finishing
onetbb/2021.7.0:
Didn't run or was cancelled before finishing

onetbb/2021.8.0:
CI failed to create some packages (All logs)

Logs for packageID 2df4dc92a375271af21b0898f7a46c7f7ade1a71:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=True

[...]
onetbb/2021.8.0 (test package): Writing generators to /home/conan/w/prod-v2/bsr/cci-d6b815e8/recipes/onetbb/all/test_package/build/gcc-11-x86_64-17-release/generators
onetbb/2021.8.0 (test package): Generator 'CMakeDeps' calling 'generate()'
onetbb/2021.8.0 (test package): Generator 'VirtualRunEnv' calling 'generate()'
onetbb/2021.8.0 (test package): Generator 'CMakeToolchain' calling 'generate()'
onetbb/2021.8.0 (test package): CMakeToolchain generated: conan_toolchain.cmake
onetbb/2021.8.0 (test package): CMakeToolchain generated: CMakePresets.json
onetbb/2021.8.0 (test package): CMakeToolchain generated: ../../../CMakeUserPresets.json
onetbb/2021.8.0 (test package): Generating aggregated env files
onetbb/2021.8.0 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']

======== Testing the package: Building ========
onetbb/2021.8.0 (test package): Calling build()
onetbb/2021.8.0 (test package): Running CMake.configure()
onetbb/2021.8.0 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v2/bsr/cci-d6b815e8/recipes/onetbb/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod-v2/bsr/cci-d6b815e8/recipes/onetbb/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v2/bsr/cci-d6b815e8/recipes/onetbb/all/test_package"
-- Using Conan toolchain: /home/conan/w/prod-v2/bsr/cci-d6b815e8/recipes/onetbb/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 17 with extensions OFF
-- The CXX compiler identification is GNU 11.1.0
-- Check for working CXX compiler: /usr/local/bin/c++
-- Check for working CXX compiler: /usr/local/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Component target declared 'TBB::tbb'
-- Conan: Component target declared 'TBB::tbbmalloc'
-- Conan: Component target declared 'TBB::tbbmalloc_proxy'
-- Conan: Target declared 'onetbb::onetbb'
CMake Error at build/gcc-11-x86_64-17-release/generators/cmakedeps_macros.cmake:67 (message):
  Library 'tbbmalloc_proxy' not found in package.  If 'tbbmalloc_proxy' is a
  system library, declare it with 'cpp_info.system_libs' property
Call Stack (most recent call first):
  build/gcc-11-x86_64-17-release/generators/TBB-Target-release.cmake:24 (conan_package_library_targets)
  build/gcc-11-x86_64-17-release/generators/TBBTargets.cmake:26 (include)
  build/gcc-11-x86_64-17-release/generators/TBBConfig.cmake:16 (include)
  CMakeLists.txt:4 (find_package)


-- Configuring incomplete, errors occurred!
See also "/home/conan/w/prod-v2/bsr/cci-d6b815e8/recipes/onetbb/all/test_package/build/gcc-11-x86_64-17-release/CMakeFiles/CMakeOutput.log".

*********************************************************
Recipe 'onetbb/2021.8.0 (test package)' cannot build its binary
It is possible that this recipe is not Conan 2.0 ready
If the recipe comes from ConanCenter, report it at https://github.com/conan-io/conan-center-index/issues
If it is your recipe, check if it is updated to 2.0
*********************************************************

ERROR: onetbb/2021.8.0 (test package): Error in build() method, line 20
	cmake.configure()
	ConanException: Error 1 while executing

onetbb/2021.3.0:
Didn't run or was cancelled before finishing
onetbb/2021.6.0:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

uilianries · 2023-11-03T13:43:37Z

@SpaceIm sorry, I didn't see your PR. Closing this one in favor of #20897

uilianries added 2 commits November 3, 2023 14:20

Remove support for shared option

a01c0fa

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Better message

9b9cd93

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries requested a review from danimtb November 3, 2023 13:25

This was referenced Nov 3, 2023

[service] Potentially conflicting recipes #3571

Closed

onetbb: remove shared option + fix tbbmaloc & tbbproxy logic #20897

Merged

add onetbb/2021.11.0 #20813

Closed

Add onetbb/2021.5.0 needed by cctag/1.0.3 #18714

Closed

conan-center-bot added the Failed label Nov 3, 2023

uilianries closed this Nov 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OneTBB] Deprecate support for shared option #20912

[OneTBB] Deprecate support for shared option #20912

uilianries commented Nov 3, 2023

ghost commented Nov 3, 2023

SpaceIm commented Nov 3, 2023 •

edited

Loading

conan-center-bot commented Nov 3, 2023

uilianries commented Nov 3, 2023

[OneTBB] Deprecate support for shared option #20912

[OneTBB] Deprecate support for shared option #20912

Conversation

uilianries commented Nov 3, 2023

ghost commented Nov 3, 2023

SpaceIm commented Nov 3, 2023 • edited Loading

conan-center-bot commented Nov 3, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

uilianries commented Nov 3, 2023

SpaceIm commented Nov 3, 2023 •

edited

Loading