-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add onetbb/2021.11.0 #20813
add onetbb/2021.11.0 #20813
Conversation
This comment has been minimized.
This comment has been minimized.
recipes/onetbb/all/conandata.yml
Outdated
@@ -1,4 +1,7 @@ | |||
sources: | |||
"2021.11.0-rc1": | |||
url: "https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2021.11.0-rc1.tar.gz" | |||
sha256: "ff0fbbf6ffcb0e81beacfddf5ef5b1eab0bb16f4e4c4bae517ed1f4e3b269b47" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, fix this condition:
conan-center-index/recipes/onetbb/all/conanfile.py
Lines 49 to 51 in 42ff589
@property | |
def _tbbbind_supported(self): | |
return Version(self.version) >= "2021.1.1" and not self.settings.os == "Macos" |
because tbbbind is available since 2021.11.0 (see uxlfoundation/oneTBB#1132)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have Mac to verify that, so I will just apply it and lets see the CI output
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ilya-lavrenov @SSE4 @uilianries |
why should we add RC to CCI? |
AFAIR it's not prohibited. sometimes it can takes literally months for software to stabilize from RC to release, and people cannot wait. |
@AndreyMlashkin do you really need this RC version? We try to avoid alpha, beta and rc, because they will be "deprecated" as soon as we have the final release. The OneTBB is an active project, so it should not take so long. |
Okey, it's a valid point. I would leave this PR open till they have it released |
New release is available https://github.com/oneapi-src/oneTBB/releases/tag/v2021.11.0 |
will this PR be updated for new release? |
This comment has been minimized.
This comment has been minimized.
use release, not release candidate Could you update PR title accordingly please? |
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Recipe needs to be updated because hwloc has been converted from "library" to "shared-library" 2 weeks ago |
@AndreyMlashkin Thank you for your effort in this package update. The PR #23651 merged the version 2021.12.0. I'm closing this PR because it contains conflicts and an older version.
Please, feel free to re-open in case you really this specific version. |
Specify library name and version: onetbb/2021.11.0-rc1