Add boostdep/1.75.0 recipe #2096

madebr · 2020-06-30T17:00:32Z

Specify library name and version: boostdep/1.73.0

Tool to generate dependency information of boost
@SSE4

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-06-30T17:05:07Z

Some configurations of 'boostdep/1.73.0' failed in build 1 (b772cd60e77b86e400b2e2885c176eab52844ee2):

Linux x86_64, Release, gcc 5, libstdc++
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [PACKAGE LICENSE (KB-H012)] No 'licenses' folder found in package: /home/conan/workspace/onan-center-pull-request_PR-2096/1/pr_2096_1_0_0/.conan/data/boostdep/1.73.0/_/_/package/90ee443cae5dd5c1b4861766ac14dc6fae231a92 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H012)
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-06-30T17:32:30Z

Some configurations of 'boostdep/1.73.0' failed in build 2 (44678ebddf5864108ed2ee6b4924a3350f753708):

Windows x86_64, Debug, Visual Studio 14, MTd
Access to all the logs

recipes/boostdep/all/conanfile.py

madebr · 2020-06-30T17:38:06Z

This is a executable only recipe,
so it should only be built in Release/MT runtime configuration, for one compiler version

conan-center-bot · 2020-06-30T17:42:34Z

Some configurations of 'boostdep/1.73.0' failed in build 3 (d7bee49cb7e905e1858c29235dbc4ee0be570675):

Windows x86_64, Debug, Visual Studio 14, MTd
Access to all the logs

conan-center-bot · 2020-06-30T17:43:14Z

Failure in build 4 (020e62d162c22d5be40a99af4387e76803db6678):
boostdep/1.73.0:

Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++
Unexpected error happened:

ERROR: 'ConanInfo' object has no attribute 'settings'

conan-center-bot · 2020-06-30T17:52:30Z

Some configurations of 'boostdep/1.73.0' failed in build 5 (186224be711914b9573aeff599b0f765448f00d1):

Windows x86_64, Release, Visual Studio 15, MT
Access to all the logs

conan-center-bot · 2020-07-01T02:53:54Z

Some configurations of 'boostdep/1.73.0' failed in build 6 (92fba5c4bfc9e38dc041c40895c295c67da70469):

Windows x86_64, Release, Visual Studio 15, MT
Access to all the logs

prince-chrismc · 2020-07-01T13:56:08Z

Instead of producing the binary, could we package the dependency yaml? The package info would be accessible by the boost project

boostdeps -> dependency.yml -> boost

madebr · 2020-07-01T14:30:51Z

@prince-chrismc

boostdeps -> dependency.yml -> boost

That's what I am doing in #2097 (see its recipes/boost/all/rebuild-dependencies.py )
I thought it was useful to create a boostdep package for this purpose.

prince-chrismc · 2020-07-01T16:13:40Z

Yes I saw that, I am suggesting moving it here! And the dependencies-{version}.yml is output from this recipe

madebr · 2020-07-01T17:04:59Z

Yes I saw that, I am suggesting moving it here! And the dependencies-{version}.yml is output from this recipe

This has plusses and minuses.

plusses

This boostdep recipe has no other purpose then providing the dependency tree of boost, so why not make it more useful.
The dependency generator script is tested on CI and has less chance to bitrot
Run the generation of the dependency files on CI => more assurance that the generated files are not altered manually

minusses

The boost recipe then would have a dependency on boostdep. But this recipe requires boost. So a dependency cycle is created.
Also, we'd still want to test the generated dependency files. So a rebuild of boost is required to test.
Isn't it weird to require a rebuild of boostdep to have a change in behavior of boost components?

I prefer the current method of having a separate boostdep recipe and running
python3 rebuild-dependencies.py -A manually inside the recipes/boost/all directory.

But let's hear for other opinions.

prince-chrismc · 2020-07-01T19:55:12Z

So a dependency cycle is created.

That sounds painful!

So a rebuild of boost is required to test.

And there's the pain.

This: find_package(Boost) in boostdep is a little frustrating.

I noticed the requires but I was under the impression the tool was more standalone. Now looking at it again, I see the tool needs a copy of boost to build, which explains you approach.

madebr · 2020-07-20T15:38:43Z

@uilianries @danimtb @SSE4 @jgsogo
Can I get some reviews?

uilianries · 2020-07-20T19:47:47Z

recipes/boostdep/all/conanfile.py

+        return "build_subfolder"
+
+    def requirements(self):
+        self.requires("boost/1.70.0")


Suggested change

self.requires("boost/1.70.0")

self.requires("boost/1.73.0")

boostdep is 1.73, but its requirement is 1.70 ?

boostdep is not really using latest boost features.
I lowered the version to enable bootstrapping for a newer boost version,
but I think it does not matter as you can always override the version.

Probably users will override it. Aligning the version will avoid the warning message related to version overriding.

Or that was the reason: #2096 (comment)
😆

🤦 let's revert and keep 1.70

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-07-20T20:49:19Z

Some configurations of 'boostdep/1.73.0' failed in build 7 (374e7502d9ab4e26e0645017f63297230f1b3249):

Windows x86_64, Release, Visual Studio 15, MT
Access to all the logs

prince-chrismc · 2020-11-23T13:41:50Z

I guess you'll have to first add the boost pr adding component support.
Then I will be able to use these components here.

is this still blocked by #2097

madebr · 2020-11-23T14:54:02Z

I guess you'll have to first add the boost pr adding component support.
Then I will be able to use these components here.

is this still blocked by #2097

No because it doesn't use cmake_find_package.
This makes this recipe only work with cmake versions that support the declared boost version though.

When #2097 gets added, then this can add cmake_find_package.

boost and boostdep won't become a dependency cycle, as it's the dependency generator script of boost that requires boostdep, not boost itself.

conan-center-bot · 2020-12-12T13:15:19Z

All green in build 13 (1264ab722ab56ac8a7b610e99d5152905d120478)! 😊

boostdep/1.74.0: Generated 3 packages (+ 3 invalid config from build()). All logs here

jgsogo · 2020-12-14T08:14:37Z

recipes/boostdep/all/conanfile.py

+        if self.settings.build_type != "Release":
+            raise ConanInvalidConfiguration("Only Release built_type supported")


Suggested change

if self.settings.build_type != "Release":

raise ConanInvalidConfiguration("Only Release built_type supported")

Is there a reason to remove Release builds? We finally decided to keep the Debug builds just in case someone wants to debug those binaries.

No this was done just for reducing the number of builds.
I will modify the recipe to make it look like other installer recipes.

conan-center-bot · 2020-12-14T21:26:47Z

All green in build 14 (f7f8440bae81d97606ecad23712ce917d6fdb98e)! 😊

boostdep/1.75.0: Generated 6 packages. All logs here

recipes/boostdep/all/conanfile.py

conan-center-bot · 2021-01-04T17:18:00Z

All green in build 15 (ce36973f57b958564a87c570e39d3acb776eadb5)! 😊

boostdep/1.75.0: Generated 6 packages. All logs here

madebr · 2021-01-10T00:20:23Z

Has anyone tried to run the rebuild-dependencies.py script of boost btw?

Add boostdep/1.73.0 recipe

b772cd6

conan-center-bot added the Failed label Jun 30, 2020

boostdep: download + install boost license

44678eb

madebr commented Jun 30, 2020

View reviewed changes

recipes/boostdep/all/conanfile.py Outdated Show resolved Hide resolved

boostdep: use requires instead of build_requires for boost

d7bee49

boostdep: only allow MT+Release and discard compiler.version

020e62d

boostdep: remove settings.compiler in package_id

186224b

boostdep: lower required boost version

92fba5c

boostdep: even lower required boost version

ebf711a

madebr mentioned this pull request Jul 1, 2020

Add component support to boost using boostdep #2097

Merged

7 tasks

uilianries reviewed Jul 20, 2020

View reviewed changes

boostdep: bump required boost version

374e750

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries previously approved these changes Jul 20, 2020

View reviewed changes

uilianries requested review from danimtb and SSE4 July 20, 2020 20:49

madebr mentioned this pull request Jul 21, 2020

Refactor boost/test_package to make it pass on Linux #2205

Merged

4 tasks

prince-chrismc previously approved these changes Nov 23, 2020

View reviewed changes

boostdep: bump boost dependency to 1.74.0

1264ab7

madebr dismissed stale reviews from prince-chrismc and SSE4 via 1264ab7 December 12, 2020 13:07

prince-chrismc previously approved these changes Dec 12, 2020

View reviewed changes

jgsogo reviewed Dec 14, 2020

View reviewed changes

madebr added 2 commits December 14, 2020 22:17

boostdep: bump to boostdep/1.75.0

ccd3a62

boostdep: don't raise Error on non-release builds

f7f8440

madebr dismissed prince-chrismc’s stale review via f7f8440 December 14, 2020 21:19

prince-chrismc previously approved these changes Dec 14, 2020

View reviewed changes

madebr changed the title ~~Add boostdep/1.73.0 recipe~~ Add boostdep/1.75.0 recipe Dec 14, 2020

madebr mentioned this pull request Dec 15, 2020

[boost] Add nowide lib #3894

Closed

4 tasks

github-actions bot mentioned this pull request Dec 26, 2020

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

mathbunnyru suggested changes Jan 4, 2021

View reviewed changes

recipes/boostdep/all/conanfile.py Outdated Show resolved Hide resolved

boostdep: bump version of boost dependency

ce36973

madebr dismissed prince-chrismc’s stale review via ce36973 January 4, 2021 17:09

prince-chrismc approved these changes Jan 4, 2021

View reviewed changes

mathbunnyru approved these changes Jan 4, 2021

View reviewed changes

SSE4 approved these changes Jan 7, 2021

View reviewed changes

SpaceIm approved these changes Jan 9, 2021

View reviewed changes

conan-center-bot merged commit 1300210 into conan-io:master Jan 9, 2021

madebr deleted the boostdep_recipe branch January 10, 2021 00:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add boostdep/1.75.0 recipe #2096

Add boostdep/1.75.0 recipe #2096

madebr commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

madebr commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jul 1, 2020

prince-chrismc commented Jul 1, 2020

madebr commented Jul 1, 2020

prince-chrismc commented Jul 1, 2020

madebr commented Jul 1, 2020

prince-chrismc commented Jul 1, 2020

madebr commented Jul 20, 2020

uilianries Jul 20, 2020

madebr Jul 20, 2020

uilianries Jul 20, 2020

madebr Jul 20, 2020

uilianries Jul 21, 2020

conan-center-bot commented Jul 20, 2020

prince-chrismc commented Nov 23, 2020

madebr commented Nov 23, 2020 •

edited

Loading

conan-center-bot commented Dec 12, 2020

jgsogo Dec 14, 2020

madebr Dec 14, 2020 •

edited

Loading

conan-center-bot commented Dec 14, 2020

conan-center-bot commented Jan 4, 2021

madebr commented Jan 10, 2021

		if self.settings.build_type != "Release":
		raise ConanInvalidConfiguration("Only Release built_type supported")

Add boostdep/1.75.0 recipe #2096

Add boostdep/1.75.0 recipe #2096

Conversation

madebr commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

madebr commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jul 1, 2020

prince-chrismc commented Jul 1, 2020

madebr commented Jul 1, 2020

prince-chrismc commented Jul 1, 2020

madebr commented Jul 1, 2020

prince-chrismc commented Jul 1, 2020

madebr commented Jul 20, 2020

uilianries Jul 20, 2020

Choose a reason for hiding this comment

madebr Jul 20, 2020

Choose a reason for hiding this comment

uilianries Jul 20, 2020

Choose a reason for hiding this comment

madebr Jul 20, 2020

Choose a reason for hiding this comment

uilianries Jul 21, 2020

Choose a reason for hiding this comment

conan-center-bot commented Jul 20, 2020

prince-chrismc commented Nov 23, 2020

madebr commented Nov 23, 2020 • edited Loading

conan-center-bot commented Dec 12, 2020

jgsogo Dec 14, 2020

Choose a reason for hiding this comment

madebr Dec 14, 2020 • edited Loading

Choose a reason for hiding this comment

conan-center-bot commented Dec 14, 2020

conan-center-bot commented Jan 4, 2021

madebr commented Jan 10, 2021

madebr commented Nov 23, 2020 •

edited

Loading

madebr Dec 14, 2020 •

edited

Loading