cpython: migrate to Conan v2 #20960
Closed
cpython: migrate to Conan v2 #20960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # recipes/cpython/all/conanfile.py
|
I detected other pull requests that are modifying cpython/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Nov 6, 2023
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ec99e2ecpython/3.10.0@#12fc42bfe6cf476f1be0b04b14ddb687 |
|
It's very hacky, but I have the linking working. Somehow the linked libraries aren't getting passed to the makefile, so I have it done very manually for the time being: if self.options.get_safe("with_curses", False):
# FIXME: this will link to ALL libraries of ncurses. Only need to link to ncurses(w) (+ eventually tinfo)
ncurses_info = self.dependencies["ncurses"].cpp_info.components["libcurses"]
tinfo_info = self.dependencies["ncurses"].cpp_info.components["tinfo"]
libs = []
for dep in (ncurses_info, tinfo_info):
libs += dep.libs
libs += dep.system_libs
replace_in_file(self, os.path.join(self.source_folder, "setup.py"),
"curses_libs = ",
f"curses_libs = {libs} #")
if self._supports_modules:
openssl_includes = set()
openssl_libdirs = set()
openssl_libs = []
ssl_info = self.dependencies["openssl"].cpp_info.components["ssl"]
crypto_info = self.dependencies["openssl"].cpp_info.components["crypto"]
zlib_info = self.dependencies["zlib"].cpp_info
# FIXME: collect using some conan util (https://github.com/conan-io/conan/issues/7656)
for dep in (ssl_info, crypto_info, zlib_info):
openssl_includes.update(dep.includedirs)
openssl_libdirs.update(dep.libdirs)
openssl_libs += dep.libs
replace_in_file(self, os.path.join(self.source_folder, "setup.py"),
"openssl_includes = ",
f"openssl_includes = {list(openssl_includes)} #")
replace_in_file(self, os.path.join(self.source_folder, "setup.py"),
"openssl_libdirs = ",
f"openssl_libdirs = {list(openssl_libdirs)} #")
replace_in_file(self, os.path.join(self.source_folder, "setup.py"),
"openssl_libs = ",
f"openssl_libs = {openssl_libs} #") |
This comment has been minimized.
This comment has been minimized.
valgur
force-pushed
the
migrate/cpython
branch
from
938ca4f to
51a3e11
Compare
Conan v1 pipeline ❌Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
ghost
mentioned this pull request
3 tasks
ghost
mentioned this pull request
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.