CPython: Update deps (1.x only) #21426

Ahajha · 2023-11-27T20:32:05Z

Specify library name and version: cpython/all

Since I was doing a small PR anyways, I wanted to add some of the simple Conan 2.0 migration steps to ease the diff in future PRs.

Current min version is set to 1.53.0, I don't know if the current version actually needs 1.53.0, probably around 1.51, but it will need to be 1.53.0 eventually anyways.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

ghost · 2023-11-27T20:37:09Z

I detected other pull requests that are modifying cpython/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Ahajha · 2023-11-27T20:38:17Z

@RubenRBS :)

AbrilRBS

Thanks! Now that the ncruses recipe has been merged, we can finally focus on this PR :)

I have only 1 question about the usage of the force traitm otherwise looks good!

AbrilRBS · 2023-12-02T16:06:39Z

recipes/cpython/all/conanfile.py

-                self.requires("libuuid/1.0.3")
-            self.requires("libxcrypt/4.4.25")
+            if not is_apple_os(self):
+                self.requires("util-linux-libuuid/2.39.2", force=True)


Checking the PR now before merging, why is force needed here?

It's getting a version conflict with another dependency that uses util-linux-libuuid, in 2.x this doesn't seem to force the version? Is there a better way to do this?

@Ahajha which dependency is it conflicting with? I can't see anything in the logs - perhaps you need to update your local cache?

The normal resolution to this kind of issue is to bump the util-linux-libuuid version on the other dependency so that both are at the most recent version.

Ah, looks like it was a stale cache. It came from fontconfig, which comes from tk. I'll remove it.

github-actions · 2023-12-02T16:23:00Z

Hooks produced the following warnings for commit 30a42b0

cpython/2.7.18@#3da44cec5327d6a00056a7a2e12efb8d

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/python2.7/lib-dynload/nis.so' links to system library 'nsl' but it is not in cpp_info.system_libs.

Ahajha · 2023-12-02T20:02:07Z

I see CPython 2.x is failing, I'll try briefly to get it working again but I don't think it's worth too much effort currently.

AbrilRBS · 2023-12-02T21:42:01Z

We can merge this as-is on our end, no worries about that, and work on v2 compat at a later point :)

Ahajha · 2023-12-02T22:41:46Z

We can merge this as-is on our end, no worries about that, and work on v2 compat at a later point :)

I mean CPython 2.7.18, not Conan 2 :) I'll try briefly to see if I can find the cause, if not, I believe there was separate discussion about dropping support for it, at the very least it's low priority. It's also causing other packages to not be built, which I imagine we want.

Edit: Seems to be an issue when the package is actually downloaded, rather than a CPython 2.x issue. I'm guessing this test was added since the package was created last, it seems that there's a lot of hard-coding to paths that's happening. I'll take this into account in the 2.0 migration. Until then, review away :)

conan-center-bot · 2023-12-05T02:17:56Z

Conan v1 pipeline ❌

Failure in build 5 (4cb4b61b790eaeead6731f19d8f95e23321bab0d):

cpython/3.10.0:
Didn't run or was cancelled before finishing
cpython/3.9.7:
Didn't run or was cancelled before finishing

cpython/2.7.18:
CI failed to create some packages (All logs)

Logs for packageID 1cee7b23852b4ccf21b525d7fdf720d9e3b615d1:

[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=13.0
os=Macos
[options]
cpython:shared=False

[...]
		exit 1 ; \
	fi
running build
running build_ext
warning: openssl 0x00000000 is too old for _hashlib
building dbm using ndbm
cpython/2.7.18: 
configure: WARNING:

  By default, distutils will build C++ extension modules with "c++".
  If this is not intended, then set CXX on the configure command line.
  
source_subfolder/Python/random.c:177:1: warning: unused function 'dev_urandom_noraise' [-Wunused-function]
dev_urandom_noraise(unsigned char *buffer, Py_ssize_t size)
^
source_subfolder/Python/random.c:208:1: warning: unused function 'dev_urandom_python' [-Wunused-function]
dev_urandom_python(char *buffer, Py_ssize_t size)
^
source_subfolder/Python/random.c:300:1: warning: unused function 'dev_urandom_close' [-Wunused-function]
dev_urandom_close(void)
^
3 warnings generated.
source_subfolder/Modules/getpath.c:410:50: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'uint32_t *' (aka 'unsigned int *') [-Wincompatible-pointer-types]
     else if(0 == _NSGetExecutablePath(progpath, &nsexeclength) && progpath[0] == SEP)
                                                 ^~~~~~~~~~~~~
/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/mach-o/dyld.h:98:54: note: passing argument to parameter 'bufsize' here
extern int _NSGetExecutablePath(char* buf, uint32_t* bufsize)                 __OSX_AVAILABLE_STARTING(__MAC_10_2, __IPHONE_2_0);
                                                     ^
1 warning generated.
source_subfolder/Modules/posixmodule.c:363:13: warning: result of comparison of constant 9223372036854775807 with expression of type 'uid_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare]
    if (uid <= LONG_MAX)
        ~~~ ^  ~~~~~~~~
source_subfolder/Modules/posixmodule.c:371:13: warning: result of comparison of constant 9223372036854775807 with expression of type 'gid_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare]
    if (gid <= LONG_MAX)
        ~~~ ^  ~~~~~~~~
2 warnings generated.
/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpython2.7.a(pymath.o) has no symbols
/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpython2.7.a(pymath.o) has no symbols
/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpython2.7.a(pymath.o) has no symbols
/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libpython2.7.a(pymath.o) has no symbols
error: [Errno 2] No such file or directory: '/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/ffi/ffi.h'
make: *** [sharedmods] Error 1
WARN: openssl/3.2.0: requirement zlib/[>=1.2.11 <2] overridden by cpython/2.7.18 to zlib/1.3 
WARN: tcl/8.6.10: requirement zlib/[>=1.2.11 <2] overridden by tk/8.6.10 to zlib/1.3 
cpython/2.7.18: WARN: **** The 'AutoToolsBuildEnvironment' helper is deprecated. Please update your code and remove it. ****
cpython/2.7.18: ERROR: Package '1cee7b23852b4ccf21b525d7fdf720d9e3b615d1' build failed
cpython/2.7.18: WARN: Build folder /Users/jenkins/w/prod-v1/bsr@2/66853/fecbe/.conan/data/cpython/2.7.18/_/_/build/1cee7b23852b4ccf21b525d7fdf720d9e3b615d1
ERROR: cpython/2.7.18: Error in build() method, line 435
	autotools.make()
	ConanException: Error 2 while executing make -j4

cpython/3.8.12:
Didn't run or was cancelled before finishing
cpython/3.7.12:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 5 (4cb4b61b790eaeead6731f19d8f95e23321bab0d):

cpython/3.8.12:
Error running command conan export --name cpython --version 3.8.12 recipes/cpython/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, MSBuild, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cpython/3.10.0:
Error running command conan export --name cpython --version 3.10.0 recipes/cpython/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, MSBuild, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cpython/3.9.7:
Error running command conan export --name cpython --version 3.9.7 recipes/cpython/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, MSBuild, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cpython/3.7.12:
Error running command conan export --name cpython --version 3.7.12 recipes/cpython/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, MSBuild, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cpython/2.7.18:
Error running command conan export --name cpython --version 2.7.18 recipes/cpython/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-21426/recipes/cpython/all/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment, MSBuild, tools
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Ahajha · 2024-02-06T05:09:23Z

Closing this in favor of #21387

Ahajha added 2 commits November 27, 2023 14:30

Update dependencies

7ae897e

Misc updates to conan imports

422d471

Ahajha mentioned this pull request Nov 27, 2023

[bug] cpython/3.10.0 unable to install due to conflict in libuuid #21501

Closed

ghost mentioned this pull request Nov 27, 2023

[service] Potentially conflicting recipes #3571

Closed

This was referenced Nov 27, 2023

CPython: Conan 2.0 #21387

Merged

cpython: migrate to Conan v2 #20960

Closed

conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Nov 27, 2023

This comment has been minimized.

Sign in to view

AbrilRBS self-assigned this Nov 27, 2023

Merge branch 'master' into update-cpython-deps

c932045

This comment has been minimized.

Sign in to view

Ahajha mentioned this pull request Nov 30, 2023

[cpython] Use util-linux-libuuid instead of deprecated libuuid #18558

Closed

3 tasks

Merge branch 'master' into update-cpython-deps

30a42b0

AbrilRBS reviewed Dec 2, 2023

View reviewed changes

conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Dec 2, 2023

This comment has been minimized.

Sign in to view

Ahajha changed the title ~~Update cpython deps (1.x only)~~ CPython: Update deps (1.x only) Dec 2, 2023

This comment has been minimized.

Sign in to view

Remove force=True

4cb4b61

ghost mentioned this pull request Jan 30, 2024

CPython: Condense patching, update patch versions, and add 3.11/3.12 #22599

Merged

3 tasks

Ahajha closed this Feb 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CPython: Update deps (1.x only) #21426

CPython: Update deps (1.x only) #21426

Ahajha commented Nov 27, 2023 •

edited

Loading

ghost commented Nov 27, 2023

Ahajha commented Nov 27, 2023

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

AbrilRBS Dec 2, 2023

Ahajha Dec 2, 2023

samuel-emrys Dec 4, 2023

Ahajha Dec 5, 2023

This comment has been minimized.

github-actions bot commented Dec 2, 2023

Ahajha commented Dec 2, 2023

AbrilRBS commented Dec 2, 2023

Ahajha commented Dec 2, 2023 •

edited

Loading

This comment has been minimized.

conan-center-bot commented Dec 5, 2023

Ahajha commented Feb 6, 2024

CPython: Update deps (1.x only) #21426

CPython: Update deps (1.x only) #21426

Conversation

Ahajha commented Nov 27, 2023 • edited Loading

ghost commented Nov 27, 2023

Ahajha commented Nov 27, 2023

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Dec 2, 2023

Choose a reason for hiding this comment

Ahajha Dec 2, 2023

Choose a reason for hiding this comment

samuel-emrys Dec 4, 2023

Choose a reason for hiding this comment

Ahajha Dec 5, 2023

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Dec 2, 2023

Ahajha commented Dec 2, 2023

AbrilRBS commented Dec 2, 2023

Ahajha commented Dec 2, 2023 • edited Loading

This comment has been minimized.

conan-center-bot commented Dec 5, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

Ahajha commented Feb 6, 2024

Ahajha commented Nov 27, 2023 •

edited

Loading

Ahajha commented Dec 2, 2023 •

edited

Loading