-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assembly error in qt5 webengine module with binutils >= 2.41 #21026
Fix assembly error in qt5 webengine module with binutils >= 2.41 #21026
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 92cd216qt/5.15.11@#5590885b2bb50967c121d08d02582f88
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution and patience :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for a sec until I check one last thing, sorry about the noise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question:
- Why is it not applied to all 5.x versions?
- Can the base_path be changed so that the patch itself can be the same used in upstream?
Because I have no time to check the patch with all older qt5 versions, qtwebengine takes forever to build.
Yes. The patch I added was taken from the Debian Qt package. I will change it then to the original ffmpeg patch even though I don't see the benefit. |
233d380
to
d06ef6c
Compare
Sorry, I noticed that the Conan Qt recipe also maintains only 5.15 so I added the patch to all 5.15.x patch releases even though I tested it only for 5.15.11. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…x. Add ffmpeg patch also to older 5.15.x releases.
d5016bb
to
a27843e
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 13 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 19 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Thanks @wdobbe for your contribution and apologies it has taken long for us to review this. I'm preparing a PR with fixes to qt6 webengine for all platforms, and will cherry pick this and include this, preserving your authorship. A couple of points: The most recent qt 5.15 relases (including qt 5.15.14 which the latest we maintin), are based on Chromium version 87 (see https://wiki.qt.io/QtWebEngine/ChromiumVersions) The patch in question https://bugreports.qt.io/browse/QTBUG-116649 has been backported to their 87 branch as per https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/537257 - so this is enough for us to confirm that Qt has backported the fix to the chromium version in the 5.15.x branch. We are a bit more careful/skeptical when patches from Qt 6.x are backported when there is no indication that Qt themselves would do it - we have no intention to maintain Qt5 beyond the official open source releases - although in this case it is clear it is maintained and likely to be part of future 5.15.x releases. |
Fixed in #24826 |
Specify library name and version: qt/5.15.11
The build of the qt5 qtwebengine module fails during the compilation of ffmpeg that comes with the chromium engine:
3rdparty/chromium/third_party/ffmpeg/libavcodec/x86/mathops.h:125: Error: operand type mismatch for
shr'`In qt6 this has been fixed upstream (see https://bugreports.qt.io/browse/QTBUG-116649).
Add this patch also to qt5.
Patch tested with Conan 2.0.13 on Linux x86_64.