-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt/5.x.x: Fix opengl/system dependency to not be required when using es2 #22132
base: master
Are you sure you want to change the base?
Conversation
The opengl/system dependency is very misleading. For Linux, it is a requirement for the legacy gl interface used for X11. This is not necessarily required when using the es2 OpenGL backend and likely Wayland. This PR only requires opengl/system on Linux when with_x11 is enabled. Fixes conan-io#22116.
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 6fe5976qt/5.15.7@#c7214d0a6358240d5cd24bbe6a988d05
|
2ae4311
to
7744414
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 7744414qt/5.15.13@#74449f04d5eb1dbaaf88eddcd234f583
qt/5.15.11@#bc9f8605df9a3e4f0b1b2f11c3f28bc4
qt/5.15.12@#6e29f09bda973792987662b8d24bcb7c
qt/5.15.9@#11afae2407bbefa8aad251296fab51d1
qt/5.15.10@#947d52c0600e8b1b3f0ed5ae2ff8c934
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but it looks to me that the package_info is incomplete: egl is never added to the requirements of a module.
I wish I had the time to refactor the requirements(self) and package_info(self) methods to use a single method defining both components and requirements, instead of duplicating everything :(
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 61e3227qt/5.15.13@#0435e05457d58a9a66f5c77d2c5d1b1f
qt/5.15.12@#c66982aa05890d82543a56c3b834c9f4
qt/5.15.11@#d01f7d826565f4e74d2c8da1a3d72ac5
qt/5.15.10@#89b484eb19e87f9545f16a4d910ebfcb
qt/5.15.9@#55504f8c96f64689cf77ac210a06d905
|
Conan v1 pipeline ❌Failure in build 9 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
would it not make sense to make depending on right now it is:
but it could possibly be:
seems a bit odd to just sort of ignore the value given to the option and do it depending on a particular combination of other options and settings - may as well be a True/False or not an option at all in that case assuming that |
That seems like it should work to me. |
Suggestion #22132 (comment) applied in the commit d69889f |
…jwillikers-qt5-no-opengl-system-es2-22132-cii-command
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
The opengl/system dependency is very misleading.
For Linux, it is a requirement for the legacy gl interface used for X11.
This is not necessarily required when using the es2 OpenGL backend and likely Wayland.
This PR only requires
opengl/system
on Linux whenwith_x11
is enabled.Fixes #22116.
Requires: