Add logr v0.7.0 #21575

ngrodzitski · 2023-12-03T19:07:24Z

Specify library name and version: logr/0.7.0

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

uilianries · 2023-12-07T11:41:56Z

Hello @ngrodzitski ! Thank you for updating this package. Is it not possible to re-use the previous recipe version in all folder with cmake commands?

ngrodzitski · 2023-12-09T20:03:53Z

Hello @ngrodzitski ! Thank you for updating this package. Is it not possible to re-use the previous recipe version in all folder with cmake commands?

I would prefer not to do it. As previous cmake contained LOGR_CONAN_PACKAGING that tuned the behavior of projects' cmake. And simply copying headers for header-only lib looks nicer to me in the way conanfile looks.

AbrilRBS

Thanks a lot for the PR and your patience, we appreciate it :)

Feel free to ping me once the change is done to ensure we merge this asap, thanks!

recipes/logr/v0.7/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

recipes/logr/v0.7/conanfile.py

AbrilRBS · 2024-02-16T00:33:47Z

Hopefully fixed the last remaining issues, thanks a lot for your patience :)

valgur · 2024-02-28T13:58:47Z

recipes/logr/v0.7/conanfile.py

+        "with_spdlog_backend": [True, False],
+        "with_glog_backend": [True, False],
+        "with_log4cplus_backend": [True, False],
+        "with_boostlog_backend": [True, False],


As a minor recommendation: the convention on CCI tends to be to use with_* for external dependencies and enable_* for internal options. Either with_spdlog or enable_splog_backend would be preferable, imo.

uilianries

LGTM pinging @RubenRBS to have a final review.

AbrilRBS

Just checked locally, and removing the spdlog option leads to failures in the test, see my log here:

$ conan create . --version=0.7.0 -b=missing -o="&:with_spdlog=False"

======== Exporting recipe to the cache ========
logr/0.7.0: Exporting package recipe: /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/conanfile.py
logr/0.7.0: exports: File 'conandata.yml' found. Exporting it...
logr/0.7.0: Copied 1 '.py' file: conanfile.py
logr/0.7.0: Copied 1 '.yml' file: conandata.yml
logr/0.7.0: Exported to cache folder: /Users/ruben/.conan2/p/logra9d0d5d023f87/e
logr/0.7.0: Exported: logr/0.7.0#4b0536b9b29df28ae05d4cc686a1ffbb (2024-04-09 14:48:08 UTC)

======== Input profiles ========
Profile host:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=gnu17
compiler.libcxx=libc++
compiler.version=15
os=Macos
[options]
&:with_spdlog=False
[platform_tool_requires]
cmake/3.29.1
[conf]


Profile build:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=gnu17
compiler.libcxx=libc++
compiler.version=15
os=Macos
[platform_tool_requires]
cmake/3.29.1
[conf]



======== Computing dependency graph ========
Graph root
    cli
Requirements
    fmt/10.2.1#9199a7a0611866dea5c8849a77467b25 - Cache
    logr/0.7.0#4b0536b9b29df28ae05d4cc686a1ffbb - Cache

======== Computing necessary packages ========
logr/0.7.0: Compatible package ID 018935559570ac5bad76c76a09459d5957873068 equal to the default package ID: Skipping it.
Requirements
    fmt/10.2.1#9199a7a0611866dea5c8849a77467b25:89b3a2897a1cd53f278d5f41deb52d49528a607b#91a208f054caae3474b063ebe7999a70 - Cache
    logr/0.7.0#4b0536b9b29df28ae05d4cc686a1ffbb:018935559570ac5bad76c76a09459d5957873068 - Build

======== Installing packages ========
fmt/10.2.1: Already installed! (1 of 2)

-------- Installing package logr/0.7.0 (2 of 2) --------
logr/0.7.0: Building from source
logr/0.7.0: Package logr/0.7.0:018935559570ac5bad76c76a09459d5957873068
logr/0.7.0: Copying sources to build folder
logr/0.7.0: Building your package in /Users/ruben/.conan2/p/b/logr44ff2d3f3deb8/b
logr/0.7.0: Generating aggregated env files
logr/0.7.0: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
logr/0.7.0: Calling build()
logr/0.7.0: Package '018935559570ac5bad76c76a09459d5957873068' built
logr/0.7.0: Build folder /Users/ruben/.conan2/p/b/logr44ff2d3f3deb8/b/build-release
logr/0.7.0: Generating the package
logr/0.7.0: Packaging in folder /Users/ruben/.conan2/p/b/logr44ff2d3f3deb8/p
logr/0.7.0: Calling package()
logr/0.7.0: package(): Packaged 1 file: LICENSE
logr/0.7.0: package(): Packaged 5 '.hpp' files
logr/0.7.0: Created package revision 5ece0554f0f9f9a419c8968cd4a07c71
logr/0.7.0: Package '018935559570ac5bad76c76a09459d5957873068' created
logr/0.7.0: Full package reference: logr/0.7.0#4b0536b9b29df28ae05d4cc686a1ffbb:018935559570ac5bad76c76a09459d5957873068#5ece0554f0f9f9a419c8968cd4a07c71
logr/0.7.0: Package folder /Users/ruben/.conan2/p/b/logr44ff2d3f3deb8/p
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'cpp_info.names' used in: fmt/10.2.1

======== Launching test_package ========

======== Computing dependency graph ========
Graph root
    logr/0.7.0 (test package): /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/conanfile.py
Requirements
    fmt/10.2.1#9199a7a0611866dea5c8849a77467b25 - Cache
    logr/0.7.0#4b0536b9b29df28ae05d4cc686a1ffbb - Cache

======== Computing necessary packages ========
Requirements
    fmt/10.2.1#9199a7a0611866dea5c8849a77467b25:89b3a2897a1cd53f278d5f41deb52d49528a607b#91a208f054caae3474b063ebe7999a70 - Cache
    logr/0.7.0#4b0536b9b29df28ae05d4cc686a1ffbb:018935559570ac5bad76c76a09459d5957873068#5ece0554f0f9f9a419c8968cd4a07c71 - Cache

======== Installing packages ========
fmt/10.2.1: Already installed! (1 of 2)
logr/0.7.0: Already installed! (2 of 2)
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'cpp_info.names' used in: fmt/10.2.1

======== Testing the package ========
Removing previously existing 'test_package' build folder: /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release
logr/0.7.0 (test package): Test package build: build/apple-clang-15-armv8-gnu17-release
logr/0.7.0 (test package): Test package build folder: /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release
logr/0.7.0 (test package): Writing generators to /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release/generators
logr/0.7.0 (test package): Generator 'CMakeDeps' calling 'generate()'
logr/0.7.0 (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(logr)
    target_link_libraries(... logr::logr)
logr/0.7.0 (test package): Generator 'CMakeToolchain' calling 'generate()'
logr/0.7.0 (test package): CMakeToolchain generated: conan_toolchain.cmake
logr/0.7.0 (test package): CMakeToolchain generated: CMakePresets.json
logr/0.7.0 (test package): CMakeToolchain generated: ../../../CMakeUserPresets.json
logr/0.7.0 (test package): Generator 'VirtualRunEnv' calling 'generate()'
logr/0.7.0 (test package): Generating aggregated env files
logr/0.7.0 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']

======== Testing the package: Building ========
logr/0.7.0 (test package): Calling build()
logr/0.7.0 (test package): Running CMake.configure()
logr/0.7.0 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package"
-- Using Conan toolchain: /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release/generators/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 17 with extensions ON
-- The CXX compiler identification is AppleClang 15.0.0.15000309
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Component target declared 'logr::logr_base'
-- Conan: Target declared 'logr::logr'
-- Conan: Component target declared 'fmt::fmt'
-- Configuring done (0.3s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release

logr/0.7.0 (test package): Running CMake.build()
logr/0.7.0 (test package): RUN: cmake --build "/Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/build/apple-clang-15-armv8-gnu17-release" -- -j12
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
/Users/ruben/coding/support/external/ngrodzitski/recipes/logr/v0.7/test_package/test_package.cpp:3:10: fatal error: 'spdlog/sinks/stdout_sinks.h' file not found
#include <spdlog/sinks/stdout_sinks.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
make: *** [all] Error 2

ERROR: logr/0.7.0 (test package): Error in build() method, line 20
	cmake.build()
	ConanException: Error 2 while executing

AbrilRBS

Fixed, approving now

uilianries

LGTM

conan-center-bot · 2024-05-29T15:10:56Z

Conan v1 pipeline ✔️

All green in build 3 (289732e49baa594c7c30bb78a01d50e1ceb6ee1e):

logr/0.7.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (289732e49baa594c7c30bb78a01d50e1ceb6ee1e):

logr/0.7.0:
All packages built successfully! (All logs)

Add logr v0.7.0

58ca991

prince-chrismc mentioned this pull request Dec 3, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

ericLemanissier mentioned this pull request Dec 4, 2023

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

This was referenced Dec 5, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

uilianries self-assigned this Dec 7, 2023

conan-center-bot added Failed Unexpected Error labels Dec 10, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into update-logr-v0.7.0

2cecaea

conan-center-bot added Service Under Maintenance and removed Unexpected Error Failed labels Dec 13, 2023

This comment has been minimized.

Sign in to view

ngrodzitski added 4 commits December 21, 2023 14:53

Merge branch 'master' into update-logr-v0.7.0

e5600e7

Merge branch 'master' into update-logr-v0.7.0

b984277

Merge branch 'master' into update-logr-v0.7.0

ea4a451

Merge branch 'master' into update-logr-v0.7.0

9910d93

conan-center-bot removed the Service Under Maintenance label Dec 30, 2023

This comment has been minimized.

Sign in to view

AbrilRBS requested changes Jan 6, 2024

View reviewed changes

recipes/logr/v0.7/conanfile.py Show resolved Hide resolved

conan-center-bot requested a review from jcar87 January 10, 2024 11:42

ngrodzitski added 2 commits February 1, 2024 20:23

Add header-only attribute to logr

fdd2b49

Merge branch 'master' into update-logr-v0.7.0

95277ec

conan-center-bot added Failed Version conflict There is a version conflict when solving the dependencies graph labels Feb 1, 2024

This comment has been minimized.

Sign in to view

Merge branch 'master' into update-logr-v0.7.0

082eca5

ngrodzitski and others added 2 commits February 15, 2024 20:17

Update recipes/logr/v0.7/conanfile.py

d166805

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Update recipes/logr/v0.7/conanfile.py

2b60d0d

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot added the Failed label Feb 15, 2024

This comment has been minimized.

Sign in to view

AbrilRBS reviewed Feb 16, 2024

View reviewed changes

recipes/logr/v0.7/conanfile.py Outdated Show resolved Hide resolved

Update recipes/logr/v0.7/conanfile.py

21702e8

AbrilRBS reviewed Feb 16, 2024

View reviewed changes

recipes/logr/v0.7/conanfile.py Outdated Show resolved Hide resolved

AbrilRBS reviewed Feb 16, 2024

View reviewed changes

recipes/logr/v0.7/conanfile.py Outdated Show resolved Hide resolved

Apply suggestions from code review

c1fc66e

conan-center-bot removed the Failed label Feb 16, 2024

This comment has been minimized.

Sign in to view

valgur approved these changes Feb 28, 2024

View reviewed changes

Switch to with_xxx dependency definition

8ebb463

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from uilianries March 19, 2024 11:40

uilianries previously approved these changes Mar 19, 2024

View reviewed changes

valgur approved these changes Mar 24, 2024

View reviewed changes

conan-center-bot requested a review from AbrilRBS April 9, 2024 11:39

AbrilRBS approved these changes Apr 9, 2024

View reviewed changes

AbrilRBS requested changes Apr 9, 2024

View reviewed changes

Fix test_package

fa5d579

AbrilRBS dismissed uilianries’s stale review via fa5d579 May 29, 2024 13:55

AbrilRBS previously approved these changes May 29, 2024

View reviewed changes

Simplify test_package

289732e

AbrilRBS dismissed their stale review via 289732e May 29, 2024 14:02

AbrilRBS approved these changes May 29, 2024

View reviewed changes

uilianries approved these changes May 29, 2024

View reviewed changes

conan-center-bot merged commit 7602968 into conan-io:master May 29, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add logr v0.7.0 #21575

Add logr v0.7.0 #21575

ngrodzitski commented Dec 3, 2023

uilianries commented Dec 7, 2023

ngrodzitski commented Dec 9, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment •

edited

Loading

This comment has been minimized.

This comment has been minimized.

AbrilRBS commented Feb 16, 2024

This comment has been minimized.

valgur Feb 28, 2024

This comment has been minimized.

uilianries left a comment

AbrilRBS left a comment •

edited

Loading

AbrilRBS left a comment

uilianries left a comment

conan-center-bot commented May 29, 2024

Add logr v0.7.0 #21575

Add logr v0.7.0 #21575

Conversation

ngrodzitski commented Dec 3, 2023

uilianries commented Dec 7, 2023

ngrodzitski commented Dec 9, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

AbrilRBS commented Feb 16, 2024

This comment has been minimized.

valgur Feb 28, 2024

Choose a reason for hiding this comment

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

AbrilRBS left a comment • edited Loading

Choose a reason for hiding this comment

AbrilRBS left a comment

Choose a reason for hiding this comment

uilianries left a comment

Choose a reason for hiding this comment

conan-center-bot commented May 29, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

AbrilRBS left a comment •

edited

Loading

AbrilRBS left a comment •

edited

Loading