Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logr v0.7.0 #21575
Add logr v0.7.0 #21575
Changes from 18 commits
58ca991
2cecaea
e5600e7
b984277
ea4a451
9910d93
fdd2b49
95277ec
082eca5
60f834c
229f959
5c237fe
9714560
c32db33
d166805
2b60d0d
21702e8
c1fc66e
8ebb463
fa5d579
289732e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minor recommendation: the convention on CCI tends to be to use
with_*
for external dependencies andenable_*
for internal options. Eitherwith_spdlog
orenable_splog_backend
would be preferable, imo.