Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of recipe for OpenSSL - Addition of custom default OPENSSL_TLS_SECURITY_LEVEL (issue #21707) #21708

Merged
merged 21 commits into from
Jan 18, 2024

Conversation

jmalopoy
Copy link
Contributor

openssl/3.2

This is a proposal for improvement request #21707.
It allows to specify a custom value to OPENSSL_TLS_SECURITY_LEVEL at build time.


@CLAassistant
Copy link

CLAassistant commented Dec 11, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/openssl//'.

👋 @Hopobcn @Croydon you might be interested. 😉

@ghost
Copy link

ghost commented Dec 11, 2023

I detected other pull requests that are modifying openssl/3.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@jmalopoy
Copy link
Contributor Author

Conan v1 pipeline ❌

Changes not allowed in build 3:

[ceres-solver, openssl, ceres-solver]

Only one library can be changed in the same PR.

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.
See details:

Changes not allowed in build 3:

[ceres-solver, openssl, ceres-solver]

Only one library can be changed in the same PR.

Hi,

I got the error about modification of more than one library, but I cannot see any details of the real issue.
As far as I know, this PR is only modifying openssl, nothing about 'ceres-solver' (I have no clue about what it is and where it is being modified). Could you provide any help? (pinging @prince-chrismc but please, let me know who can I address this issue)

@uilianries
Copy link
Member

Hi,

I got the error about modification of more than one library, but I cannot see any details of the real issue.
As far as I know, this PR is only modifying openssl, nothing about 'ceres-solver' (I have no clue about what it is and where it is being modified). Could you provide any help? (pinging @prince-chrismc but please, let me know who can I address this issue)

Hello @jmalopoy sorry about that error, it's an internal CI error due concurrent CI jobs. I'll restart the CI build. Also, please, use @conan-io/barbarians to ping Conan team when something weird occurs or you need extra support.

@conan-center-bot

This comment has been minimized.

@jmalopoy
Copy link
Contributor Author

Hi,

I got the error about modification of more than one library, but I cannot see any details of the real issue. As far as I know, this PR is only modifying openssl, nothing about 'ceres-solver' (I have no clue about what it is and where it is being modified). Could you provide any help? (pinging @prince-chrismc but please, let me know who can I address this issue)

Hello @jmalopoy sorry about that error, it's an internal CI error due concurrent CI jobs. I'll restart the CI build. Also, please, use @conan-io/barbarians to ping Conan team when something weird occurs or you need extra support.

Thanks for the clarification

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 18 (a6aee97e46a62b2deb9ae208c25d6a00c99ee6b7):

  • openssl/3.1.2:
    All packages built successfully! (All logs)

  • openssl/3.0.12:
    All packages built successfully! (All logs)

  • openssl/3.2.0:
    All packages built successfully! (All logs)

  • openssl/3.1.4:
    All packages built successfully! (All logs)

  • openssl/3.1.3:
    All packages built successfully! (All logs)

  • openssl/3.1.1:
    All packages built successfully! (All logs)

  • openssl/3.0.11:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 19 (a6aee97e46a62b2deb9ae208c25d6a00c99ee6b7):

  • openssl/3.2.0:
    All packages built successfully! (All logs)

  • openssl/3.1.3:
    All packages built successfully! (All logs)

  • openssl/3.1.4:
    All packages built successfully! (All logs)

  • openssl/3.0.12:
    All packages built successfully! (All logs)

  • openssl/3.1.2:
    All packages built successfully! (All logs)

  • openssl/3.0.11:
    All packages built successfully! (All logs)

  • openssl/3.1.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 41b4cff into conan-io:master Jan 18, 2024
43 checks passed
@jmalopoy jmalopoy deleted the package/openssl branch February 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants