[openssl] Set tls security level to automatic for OpenSSL 3.x #22945
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
I detected other pull requests that are modifying openssl/3.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
|
Ops, Conan 1.x is not so smart. Gonna check it now. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
| @@ -386,7 +384,8 @@ def _configure_args(self): | |||
|
|
|||
| args.append("no-fips" if self.options.get_safe("no_fips", True) else "enable-fips") | |||
| args.append("no-md2" if self.options.get_safe("no_md2", True) else "enable-md2") | |||
| args.append("-DOPENSSL_TLS_SECURITY_LEVEL=%s" % str(self.options.tls_security_level)) | |||
| if str(self.options.tls_security_level) != "None": | |||
There was a problem hiding this comment.
Both None and 0 are negative boolean values. Plus, self.options.tls_security_level is a Conan object, it's converted according to the operation needed.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 2 (
|
Specify library name and version: openssl/3.x
The PR #21708 added the new option
tls_security_levelwhich is capable to configure a OpenSSL property. It's configured according to current versions available for 3.x, but OpenSSL moves fast it can be changed in the future, resulting in a misconfiguration in a solitary bump version PR.Thanks to @jcar87 for pointing it, this PR keeps the current option, but instead, uses the default value from OpenSSL when not configured to an explicit value.