Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl proper support for multiple defines #22832

Closed

Conversation

klausholstjacobsen
Copy link
Contributor

openssl/3.x.x

With current recipe multiple defines in AutotoolsToolchain results in this config:

openssl/3.0.13: my %targets = (
    "conan-Release-Linux-x86_64-gcc-11" => {
        inherit_from => [ "linux-x86_64" ],
        cflags => add("-m64 -fPIC -O3"),
        cxxflags => add("-m64 -fPIC -O3"),
        defines => add("NDEBUG MYDEF1 MYDEF2"),
        lflags => add("-m64"),
    },
);

Resulting in the gcc compile command ...-DNDEBUG MYDEF1 MYDEF2... (note the missing '-D') which produces a compile error.

This PR fixes that issue producing this working config:

openssl/3.0.13: my %targets = (
    "conan-Release-Linux-x86_64-gcc-11" => {
        inherit_from => [ "linux-x86_64" ],
        cflags => add("-m64 -fPIC -O3"),
        cxxflags => add("-m64 -fPIC -O3"),
        defines => add("NDEBUG"),
        defines => add("MYDEF1"),
        defines => add("MYDEF2"),
        lflags => add("-m64"),
    },
);

Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/openssl//'.

👋 @Hopobcn @Croydon you might be interested. 😉

@ghost
Copy link

ghost commented Feb 20, 2024

I detected other pull requests that are modifying openssl/3.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@Croydon
Copy link
Contributor

Croydon commented Feb 21, 2024

@klausholstjacobsen Have a look at #22662

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 2 (fe6ad874ea65344eced46de69e7a0c92448a5ad6):

An unexpected error happened and has been reported. Help is on its way! 🏇


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (fe6ad874ea65344eced46de69e7a0c92448a5ad6):

  • openssl/3.2.0:
    All packages built successfully! (All logs)

  • openssl/3.1.5:
    All packages built successfully! (All logs)

  • openssl/3.2.1:
    All packages built successfully! (All logs)

  • openssl/3.1.4:
    All packages built successfully! (All logs)

  • openssl/3.1.3:
    All packages built successfully! (All logs)

  • openssl/3.0.13:
    All packages built successfully! (All logs)

  • openssl/3.0.12:
    All packages built successfully! (All logs)

@ghost ghost mentioned this pull request Mar 29, 2024
3 tasks
@Croydon
Copy link
Contributor

Croydon commented Apr 5, 2024

This should be fixed via #22662

@klausholstjacobsen
Copy link
Contributor Author

Fixed via #22662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants