Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: make things a bit more generic #23304

Closed
wants to merge 4 commits into from
Closed

Conversation

gegles
Copy link
Contributor

@gegles gegles commented Mar 29, 2024

This removes some hardcoded names and allows for the package to be "renamed" more easily...

For example if one wanted to create a distinct openssl-fips package so as to use it in conjunction with the standard openssl package without any collision.

See #22796 for more context

Specify library name and version: openssl/3.x.x


@gegles
Copy link
Contributor Author

gegles commented Mar 29, 2024

FYI @Croydon

Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/openssl//'.

👋 @Hopobcn @Croydon you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@gegles gegles requested a review from SpaceIm April 1, 2024 17:27
@AbrilRBS AbrilRBS self-assigned this Apr 1, 2024
@gegles
Copy link
Contributor Author

gegles commented Apr 10, 2024

@RubenRBS any progress here?

@ghost ghost mentioned this pull request Apr 10, 2024
3 tasks
@gegles
Copy link
Contributor Author

gegles commented Apr 15, 2024

@SpaceIm @RubenRBS could you approve/merge this, please?

Much appreciated!

@Croydon
Copy link
Contributor

Croydon commented Apr 15, 2024

The change here is harmless, but since the purpose is hidden and since it differs from other recipes, it might be very well, that this gets broken regularly one way or another 🤔

@gegles
Copy link
Contributor Author

gegles commented Apr 15, 2024

The change here is harmless, but since the purpose is hidden and since it differs from other recipes, it might be very well, that this gets broken regularly one way or another 🤔

I hear you @Croydon, but I'm willing to take the risk.. 😉
Of course I would love for Conan Center and the community to come up with a good/better solution to the very unusual FIPS versioning requirements, but at least this would enable us to have a very trivial openssl-fips recipe alias that we can simply host locally...

@conan-center-bot

This comment has been minimized.

@gegles
Copy link
Contributor Author

gegles commented Apr 21, 2024

@SpaceIm @RubenRBS, @Croydon could you approve/merge this, please?

Much appreciated!

@gegles
Copy link
Contributor Author

gegles commented Apr 23, 2024

Thanks @Croydon and @valgur!

@RubenRBS, could we merge this now? Thx!

This removes some hardcoded names and allows for the package to be "renamed" more easily...

For example if one wanted to create a distinct `openssl-fips` package so as to use it in conjunction with the standard `openssl` package without any collision.

See conan-io#22796 for more context
@conan-center-bot

This comment has been minimized.

@gegles
Copy link
Contributor Author

gegles commented Apr 26, 2024

@RubenRBS 🙏🏻. Thanks!

Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gegles, thanks for your contribution and for providing insights in #23304.

based on the details you have provided in the issue #22796 I think we can actually implement something along the lines of your initial proposal (a requires on an earlier version of itself) - which would be a lot simpler (a few lines, if I'm not mistaken), and would require no further changes - in particular, no two different recipes

If your team requires changes in Conan Center that we may not be able to merge or need further review, please consider the guidance and advice in: https://docs.conan.io/2/devops/using_conancenter.html#control-and-customization

@gegles
Copy link
Contributor Author

gegles commented Apr 26, 2024

based on the details you have provided in the issue #22796 I think we can actually implement something along the lines of your initial proposal (a requires on an earlier version of itself) - which would be a lot simpler (a few lines, if I'm not mistaken), and would require no further changes - in particular, no two different recipes

@jcar87, that would be amazing, thanks!
Please let me know how/where I can follow that work and if there is anything I can do to test/help. Thx!

@gegles
Copy link
Contributor Author

gegles commented Apr 30, 2024

@jcar87 @RubenRBS, I think it would still make the code cleaner and less "hardcoded" to merge this in, despite the great & elegant alternaitve solution currently worked on in parallel, but if not, I am also fine closing this PR. LMK. Thx!

@gegles
Copy link
Contributor Author

gegles commented May 30, 2024

@jcar87 @RubenRBS, I think it would still make the code cleaner and less "hardcoded" to merge this in, despite the great & elegant alternaitve solution currently worked on in parallel, but if not, I am also fine closing this PR. LMK. Thx!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (b4bf2ede4551bd0dc08191ad986ca75b38c0c2bc):

  • openssl/3.2.1:
    All packages built successfully! (All logs)

  • openssl/3.2.0:
    All packages built successfully! (All logs)

  • openssl/3.0.13:
    All packages built successfully! (All logs)

  • openssl/3.1.4:
    All packages built successfully! (All logs)

  • openssl/3.1.5:
    All packages built successfully! (All logs)

  • openssl/3.1.3:
    All packages built successfully! (All logs)

  • openssl/3.0.12:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (b4bf2ede4551bd0dc08191ad986ca75b38c0c2bc):

  • openssl/3.2.1:
    All packages built successfully! (All logs)

  • openssl/3.2.0:
    All packages built successfully! (All logs)

  • openssl/3.1.3:
    All packages built successfully! (All logs)

  • openssl/3.1.5:
    All packages built successfully! (All logs)

  • openssl/3.0.13:
    All packages built successfully! (All logs)

  • openssl/3.0.12:
    All packages built successfully! (All logs)

  • openssl/3.1.4:
    All packages built successfully! (All logs)

@gegles
Copy link
Contributor Author

gegles commented Jun 4, 2024

Closing due to lack of interest/consensus....

@gegles gegles closed this Jun 4, 2024
@gegles gegles deleted the openssl branch June 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants