-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSSL: Add 3.2.2, 3.1.6, 3.0.14 + removing old versions + small improvements #24224
OpenSSL: Add 3.2.2, 3.1.6, 3.0.14 + removing old versions + small improvements #24224
Conversation
We are deleting pdb files anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think "my" problem, which is really more "How can Conan adapt to the non-standard way OpenSSL provides FIPS" problem, will actually be solved in a very nice way by what @memsharded did in conan-io/conan#16132 (although that will require some change in the recipe as well). I kept the PR open purely because it was still a worthy code cleanup to me (less hardcoded strings), but I am equally happy to close the PR if we don't see any value. thx! |
Sure, did not mean this in a personal "you" way 🙂 |
Conan v1 pipeline ✔️All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Croydon - yes, it's best to keep PRs separate, makes them a lot easier to review.
Building upon the work by @gegles in #23469 I also tried to add 3.3.x versions, but also couldn't get it to work. There is an encoding issue of file paths that I couldn't get to work with several different attempts of patching.
So this pull request contains improvements to the recipes applied along the way and adds new patch versions, but not 3.3.x versions for now.
GitHub is also going to be the only official download source, hence I removed the others. See https://openssl.org/blog/blog/2024/04/30/releases-distribution-changes/