Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL: Add 3.2.2, 3.1.6, 3.0.14 + removing old versions + small improvements #24224

Merged

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Jun 4, 2024

Building upon the work by @gegles in #23469 I also tried to add 3.3.x versions, but also couldn't get it to work. There is an encoding issue of file paths that I couldn't get to work with several different attempts of patching.

So this pull request contains improvements to the recipes applied along the way and adds new patch versions, but not 3.3.x versions for now.

GitHub is also going to be the only official download source, hence I removed the others. See https://openssl.org/blog/blog/2024/04/30/releases-distribution-changes/


Copy link
Contributor

@gegles gegles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Croydon!

Wish you could also grab (or merge) what's in #23304 since it all builds well and was approved by 2 maintainers already). ;-) Thanks!

@Croydon
Copy link
Contributor Author

Croydon commented Jun 4, 2024

I understand that you are searching for a solution to your problem, but I am not going to merge the changes of #23304, sorry. If the Conan team wants they could approve #23304 as it is in a mergeable state.

@gegles
Copy link
Contributor

gegles commented Jun 4, 2024

I understand that you are searching for a solution to your problem, but I am not going to merge the changes of #23304, sorry. If the Conan team wants they could approve #23304 as it is in a mergeable state.

Thanks. I think "my" problem, which is really more "How can Conan adapt to the non-standard way OpenSSL provides FIPS" problem, will actually be solved in a very nice way by what @memsharded did in conan-io/conan#16132 (although that will require some change in the recipe as well).

I kept the PR open purely because it was still a worthy code cleanup to me (less hardcoded strings), but I am equally happy to close the PR if we don't see any value. thx!

@Croydon
Copy link
Contributor Author

Croydon commented Jun 4, 2024

Thanks. I think "my" problem, which is really more "How can Conan adapt to the non-standard way OpenSSL provides FIPS" problem

Sure, did not mean this in a personal "you" way 🙂

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (90f5c8920074d1961fb3caca0153b641ae09c94d):

  • openssl/3.2.2:
    All packages built successfully! (All logs)

  • openssl/3.2.1:
    All packages built successfully! (All logs)

  • openssl/3.1.5:
    All packages built successfully! (All logs)

  • openssl/3.1.6:
    All packages built successfully! (All logs)

  • openssl/3.0.14:
    All packages built successfully! (All logs)

  • openssl/3.0.13:
    All packages built successfully! (All logs)

  • openssl/1.1.1w:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the cleanup both @Croydon and @gegles, we really appreciate it.
As per the 3.3.0 release, I anticipate we'll put some time apart to focus on trying to get a definitive answer as to how to advance on it this/next week, so thanks a lot for your patience

@AbrilRBS AbrilRBS assigned AbrilRBS and jcar87 and unassigned jcar87 Jun 5, 2024
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Croydon - yes, it's best to keep PRs separate, makes them a lot easier to review.

@conan-center-bot conan-center-bot merged commit 2616a38 into conan-io:master Jun 5, 2024
43 checks passed
@Croydon Croydon deleted the openssl_new_patch_versions branch June 5, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants