Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to require itself, previous version visible=False #16132

Merged
merged 4 commits into from
May 20, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Apr 23, 2024

Changelog: Feature: Allow a recipe to requires(..., visible=False) a previous version of itself without raising a loop error.
Docs: Omit

@gegles
Copy link

gegles commented May 7, 2024

@memsharded, any progress/update on this? Just curious. Thx!

@memsharded
Copy link
Member Author

@gegles we are still consider this, the possible risks and future challenges.

What is your use case? Could you please elaborate why are you interested in this feature? So far we have considered it for a very extraordinary situation with openssl, but I can't think of many other cases beyond it.

@memsharded memsharded added this to the 2.4.0 milestone May 7, 2024
@gegles
Copy link

gegles commented May 7, 2024

@gegles we are still consider this, the possible risks and future challenges.

What is your use case? Could you please elaborate why are you interested in this feature? So far we have considered it for a very extraordinary situation with openssl, but I can't think of many other cases beyond it.

Yes, the use case I am interested in is the OpenSSL/FIPS use case that started this whole thing. See the initial idea presented by @jcar87 here.

You're right, as of now, I don't see any other use case for this... but , from my POV, this would be the most elegant and useful way for the community to get the exact right set of binaries directly within the single openssl recipe/package and without needing to do any weird repackaging outside...

As long as it does not harm anything else, I believe loosening the restrictions just enough for something like this to be possible would be a great thing.

Thanks!

@memsharded memsharded marked this pull request as ready for review May 8, 2024 10:17
@memsharded memsharded merged commit 99f8ea3 into conan-io:develop2 May 20, 2024
2 checks passed
@memsharded memsharded deleted the feature/require_bootstrap branch May 20, 2024 10:11
@gegles
Copy link

gegles commented May 20, 2024

Thanks @memsharded!

I'll wait till this is released and will try to work on the update to the OpenSSL recipe based on @jcar87's suggestion.

@memsharded
Copy link
Member Author

I'll wait till this is released and will try to work on the update to the OpenSSL recipe based on @jcar87's suggestion.

The problem is that this will not work with Conan 1, and that is still running on ConanCenter CI, so it might be a bit early to submit this to openssl recipe there, and we might need to wait a bit more.

@szigetics
Copy link

szigetics commented Sep 27, 2024

@memsharded : Do you have any plans to backport this change to Conan v1?

@memsharded
Copy link
Member Author

Hi @szigetics

No, I am afraid this is extremely challenging to be backported to Conan 1.X, this will be a Conan 2.X-only feature.

Note that Conan 2 is already 19 months old, all the dev effort has been moved to Conan 2, it is very strongly recommended to move to Conan 2 as a high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants