Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl-fips: create "alias" recipe for FIPS validated OpenSSL #23303

Closed
wants to merge 1 commit into from

Conversation

gegles
Copy link
Contributor

@gegles gegles commented Mar 28, 2024

This is especially necessary for when 2 distinct versions of the FIPS module and the rest of the openssl libs/execs.

Specify library name and version: openssl-fips/3.0.9

This is my first attempt to address #22796

With this PR, I was successfully able to do the following in my recipe:

    def requirements(self):
        self.requires("openssl/3.2.1")
        self.requires("openssl-fips/3.0.9")

    def generate(self):
        # Get fips shared library
        openssl_fips = self.dependencies["openssl-fips"]
        openssl_mod_dir = openssl_fips.runenv_info.vars(self)["OPENSSL_MODULES"]
        build_lib_dir = os.path.join(self.build_folder, "lib", str(self.settings.build_type), "ossl-modules")
        copy(self, "fips.*", openssl_mod_dir, build_lib_dir)

This PR currently duplicates the whole recipe as well as the test_package which is far from ideal...

Ideally, all we really need to do is the ability to optionally change the package name of the recipe, so we can build both openssl and openssl-fips from the same recipe...

I know --name option can be used in the conan create, but I don't think conan center uses that.

Any thoughts?


@gegles
Copy link
Contributor Author

gegles commented Mar 28, 2024

FYI @Croydon

@conan-center-bot

This comment has been minimized.

This is especially necessary for when 2 distinct versions of the FIPS module and the rest of the openssl libs/execs.
Croydon

This comment was marked as outdated.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (97887408b3a3bdc50b44a693285fa57da46303a7):

  • openssl-fips/3.0.9:
    All packages built successfully! (All logs)

  • openssl-fips/3.0.8:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (97887408b3a3bdc50b44a693285fa57da46303a7):

  • openssl-fips/3.0.9:
    All packages built successfully! (All logs)

  • openssl-fips/3.0.8:
    All packages built successfully! (All logs)

@jcar87 jcar87 self-assigned this Apr 9, 2024
@gegles
Copy link
Contributor Author

gegles commented Apr 30, 2024

Closing this in favor of solution presented here by @jcar87 and worked on in this Conan PR. Thx!

@gegles gegles closed this Apr 30, 2024
@gegles gegles deleted the openssl-fips branch April 30, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants