Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leptonica: add version 1.84.1 #21945

Closed
wants to merge 15 commits into from
Closed

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 26, 2023

Specify library name and version: leptonica/1.84.1


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge changed the title leptonica: add version 1.84.0 leptonica: add version 1.84.1 Jan 7, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Hooks produced the following warnings for commit 9299d49
leptonica/1.80.0@#0298d23175683edc7cc1b4b8bf3223fd
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libleptonica.dylib, libleptonica.5.4.0.dylib, libleptonica.1.80.0.dylib
leptonica/1.79.0@#70ac66c9989cab9d1c87fc118998c0f0
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libleptonica.dylib, libleptonica.1.79.0.dylib, libleptonica.5.3.0.dylib
leptonica/1.78.0@#f989d5d200ff274dde9eaf61d9def769
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libleptonica.dylib, libleptonica.1.78.0.dylib, libleptonica.5.3.0.dylib

@@ -101,6 +123,9 @@ def generate(self):
if Version(self.version) >= "1.83.0":
tc.variables["LIBWEBP_SUPPORT"] = self.options.with_webp
tc.variables["OPENJPEG_SUPPORT"] = self.options.with_openjpeg
if Version(self.version) >= "1.84.0" and self.options.with_openjpeg:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the version 1.84.0 added options to enable dependencies: DanBloomberg/leptonica@1.83.1...1.84.1#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR65

It could be not only added to this recipe, but also fix this preprocessor workaround.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jun 6, 2024

Hi @toge once #23855 is merged, could you please update this PR and add support for these changes? DanBloomberg/leptonica@e2ba2b3 thanks!!

Edit: It's now merged!

@perseoGI
Copy link
Contributor

@toge #23855 has been merged!
Could you take a look to this PR?
Thank you!

@perseoGI perseoGI self-requested a review July 26, 2024 13:26
@toge
Copy link
Contributor Author

toge commented Jul 29, 2024

@AbrilRBS @perseoGI
Thank you for your notification.
I am going to update this recipe.

@conan-center-bot

This comment has been minimized.

@jcar87
Copy link
Contributor

jcar87 commented Jul 30, 2024

Not sure what has happened tot his PR branch - a bad merge or rebase?

@uilianries
Copy link
Member

I merged the master branch over this one. It looks be fixed now.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 2 (14b784973d5d6bc118609f994556b0babea4556d):

  • leptonica/1.83.1:
    Didn't run or was cancelled before finishing

  • leptonica/1.84.1:
    Didn't run or was cancelled before finishing

  • leptonica/1.81.0:
    CI failed to create some packages (All logs)

    Logs for packageID a815e473ea7d5dfa9fa4f9e21d2604075b22138e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=7
    os=Linux
    [options]
    leptonica:shared=True
    
    [...]
    [ 85%] Building C object src/CMakeFiles/leptonica.dir/scale1.c.o
    [ 85%] Building C object src/CMakeFiles/leptonica.dir/scale2.c.o
    [ 86%] Building C object src/CMakeFiles/leptonica.dir/seedfill.c.o
    [ 86%] Building C object src/CMakeFiles/leptonica.dir/sel1.c.o
    [ 87%] Building C object src/CMakeFiles/leptonica.dir/sel2.c.o
    [ 87%] Building C object src/CMakeFiles/leptonica.dir/selgen.c.o
    [ 88%] Building C object src/CMakeFiles/leptonica.dir/shear.c.o
    [ 88%] Building C object src/CMakeFiles/leptonica.dir/skew.c.o
    [ 89%] Building C object src/CMakeFiles/leptonica.dir/spixio.c.o
    [ 90%] Building C object src/CMakeFiles/leptonica.dir/stack.c.o
    [ 90%] Building C object src/CMakeFiles/leptonica.dir/stringcode.c.o
    [ 91%] Building C object src/CMakeFiles/leptonica.dir/strokes.c.o
    [ 91%] Building C object src/CMakeFiles/leptonica.dir/sudoku.c.o
    [ 92%] Building C object src/CMakeFiles/leptonica.dir/textops.c.o
    [ 92%] Building C object src/CMakeFiles/leptonica.dir/tiffio.c.o
    [ 93%] Building C object src/CMakeFiles/leptonica.dir/tiffiostub.c.o
    [ 93%] Building C object src/CMakeFiles/leptonica.dir/utils1.c.o
    [ 94%] Building C object src/CMakeFiles/leptonica.dir/utils2.c.o
    [ 95%] Building C object src/CMakeFiles/leptonica.dir/warper.c.o
    [ 95%] Building C object src/CMakeFiles/leptonica.dir/watershed.c.o
    [ 96%] Building C object src/CMakeFiles/leptonica.dir/webpanimio.c.o
    [ 96%] Building C object src/CMakeFiles/leptonica.dir/webpanimiostub.c.o
    [ 97%] Building C object src/CMakeFiles/leptonica.dir/webpio.c.o
    [ 97%] Building C object src/CMakeFiles/leptonica.dir/webpiostub.c.o
    [ 98%] Building C object src/CMakeFiles/leptonica.dir/writefile.c.o
    [ 98%] Building C object src/CMakeFiles/leptonica.dir/zlibmem.c.o
    [ 99%] Building C object src/CMakeFiles/leptonica.dir/zlibmemstub.c.o
    [100%] Linking C shared library libleptonica.so
    src/CMakeFiles/leptonica.dir/build.make:2787: recipe for target 'src/libleptonica.so.1.81.0' failed
    CMakeFiles/Makefile2:140: recipe for target 'src/CMakeFiles/leptonica.dir/all' failed
    Makefile:148: recipe for target 'all' failed
    leptonica/1.81.0: 
    CMAKE_BUILD_TYPE = Release
    /usr/bin/ld: cannot find -lwebp
    /usr/bin/ld: cannot find -lsharpyuv
    collect2: error: ld returned 1 exit status
    make[2]: *** [src/libleptonica.so.1.81.0] Error 1
    make[1]: *** [src/CMakeFiles/leptonica.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: libpng/1.6.43: requirement zlib/[>=1.2.11 <2] overridden by leptonica/1.81.0 to zlib/1.3.1 
    WARN: libtiff/4.6.0: requirement zlib/[>=1.2.11 <2] overridden by leptonica/1.81.0 to zlib/1.3.1 
    leptonica/1.81.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    leptonica/1.81.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    leptonica/1.81.0: ERROR: Package 'a815e473ea7d5dfa9fa4f9e21d2604075b22138e' build failed
    leptonica/1.81.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/75833/efbff/.conan/data/leptonica/1.81.0/_/_/build/a815e473ea7d5dfa9fa4f9e21d2604075b22138e/build/Release
    ERROR: leptonica/1.81.0: Error in build() method, line 226
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/75833/efbff/.conan/data/leptonica/1.81.0/_/_/build/a815e473ea7d5dfa9fa4f9e21d2604075b22138e/build/Release" '--' '-j3'
    
  • leptonica/1.82.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ErniGH ErniGH mentioned this pull request Nov 12, 2024
3 tasks
@ErniGH
Copy link
Contributor

ErniGH commented Nov 12, 2024

Closing in favour to: #25669

@ErniGH ErniGH closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants