-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leptonica: add version 1.84.1 #21945
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9299d49leptonica/1.80.0@#0298d23175683edc7cc1b4b8bf3223fd
leptonica/1.79.0@#70ac66c9989cab9d1c87fc118998c0f0
leptonica/1.78.0@#f989d5d200ff274dde9eaf61d9def769
|
@@ -101,6 +123,9 @@ def generate(self): | |||
if Version(self.version) >= "1.83.0": | |||
tc.variables["LIBWEBP_SUPPORT"] = self.options.with_webp | |||
tc.variables["OPENJPEG_SUPPORT"] = self.options.with_openjpeg | |||
if Version(self.version) >= "1.84.0" and self.options.with_openjpeg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the version 1.84.0 added options to enable dependencies: DanBloomberg/leptonica@1.83.1...1.84.1#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR65
It could be not only added to this recipe, but also fix this preprocessor workaround.
Hi @toge once #23855 is merged, could you please update this PR and add support for these changes? DanBloomberg/leptonica@e2ba2b3 thanks!! Edit: It's now merged! |
This comment has been minimized.
This comment has been minimized.
Not sure what has happened tot his PR branch - a bad merge or rebase? |
I merged the master branch over this one. It looks be fixed now. |
Conan v1 pipeline ❌Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Closing in favour to: #25669 |
Specify library name and version: leptonica/1.84.1