-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leptonica: fix with_{gif|jpeg|png|tiff|openjpeg|webp}=False #23855
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hooks produced the following warnings for commit f13f461leptonica/1.79.0@#01eb838659a265411f87d04ce7fb2c5c
leptonica/1.80.0@#a766ca25cfbd87d5849c728e31c32406
leptonica/1.78.0@#e719ec3cf52d30112fd605f64c0796a2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Could you please provide some compilation logs of the non-default cases not covered by CI? (A before-after would be great, but the before is already provided in the linked issue so no need to) - It'd help tremendously with future traceability and maintenance if we leave a trail of things working now :)
Thanks!
@RubenRBS I tested the PR correctness with the following script: import subprocess
options = {
"with_zlib": False,
"with_gif": False,
"with_jpeg": False,
"with_png": False,
"with_tiff": False,
"with_openjpeg": False,
"with_webp": False,
}
opts = ' '.join([f'-o "leptonica/*:{k}={v}"' for (k,v) in options.items()])
for v in ["1.78.0", "1.79.0", "1.80.0", "1.81.0", "1.82.0", "1.83.0", "1.83.1"]:
subprocess.run(f"conan create . --version {v} {opts}", shell=True, check=True) Everything builds OK; if you need the whole log, please let me know and I'll attach it. |
@db4 Could you please provide the logs? In case Github complains about the size, you still can open a separated note in gist.github.com Having the logs we have not only a source for reviewing now, but also to compare any change in the future. |
Ok, here they are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked the build.log and looks good, no warning related to replace_in_file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since 1.84.0 it is not necessary to patch the cmake files, we can disable dependencies using ENABLE_FOO
cf DanBloomberg/leptonica@e2ba2b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Specify library name and version: leptonica/all
Non-default with_* options were broken; closes #16906