Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil: fix build in environments without CMake #22539

Closed
wants to merge 2 commits into from

Conversation

Artalus
Copy link
Contributor

@Artalus Artalus commented Jan 25, 2024

Specify library name and version: abseil/X

abseil requires CMake to be built, but does it without respect 🙂


Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/abseil//'.

👋 @Hopobcn you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (c9c461760baa413f855609c8543b5251079924c1):

  • abseil/20230125.3:
    All packages built successfully! (All logs)

  • abseil/20230802.1:
    All packages built successfully! (All logs)

  • abseil/20230125.2:
    All packages built successfully! (All logs)

  • abseil/20230125.1:
    All packages built successfully! (All logs)

  • abseil/20220623.0:
    All packages built successfully! (All logs)

  • abseil/20230125.0:
    All packages built successfully! (All logs)

  • abseil/20220623.1:
    All packages built successfully! (All logs)

  • abseil/20211102.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (c9c461760baa413f855609c8543b5251079924c1):

  • abseil/20230802.1:
    All packages built successfully! (All logs)

  • abseil/20230125.3:
    All packages built successfully! (All logs)

  • abseil/20230125.0:
    All packages built successfully! (All logs)

  • abseil/20230125.2:
    All packages built successfully! (All logs)

  • abseil/20230125.1:
    All packages built successfully! (All logs)

  • abseil/20220623.1:
    All packages built successfully! (All logs)

  • abseil/20211102.0:
    All packages built successfully! (All logs)

  • abseil/20220623.0:
    All packages built successfully! (All logs)

@ghost
Copy link

ghost commented Mar 5, 2024

I detected other pull requests that are modifying abseil/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot conan-center-bot requested a review from jcar87 March 11, 2024 11:41
@valgur
Copy link
Contributor

valgur commented Mar 24, 2024

Abseil requires CMake v3.10 (https://github.com/abseil/abseil-cpp/blob/20240116.1/CMakeLists.txt#L19). We generally don't add CMake as a tool_requires unless v3.16 or newer is needed.

@ghost ghost mentioned this pull request Apr 17, 2024
3 tasks
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Artalus! Thank you for submitting your PR, but having CMake installed is something expected already by CCI: https://github.com/conan-io/conan-center-index/blob/master/docs/developing_recipes_locally.md#setup-your-environment

In case we follow your idea, then any recipe in CCI using CMake should have it listed as tool requirement too ...

The CI service in CCI has CMake 3.15 installed due Conan 2.x design: https://github.com/conan-io/tribe/blob/a36de8dd33852f43091e9f5eb5a7ad83618089f2/design/004-tools-cmake.md?plain=1#L2

For those projects that need a new version, then we list CMake as tool requirement to install a newer version. This is not the case for Abseil, it uses CMake 3.10: https://github.com/abseil/abseil-cpp/blob/master/CMakeLists.txt#L19

If don't have CMake installed in your environment and want to use Conan to install it, I would recommend configuring it directly in your profile instead: https://docs.conan.io/2/reference/config_files/profiles.html#tool-requires

@uilianries uilianries self-assigned this May 16, 2024
@Artalus
Copy link
Contributor Author

Artalus commented May 16, 2024

Cheers for such a detailed explanation! Being able to declare tool-require in the profile might be of service later.

I might argue that if a package depends on buildtool X that is easily available from Conan, it should declare one as such - esp. since CMake now climbed upon a track of slowly shedding off some of its legacy components. But this would be a large change in CCI policies outside the scope of this PR :) I guess we can safely close it then 👍

@uilianries
Copy link
Member

@Artalus Thank you for understanding! Indeed other build tools we still need to list, like meson, but because CMake is used largely in ConanCenterIndex and most adopted.

@uilianries uilianries closed this May 16, 2024
@Artalus Artalus deleted the patch-1 branch May 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants