-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abseil: Add 20240116.1, remove old versions #22982
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/abseil//'. 👋 @Hopobcn you might be interested. 😉 |
I detected other pull requests that are modifying abseil/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Note to self: I don't like the way the edge case is handled, I think it should either be an invalid configuration, or just patch the problem. |
Just a heads up that |
I also noticed this, after this I can put in a PR to bump it to this new version (or at least to the .3 patch). |
I've asked the current tensorflow PR to do that for you :) |
I've reported the GCC7/C++17 issue upstream here: abseil/abseil-cpp#1635. I'm hoping it's a simple fix that could be backported, as that would be the simplest solution rather than the hack I have in place. |
There was a std::result_of workaround (it was removed in C++20) added in #6383, it was fixed as of abseil/abseil-cpp@e19260f, which was late 2020. None of the versions at this point need these extra defines to work. I also tested locally with an MSVC/C++20 build. |
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 (
|
This should be good to go now, we now have the proper upstream fix backported so no need for any hacky workarounds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to ghet the new version out asap, will bump tensorflow in a bit :) Thanks a lot
Specify library name and version: abseil/20240116.1
I've removed some of the older versions, mainly out of date "patch" versions (for example, keeping 20230125.3 but removing .2/.1/.0).