libdwarf: Add 0.9.0 and 0.9.1 #22629

jeremy-rifkin · 2024-02-02T03:17:08Z

Specify library name and version: libdwarf/0.9.0 libdwarf/0.9.1

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2024-02-02T03:18:00Z

🤖 Beep Boop! This pull request is making changes to 'recipes/libdwarf//'.

👋 @Hopobcn you might be interested. 😉

ghost · 2024-02-02T03:24:49Z

I detected other pull requests that are modifying libdwarf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

jeremy-rifkin · 2024-02-04T02:48:22Z

Alright, I think this should be good to go now

uilianries

Looking good: davea42/libdwarf-code@v0.8.0...v0.9.1

Only small comment.

recipes/libdwarf/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

AbrilRBS

Thanks Jeremy :D

AbrilRBS · 2024-02-06T04:03:03Z

recipes/libdwarf/all/conanfile.py

@@ -50,6 +53,8 @@ def requirements(self):
        if self.options.with_dwarfgen or self.version == "20191104":
            self.requires("libelf/0.8.13")
        self.requires("zlib/[>=1.2.11 <2]")
+        if self.version != "20191104" and Version(self.version) >= Version("0.9.0"):


Looks like we might want to remove this 20191104 version by now if upstream is releasing official ones. Wdyt @uilianries?

Yes, please!!! 👍

@jeremy-rifkin Could you please remove the version 20191104 from config.yml, conandata.yml and update the conanfile.py as well? I know it's not related to this PR, but it would help a lot.

It'd be my pleasure!

uilianries · 2024-02-06T15:11:55Z

@jeremy-rifkin Please, keep only libdwarf changed in this PR. The CI not able to build more than one project per PR.

jeremy-rifkin · 2024-02-06T15:12:56Z

Thanks, will do

jeremy-rifkin · 2024-02-06T15:21:00Z

Should updates to libraries depending on libdwarf/20191104 come in separate PRs then?

uilianries · 2024-02-06T15:25:51Z

Should updates to libraries depending on libdwarf/20191104 come in separate PRs then?

Unfortunately yes. Each project requires a separated PR. It should be improved in the future, but for now the CI not capable to process more than one project at same project.

jeremy-rifkin · 2024-02-11T17:52:16Z

Small bump, is there anything else needed from me to get this merged?

recipes/libdwarf/all/conanfile.py

jeremy-rifkin · 2024-02-13T00:00:24Z

Hopefully now ready to go

uilianries · 2024-02-13T10:00:18Z

I asked to the upstream to update the Zstd cmake targets. Let's see if we can incorporate that patch in the project: davea42/libdwarf-code#225

jeremy-rifkin · 2024-02-17T03:55:06Z

@uilianries I've applied the change in davea42/libdwarf-code#226 for using lowercase zstd in libdwarf's cmake. Hopefully this is finally ready to go (pending CI), if there's anything else needed please let me know

conan-center-bot · 2024-02-17T04:25:02Z

Conan v1 pipeline ✔️

All green in build 11 (259a010ec3d036687b38d4dcfc9ef60d9f23a105):

libdwarf/0.7.0:
All packages built successfully! (All logs)
libdwarf/0.8.0:
All packages built successfully! (All logs)
libdwarf/0.5.0:
All packages built successfully! (All logs)
libdwarf/0.9.1:
All packages built successfully! (All logs)
libdwarf/0.9.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (259a010ec3d036687b38d4dcfc9ef60d9f23a105):

libdwarf/0.8.0:
All packages built successfully! (All logs)
libdwarf/0.7.0:
All packages built successfully! (All logs)
libdwarf/0.5.0:
All packages built successfully! (All logs)
libdwarf/0.9.1:
All packages built successfully! (All logs)
libdwarf/0.9.0:
All packages built successfully! (All logs)

uilianries

LGTM

AbrilRBS

Thanks for your patience Jeremy:)

Add libdwarf 0.9.0 and 0.9.1

fffd501

jeremy-rifkin mentioned this pull request Feb 2, 2024

Update zstd target handling and fix a small config error davea42/libdwarf-code#223

Merged

ghost mentioned this pull request Feb 2, 2024

[service] Potentially conflicting recipes #3571

Closed

conan-center-bot added the Failed label Feb 2, 2024

This comment has been minimized.

Sign in to view

Correction for the test package

4554fd3

This comment has been minimized.

Sign in to view

Try to fix 0.9.0

324ac71

This comment has been minimized.

Sign in to view

comment out remaining 0.9.1 references temporarily

9aeb0ef

conan-center-bot added the Unexpected Error label Feb 2, 2024

This comment has been minimized.

Sign in to view

This was referenced Feb 2, 2024

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

ericLemanissier mentioned this pull request Feb 2, 2024

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

Patch off_t

3cf036e

conan-center-bot removed Unexpected Error Failed labels Feb 4, 2024

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Feb 4, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

Try to get 0.9.1 good to go

132bf9f

This comment has been minimized.

Sign in to view

jeremy-rifkin mentioned this pull request Feb 4, 2024

cpptrace: Add v0.4.0 #22655

Merged

3 tasks

uilianries reviewed Feb 5, 2024

View reviewed changes

recipes/libdwarf/all/conanfile.py Outdated Show resolved Hide resolved

uilianries self-assigned this Feb 5, 2024

Update recipes/libdwarf/all/conanfile.py

82b6048

Co-authored-by: Uilian Ries <uilianries@gmail.com>

This comment has been minimized.

Sign in to view

AbrilRBS reviewed Feb 6, 2024

View reviewed changes

AbrilRBS requested a review from uilianries February 6, 2024 04:03

conan-center-bot added the Failed label Feb 6, 2024

This comment has been minimized.

Sign in to view

Remove libdwarf 20191104

638bb73

jeremy-rifkin force-pushed the jr/libdwarf-9 branch from 31c1c52 to 638bb73 Compare February 6, 2024 15:13

conan-center-bot removed the Failed label Feb 6, 2024

This comment has been minimized.

Sign in to view

This was referenced Feb 11, 2024

folly: Update to use libdwarf 0.9.1 #22747

Closed

backward-cpp: Use libdwarf 0.9.1 #22748

Closed

AbrilRBS previously approved these changes Feb 11, 2024

View reviewed changes

jwillikers suggested changes Feb 12, 2024

View reviewed changes

recipes/libdwarf/all/conanfile.py Show resolved Hide resolved

jeremy-rifkin dismissed AbrilRBS’s stale review via 3a46899 February 12, 2024 23:59

Handle dwarfdump license

a713eb8

jeremy-rifkin force-pushed the jr/libdwarf-9 branch from 3a46899 to a713eb8 Compare February 12, 2024 23:59

This comment has been minimized.

Sign in to view

jwillikers approved these changes Feb 13, 2024

View reviewed changes

Update patches to use lowercasae zstd

259a010

uilianries approved these changes Feb 19, 2024

View reviewed changes

AbrilRBS approved these changes Feb 19, 2024

View reviewed changes

conan-center-bot merged commit 04f9866 into conan-io:master Feb 19, 2024
33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libdwarf: Add 0.9.0 and 0.9.1 #22629

libdwarf: Add 0.9.0 and 0.9.1 #22629

jeremy-rifkin commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

ghost commented Feb 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jeremy-rifkin commented Feb 4, 2024

uilianries left a comment

This comment has been minimized.

AbrilRBS left a comment

AbrilRBS Feb 6, 2024

uilianries Feb 6, 2024

jeremy-rifkin Feb 6, 2024

This comment has been minimized.

uilianries commented Feb 6, 2024

jeremy-rifkin commented Feb 6, 2024

jeremy-rifkin commented Feb 6, 2024

uilianries commented Feb 6, 2024

This comment has been minimized.

jeremy-rifkin commented Feb 11, 2024

jeremy-rifkin commented Feb 13, 2024

This comment has been minimized.

uilianries commented Feb 13, 2024

jeremy-rifkin commented Feb 17, 2024 •

edited

Loading

conan-center-bot commented Feb 17, 2024

uilianries left a comment

AbrilRBS left a comment

libdwarf: Add 0.9.0 and 0.9.1 #22629

libdwarf: Add 0.9.0 and 0.9.1 #22629

Conversation

jeremy-rifkin commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

ghost commented Feb 2, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jeremy-rifkin commented Feb 4, 2024

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Feb 6, 2024

Choose a reason for hiding this comment

uilianries Feb 6, 2024

Choose a reason for hiding this comment

jeremy-rifkin Feb 6, 2024

Choose a reason for hiding this comment

This comment has been minimized.

uilianries commented Feb 6, 2024

jeremy-rifkin commented Feb 6, 2024

jeremy-rifkin commented Feb 6, 2024

uilianries commented Feb 6, 2024

This comment has been minimized.

jeremy-rifkin commented Feb 11, 2024

jeremy-rifkin commented Feb 13, 2024

This comment has been minimized.

uilianries commented Feb 13, 2024

jeremy-rifkin commented Feb 17, 2024 • edited Loading

conan-center-bot commented Feb 17, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

uilianries left a comment

Choose a reason for hiding this comment

AbrilRBS left a comment

Choose a reason for hiding this comment

jeremy-rifkin commented Feb 17, 2024 •

edited

Loading