Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zstd target handling and fix a small config error #223

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

jeremy-rifkin
Copy link
Contributor

This is an addition I found necessary while putting together a PR for conan conan-io/conan-center-index#22629

@jeremy-rifkin jeremy-rifkin marked this pull request as draft February 2, 2024 03:24
@jeremy-rifkin jeremy-rifkin marked this pull request as ready for review February 2, 2024 03:50
@jeremy-rifkin jeremy-rifkin marked this pull request as draft February 2, 2024 04:12
@davea42
Copy link
Owner

davea42 commented Feb 3, 2024

Still marked as work in progress. ??? So not ready?

@jeremy-rifkin
Copy link
Contributor Author

Hi Dave sorry for the confusion, I thought I had everything needed for package managers to be happy but it turns out not quite. I'll try to get that sorted out today/tomorrow and then I'll reply once this is ready

@jeremy-rifkin jeremy-rifkin marked this pull request as ready for review February 4, 2024 05:50
@jeremy-rifkin
Copy link
Contributor Author

Alright, I think this should be good to go. The two package manager PR's are conan-io/conan-center-index#22629 and microsoft/vcpkg#36526.

@jeremy-rifkin jeremy-rifkin changed the title Alias ZSTD::ZSTD to zstd::libzstd_shared or zstd::libzstd_static as appropriate Update zstd target handling and fix a small config error Feb 4, 2024
@davea42
Copy link
Owner

davea42 commented Feb 6, 2024

Power out for 40 hours. Then comcast would not come live. Now better.
Lots of catching up to do. will get to the pull as soon as I can.

@jeremy-rifkin
Copy link
Contributor Author

Thanks dave, please let me know if there are any questions or if you spot anything that needs fixing

@davea42 davea42 merged commit 32e9253 into davea42:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants