New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringzilla: add version 3.8.4 #22708

Merged

conan-center-bot merged 29 commits into conan-io:master from toge:stringzilla-3.0.0

Jun 6, 2024

Contributor

toge commented Feb 7, 2024

Specify library name and version: stringzilla/*

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.


          stringzilla: add version 3.0.0

d3263b6

conan-center-bot added the Service Under Maintenance label

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

ericLemanissier mentioned this pull request

Updatable recipes ericLemanissier/conan-center-bot#1

Closed


          Merge branch 'master' into stringzilla-3.0.0

2deaf95

conan-center-bot added Failed and removed Service Under Maintenance labels

This comment has been minimized.

Sign in to view

This was referenced Feb 8, 2024

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

toge added 2 commits

February 9, 2024 14:40


          fix test_package.cpp

3ccfe59


          Merge branch 'stringzilla-3.0.0' of https://github.com/toge/conan-cen…

1ef4683

…ter-index into stringzilla-3.0.0

This comment has been minimized.

Sign in to view


          include array

f71e5b8

This comment has been minimized.

Sign in to view

Contributor Author

toge commented Feb 9, 2024

Wait for merged.
ashvardanian/StringZilla#88

toge marked this pull request as draft

February 9, 2024 07:04


          update 3.1.1

63fe014

toge changed the title ~~stringzilla: add version 3.0.0~~ stringzilla: add version 3.1.1

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

toge marked this pull request as ready for review

February 15, 2024 02:51

Ahajha reviewed

View reviewed changes

recipes/stringzilla/all/test_package/CMakeLists.txt Outdated

Comment on lines 9 to 14

               if(stringzilla_VERSION VERSION_LESS 2.0)
-                target_compile_definitions(${PROJECT_NAME} PRIVATE STRINGZILLA_LESS_2_0)
+                target_compile_definitions(${PROJECT_NAME} PRIVATE STRINGZILLA_API=1)
+              elseif(stringzilla_VERSION VERSION_LESS 3.0)
+                target_compile_definitions(${PROJECT_NAME} PRIVATE STRINGZILLA_API=2)
+              else()
+                target_compile_definitions(${PROJECT_NAME} PRIVATE STRINGZILLA_API=3)

Contributor

Ahajha Feb 16, 2024

Could you put this variable directly in the CMakeToolchain, something like tc.preprocessor_definitions["STRINGZILLA_API"] = Version(self.dependencies["stringzilla"].ref.version).major?

Contributor Author

toge Feb 16, 2024

@Ahajha
Thank you for your comment!
I fixed as you suggested.
Could you review it again?


          set STRINGZILLA_API in conanfile.py

62d0257

This comment has been minimized.

Sign in to view

Ahajha reviewed

View reviewed changes

recipes/stringzilla/all/test_package/test_package.cpp Outdated

+                haystack.end() - haystack.begin() == haystack.size(); // Or `rbegin`, `rend`
+                haystack.find_first_of(" \w\t") == 4; // Or `find_last_of`, `find_first_not_of`, `find_last_not_of`
+                haystack.starts_with(needle) == true; // Or `ends_with`
+                haystack.remove_prefix(needle.size()); // Why is this operation in-place?!

Contributor

Ahajha Feb 16, 2024

Minor, for consistency add return EXIT_SUCCESS;.

Contributor Author

toge Feb 17, 2024

fixed.

recipes/stringzilla/all/test_package/test_package.cpp Show resolved Hide resolved


          simplify test_package.cpp

This comment has been minimized.

Sign in to view

Ahajha approved these changes

View reviewed changes

Contributor

Ahajha left a comment

LGTM

This comment has been minimized.

Sign in to view


          update 3.8.0

e56f26d

This comment has been minimized.

Sign in to view

toge changed the title ~~stringzilla: add version 3.7.3~~ stringzilla: add version 3.8.0


          update 3.8.1

6097dc7

conan-center-bot removed the Service Under Maintenance label

This comment has been minimized.

Sign in to view

toge changed the title ~~stringzilla: add version 3.8.0~~ stringzilla: add version 3.8.1

This comment has been minimized.

Sign in to view


          update 3.8.2

91ae156

toge changed the title ~~stringzilla: add version 3.8.1~~ stringzilla: add version 3.8.2

This comment has been minimized.

Sign in to view

Contributor Author

toge commented Apr 23, 2024

@RubenRBS
Could you review this PR?
The current version of StringZilla is 2.0.4 and StringZilla has been changed lots of API since 3.0.0.


          update 3.8.3

a8c2836

toge changed the title ~~stringzilla: add version 3.8.2~~ stringzilla: add version 3.8.3

conan-center-bot added the Unexpected Error label

This comment has been minimized.

Sign in to view


          Merge branch 'master' into stringzilla-3.0.0

b13584c

conan-center-bot removed the Unexpected Error label

This comment has been minimized.

Sign in to view


          update 3.8.4

565ed44

toge changed the title ~~stringzilla: add version 3.8.3~~ stringzilla: add version 3.8.4

Collaborator

conan-center-bot commented Apr 28, 2024

Conan v1 pipeline ✔️

All green in build 17 (565ed446ebc2c64eb06e2745a080e5b5575929ff):

stringzilla/2.0.4:
All packages built successfully! (All logs)
stringzilla/2.0.3:
All packages built successfully! (All logs)
stringzilla/1.2.2:
All packages built successfully! (All logs)
stringzilla/1.1.3:
All packages built successfully! (All logs)
stringzilla/2.0.1:
All packages built successfully! (All logs)
stringzilla/3.8.4:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 18 (565ed446ebc2c64eb06e2745a080e5b5575929ff):

stringzilla/2.0.4:
All packages built successfully! (All logs)
stringzilla/2.0.3:
All packages built successfully! (All logs)
stringzilla/2.0.1:
All packages built successfully! (All logs)
stringzilla/1.2.2:
All packages built successfully! (All logs)
stringzilla/1.1.3:
All packages built successfully! (All logs)
stringzilla/3.8.4:
All packages built successfully! (All logs)

AbrilRBS self-assigned this

AbrilRBS approved these changes

View reviewed changes

Member

AbrilRBS left a comment

Thanks a lot for your patience while I circled back to this PR - The simplifications look great, thanks a lot! :)

conan-center-bot requested a review from jcar87

June 4, 2024 11:41

perseoGI approved these changes

View reviewed changes

Contributor

perseoGI left a comment

LGTM!

conan-center-bot merged commit 65f82b5 into conan-io:master

38 checks passed

perseoGI self-assigned this

AbrilRBS unassigned perseoGI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ahajha Ahajha approved these changes

perseoGI perseoGI approved these changes

AbrilRBS AbrilRBS approved these changes

valgur valgur approved these changes

jcar87 Awaiting requested review from jcar87

Labels

None yet