Added: Macro SZ_NULL_CHAR, Clang-CL instrinsics. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite declaring it as extern "C", MSVC and Clang-Cl both still enforce that you cannot convert a void*0 (r-value) to a char* for some reason. As such had to added SZ_NULL_CHAR. Clang-Cl also picks and chooses when it wants to use MSVC intrinsics over clang instrinsics so added resolution for that. Also build script was just added PIC even tho it might not be available. NOTE: None of this code is tested as, both Clang-Cl and MSVC are not able to build any of the tests on my machine despite best efforts.
3 tasks
ashvardanian
approved these changes
Feb 11, 2024
ashvardanian
pushed a commit
that referenced
this pull request
Feb 15, 2024
# [3.1.0](v3.0.0...v3.1.0) (2024-02-15) ### Add * `sz_isascii` and UTF8 Levenshtein distance ([a0962fb](a0962fb)) * 32-bit support with CPython ([253a3c1](253a3c1)) * Big-endian support ([b126fab](b126fab)) * Levenshtein & NW score for Rust (#89) ([663a633](663a633)), closes [#89](#89) * Macro SZ_NULL_CHAR, Clang-CL instrinsics. (#88) ([dee90bb](dee90bb)), closes [#88](#88) * serial clz/ctz for Win32 ([c968337](c968337)) ### Docs * sectioning contribution guide ([cf6ced0](cf6ced0)), closes [#91](#91) ### Fix * Clamping bounded Levenshtein ([69892fb](69892fb)) * Memory leak in macro ([c88a72a](c88a72a)) ### Improve * Port to `arm32v7` 32-bit arch ([4acf3b7](4acf3b7)) ### Make * `cibuildwheel.overrides` over custom scripts ([6d8c586](6d8c586)) * Clear root directory ([7497c96](7497c96)) * Constrain workflow names ([079f111](079f111)) * Disable a;; CI versioning ([a55d227](a55d227)) * Drop NumPy dependency ([c56239e](c56239e)) * Fix implicit `malloc` declaration ([f7761be](f7761be)) * Infer big-endian in CMake/setup.py ([72453c6](72453c6)) * Keywords for crates.io ([8d237a6](8d237a6)) * Overwrite packs with same name ([0642318](0642318)) * Packing CIBuildWheels for all archs ([49bee70](49bee70)) * Parallel wheels compilation ([0f5a946](0f5a946)) * Upgrade GitHub CI ([cd424ca](cd424ca)) * Upgrade Python CI ([4f1bf43](4f1bf43)) * Use QEMU for Linux wheels ([ac4556a](ac4556a))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite declaring it as extern "C", MSVC and Clang-Cl both still enforce that you cannot convert a void0 (r-value) to a char for some reason. As such had to added SZ_NULL_CHAR.
Clang-Cl also picks and chooses when it wants to use MSVC intrinsics over clang instrinsics, so added fixes for those issues.
Also cmakelist.txt just assumed PIC even tho it might not be available, so added a check.
NOTE: None of this code is tested as, both Clang-Cl and MSVC are not able to build any of the tests on my machine despite best efforts. #84